[libc-commits] [libc] [llvm] [libc] Move fcntl implementation into the syscall_wrappers layer (PR #207878)
via libc-commits
libc-commits at lists.llvm.org
Mon Jul 6 18:12:50 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- libc/src/__support/File/linux/file.cpp libc/src/__support/OSUtil/linux/syscall_wrappers/dup2.h libc/src/__support/OSUtil/linux/syscall_wrappers/fcntl.h libc/src/fcntl/linux/fcntl.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libc/src/__support/File/linux/file.cpp b/libc/src/__support/File/linux/file.cpp
index c526f2dd0..82395f977 100644
--- a/libc/src/__support/File/linux/file.cpp
+++ b/libc/src/__support/File/linux/file.cpp
@@ -139,7 +139,7 @@ ErrorOr<LinuxFile *> create_file_from_fd(int fd, const char *mode) {
!(fd_flags & O_APPEND)) {
do_seek = true;
if (!linux_syscalls::fcntl(fd, F_SETFL,
- reinterpret_cast<void *>(fd_flags | O_APPEND))
+ reinterpret_cast<void *>(fd_flags | O_APPEND))
.has_value()) {
return Error(EBADF);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/207878
More information about the libc-commits
mailing list