[libc-commits] [libc] [libc][test] Remove internal linkage from ErrnoSetterMatcher helpers … (PR #207707)

[via libc-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Aditya Medhane (flash1729)

<details>
<summary>Changes</summary>

`Succeeds`, `Fails`, and `returns` are static function templates in a header, so any test TU that includes it without using all of them trips `-Wunused-template`. Dropping static also matches the neighboring EQ/NE helpers, which are already non-static.

Part of #<!-- -->202945.

---
Full diff: https://github.com/llvm/llvm-project/pull/207707.diff


1 Files Affected:

- (modified) libc/test/UnitTest/ErrnoSetterMatcher.h (+5-5) 


``````````diff
diff --git a/libc/test/UnitTest/ErrnoSetterMatcher.h b/libc/test/UnitTest/ErrnoSetterMatcher.h
index 212b7a8f83e74..e883308314087 100644
--- a/libc/test/UnitTest/ErrnoSetterMatcher.h
+++ b/libc/test/UnitTest/ErrnoSetterMatcher.h
@@ -153,15 +153,15 @@ template <typename T> internal::Comparator<T> NE(T val) {
 }
 
 template <typename RetT = int>
-static internal::ErrnoSetterMatcher<RetT> Succeeds(RetT ExpectedReturn = 0,
-                                                   int ExpectedErrno = 0) {
+internal::ErrnoSetterMatcher<RetT> Succeeds(RetT ExpectedReturn = 0,
+                                            int ExpectedErrno = 0) {
   return internal::ErrnoSetterMatcher<RetT>(EQ(ExpectedReturn),
                                             EQ(ExpectedErrno));
 }
 
 template <typename RetT = int>
-static internal::ErrnoSetterMatcher<RetT> Fails(int ExpectedErrno,
-                                                RetT ExpectedReturn = -1) {
+internal::ErrnoSetterMatcher<RetT> Fails(int ExpectedErrno,
+                                         RetT ExpectedReturn = -1) {
   return internal::ErrnoSetterMatcher<RetT>(EQ(ExpectedReturn),
                                             EQ(ExpectedErrno));
 }
@@ -180,7 +180,7 @@ template <typename RetT = int> class ErrnoSetterMatcherBuilder {
 };
 
 template <typename RetT>
-static ErrnoSetterMatcherBuilder<RetT> returns(internal::Comparator<RetT> cmp) {
+ErrnoSetterMatcherBuilder<RetT> returns(internal::Comparator<RetT> cmp) {
   return ErrnoSetterMatcherBuilder<RetT>(cmp);
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/207707