[libc-commits] [libc] [llvm] [libc][math] Refactor log10, log1p, log2 implementation to header-only in src/__support/math folder. (PR #176089)

[Muhammad Bassiouni via libc-commits]

bassiounix wrote:

> As asked above, any reason why that isn't covered by CI?

I requested the addition of those to the CI, we only have gcc build bots for main not the precommit CI

> Is the "build with gcc12.2 before sending patches" requirement documented somewhere?

I actually don't know, but what I know from libc maintainers that libc has to compile with both clang and gcc.

> I appreciate the time you're taking to educate me here.

it's nothing really, I'm happy to help :)

> ps: Oh, do you want me to change anything about the bazel files?

I don't think the failures are because of your code, there's a problem with the main bazel build files. we can decide what to do about those once you finish your changes.

> It feels like nobody's really building libm with gcc on a mac. Is linux required to be able to make libm patches?

It's not that linux is required but we need to make sure that all of the supported targets of libc compile and pass the requirements, including linux.
If you want you can try to setup a VM to use GCC or even qemu would be enough, even docker is a fine option or trying to use online machine to try and compile your code.

In any case, you can safely now remove the `constexpr` qualifier because I know for a fact it won't compile.

Also resolve the conflicts and I think you'd be good to go!

https://github.com/llvm/llvm-project/pull/176089