[libc-commits] [libc] [llvm] [libc][math] Refactor llogbf to Header Only. (PR #176494)
via libc-commits
libc-commits at lists.llvm.org
Fri Jan 16 15:22:34 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Anonmiraj (AnonMiraj)
<details>
<summary>Changes</summary>
builds with both Clang and GCC 12.2.
Closes https://github.com/llvm/llvm-project/issues/175354.
CC @<!-- -->bassiounix
---
Full diff: https://github.com/llvm/llvm-project/pull/176494.diff
9 Files Affected:
- (modified) libc/shared/math.h (+1)
- (added) libc/shared/math/llogbf.h (+24)
- (modified) libc/src/__support/math/CMakeLists.txt (+8)
- (added) libc/src/__support/math/llogbf.h (+28)
- (modified) libc/src/math/generic/CMakeLists.txt (+2-1)
- (modified) libc/src/math/generic/llogbf.cpp (+2-4)
- (modified) libc/test/shared/CMakeLists.txt (+1)
- (modified) libc/test/shared/shared_math_test.cpp (+1)
- (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+12-1)
``````````diff
diff --git a/libc/shared/math.h b/libc/shared/math.h
index de1f7b0cc0b5d..1f5fe907747d1 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -66,6 +66,7 @@
#include "math/ldexpf.h"
#include "math/ldexpf128.h"
#include "math/ldexpf16.h"
+#include "math/llogbf.h"
#include "math/log.h"
#include "math/logbf.h"
#include "math/logbf128.h"
diff --git a/libc/shared/math/llogbf.h b/libc/shared/math/llogbf.h
new file mode 100644
index 0000000000000..addaf48a5597a
--- /dev/null
+++ b/libc/shared/math/llogbf.h
@@ -0,0 +1,24 @@
+//===-- Shared llogbf function ----------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_LLOGBF_H
+#define LLVM_LIBC_SHARED_MATH_LLOGBF_H
+
+#include "shared/libc_common.h"
+
+#include "src/__support/math/llogbf.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::llogbf;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_LLOGBF_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 9716a2a3b1ff4..f6abb148dc9d0 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -678,6 +678,14 @@ add_header_library(
libc.src.__support.FPUtil.manipulation_functions
)
+add_header_library(
+ llogbf
+ HDRS
+ llogbf.h
+ DEPENDS
+ libc.src.__support.FPUtil.manipulation_functions
+)
+
add_header_library(
exp_constants
HDRS
diff --git a/libc/src/__support/math/llogbf.h b/libc/src/__support/math/llogbf.h
new file mode 100644
index 0000000000000..1dcdcd0f7311f
--- /dev/null
+++ b/libc/src/__support/math/llogbf.h
@@ -0,0 +1,28 @@
+//===-- Implementation header for llogbf ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_LLOGBF_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_LLOGBF_H
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+LIBC_INLINE static constexpr long llogbf(float x) {
+ return fputil::intlogb<long>(x);
+}
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LLOGBF_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 2729c987d6369..a6c2f37f084d2 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1837,7 +1837,8 @@ add_entrypoint_object(
HDRS
../llogbf.h
DEPENDS
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.llogbf
+ libc.src.errno.errno
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/llogbf.cpp b/libc/src/math/generic/llogbf.cpp
index fedad95cc48ad..2b35e2c07f88f 100644
--- a/libc/src/math/generic/llogbf.cpp
+++ b/libc/src/math/generic/llogbf.cpp
@@ -7,12 +7,10 @@
//===----------------------------------------------------------------------===//
#include "src/math/llogbf.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/llogbf.h"
namespace LIBC_NAMESPACE_DECL {
-LLVM_LIBC_FUNCTION(long, llogbf, (float x)) { return fputil::intlogb<long>(x); }
+LLVM_LIBC_FUNCTION(long, llogbf, (float x)) { return math::llogbf(x); }
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/CMakeLists.txt b/libc/test/shared/CMakeLists.txt
index 51bf25d60451d..ef254f27996b4 100644
--- a/libc/test/shared/CMakeLists.txt
+++ b/libc/test/shared/CMakeLists.txt
@@ -69,4 +69,5 @@ add_fp_unittest(
libc.src.__support.math.rsqrtf
libc.src.__support.math.rsqrtf16
libc.src.__support.math.sin
+ libc.src.__support.math.llogbf
)
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 8079890357ca0..ca529c9f3bf64 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -80,6 +80,7 @@ TEST(LlvmLibcSharedMathTest, AllFloat) {
EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::logbf(1.0f));
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::rsqrtf(1.0f));
+ EXPECT_EQ(long(0), LIBC_NAMESPACE::shared::llogbf(1.0f));
}
TEST(LlvmLibcSharedMathTest, AllDouble) {
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index de7aa4dfa74ab..95a4504816b21 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2889,6 +2889,14 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_llogbf",
+ hdrs = ["src/__support/math/llogbf.h"],
+ deps = [
+ ":__support_fputil_manipulation_functions",
+ ],
+)
+
libc_support_library(
name = "__support_math_log",
hdrs = ["src/__support/math/log.h"],
@@ -4415,7 +4423,10 @@ libc_math_function(
libc_math_function(name = "llogb")
-libc_math_function(name = "llogbf")
+libc_math_function(
+ name = "llogbf",
+ additional_deps = [":__support_math_llogbf"],
+)
libc_math_function(name = "llogbl")
``````````
</details>
https://github.com/llvm/llvm-project/pull/176494
More information about the libc-commits
mailing list