[libc-commits] [libc] 716b547 - [libc][math] Refactor logbf to Header Only. (#176222)
via libc-commits
libc-commits at lists.llvm.org
Fri Jan 16 14:15:09 PST 2026
Author: Anonmiraj
Date: 2026-01-17T00:15:04+02:00
New Revision: 716b54784f1b52283285fb8597c35244bb8c2759
URL: https://github.com/llvm/llvm-project/commit/716b54784f1b52283285fb8597c35244bb8c2759
DIFF: https://github.com/llvm/llvm-project/commit/716b54784f1b52283285fb8597c35244bb8c2759.diff
LOG: [libc][math] Refactor logbf to Header Only. (#176222)
builds with both Clang and GCC 12.2.
Closes https://github.com/llvm/llvm-project/issues/175364.
Added:
libc/shared/math/logbf.h
libc/src/__support/math/logbf.h
Modified:
libc/shared/math.h
libc/src/__support/math/CMakeLists.txt
libc/src/math/generic/CMakeLists.txt
libc/src/math/generic/logbf.cpp
libc/test/shared/CMakeLists.txt
libc/test/shared/shared_math_test.cpp
utils/bazel/llvm-project-overlay/libc/BUILD.bazel
Removed:
################################################################################
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 8102ff38584bd..de1f7b0cc0b5d 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -67,6 +67,7 @@
#include "math/ldexpf128.h"
#include "math/ldexpf16.h"
#include "math/log.h"
+#include "math/logbf.h"
#include "math/logbf128.h"
#include "math/logbf16.h"
#include "math/rsqrtf.h"
diff --git a/libc/shared/math/logbf.h b/libc/shared/math/logbf.h
new file mode 100644
index 0000000000000..32665a0f9070b
--- /dev/null
+++ b/libc/shared/math/logbf.h
@@ -0,0 +1,22 @@
+//===-- Shared logbf function -----------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_LOGBF_H
+#define LLVM_LIBC_SHARED_MATH_LOGBF_H
+
+#include "src/__support/math/logbf.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::logbf;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_LOGBF_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 5bf0648be02e2..9716a2a3b1ff4 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1079,6 +1079,14 @@ add_header_library(
libc.src.__support.macros.properties.types
)
+add_header_library(
+ logbf
+ HDRS
+ logbf.h
+ DEPENDS
+ libc.src.__support.FPUtil.manipulation_functions
+)
+
add_header_library(
log_range_reduction
HDRS
diff --git a/libc/src/__support/math/logbf.h b/libc/src/__support/math/logbf.h
new file mode 100644
index 0000000000000..1b0daf92784ed
--- /dev/null
+++ b/libc/src/__support/math/logbf.h
@@ -0,0 +1,26 @@
+//===-- Implementation header for logbf -------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_LOGBF_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_LOGBF_H
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+LIBC_INLINE static constexpr float logbf(float x) { return fputil::logb(x); }
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LOGBF_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 11f1e0dd5e8b4..2729c987d6369 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2173,7 +2173,8 @@ add_entrypoint_object(
HDRS
../logbf.h
DEPENDS
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.logbf
+ libc.src.errno.errno
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/logbf.cpp b/libc/src/math/generic/logbf.cpp
index 0dc0251afe290..e319736adc71e 100644
--- a/libc/src/math/generic/logbf.cpp
+++ b/libc/src/math/generic/logbf.cpp
@@ -7,12 +7,10 @@
//===----------------------------------------------------------------------===//
#include "src/math/logbf.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/logbf.h"
namespace LIBC_NAMESPACE_DECL {
-LLVM_LIBC_FUNCTION(float, logbf, (float x)) { return fputil::logb(x); }
+LLVM_LIBC_FUNCTION(float, logbf, (float x)) { return math::logbf(x); }
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/CMakeLists.txt b/libc/test/shared/CMakeLists.txt
index a2fa0146adadb..51bf25d60451d 100644
--- a/libc/test/shared/CMakeLists.txt
+++ b/libc/test/shared/CMakeLists.txt
@@ -60,6 +60,7 @@ add_fp_unittest(
libc.src.__support.math.fsqrt
libc.src.__support.math.ilogbf16
libc.src.__support.math.log
+ libc.src.__support.math.logbf
libc.src.__support.math.logbf128
libc.src.__support.math.logbf16
libc.src.__support.math.ldexpf
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index baf725b1accc3..8079890357ca0 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -78,6 +78,7 @@ TEST(LlvmLibcSharedMathTest, AllFloat) {
ASSERT_FP_EQ(float(8 << 5), LIBC_NAMESPACE::shared::ldexpf(8.0f, 5));
ASSERT_FP_EQ(float(-1 * (8 << 5)), LIBC_NAMESPACE::shared::ldexpf(-8.0f, 5));
+ EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::logbf(1.0f));
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::rsqrtf(1.0f));
}
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 6d55f95b02b8f..de7aa4dfa74ab 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2906,6 +2906,15 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_logbf",
+ hdrs = ["src/__support/math/logbf.h"],
+ deps = [
+ ":__support_common",
+ ":__support_fputil_manipulation_functions",
+ ],
+)
+
libc_support_library(
name = "__support_math_logbf128",
hdrs = ["src/__support/math/logbf128.h"],
@@ -4558,7 +4567,12 @@ libc_math_function(
libc_math_function(name = "logb")
-libc_math_function(name = "logbf")
+libc_math_function(
+ name = "logbf",
+ additional_deps = [
+ ":__support_math_logbf",
+ ],
+)
libc_math_function(name = "logbl")
More information about the libc-commits
mailing list