[libc-commits] [libc] [libc] Support %lc in printf (PR #169983)

[Kewen Meng via libc-commits]

Kewen12 wrote:

> > Hello! It seems this PR caused a link error that breaks bots. maybe need a cmake update? Could you please fix it? Thanks!
> > ```
> > [4286/4884] Linking CXX executable bin/llvm-gpu-loader
> > FAILED: bin/llvm-gpu-loader 
> > : && /usr/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -Wl,-rpath-link,/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/./lib  -Wl,--gc-sections tools/llvm-gpu-loader/CMakeFiles/llvm-gpu-loader.dir/llvm-gpu-loader.cpp.o tools/llvm-gpu-loader/CMakeFiles/llvm-gpu-loader.dir/amdhsa.cpp.o -o bin/llvm-gpu-loader  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/lib:/opt/rocm/lib:"  lib/libLLVMOption.so.23.0git  lib/libLLVMFrontendOffloading.so.23.0git  /opt/rocm/lib/libhsa-runtime64.so.1.14.60300  lib/libLLVMObject.so.23.0git  lib/libLLVMBinaryFormat.so.23.0git  lib/libLLVMTargetParser.so.23.0git  lib/libLLVMSupport.so.23.0git  -Wl,-rpath-link,/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/lib && :
> > /usr/bin/ld: tools/llvm-gpu-loader/CMakeFiles/llvm-gpu-loader.dir/amdhsa.cpp.o: in function `int __llvm_libc_common_utils::printf_core::convert<(__llvm_libc_common_utils::printf_core::WriteMode)0>(__llvm_libc_common_utils::printf_core::Writer<(__llvm_libc_common_utils::printf_core::WriteMode)0>*, __llvm_libc_common_utils::printf_core::FormatSection const&)':
> > amdhsa.cpp:(.text._ZN24__llvm_libc_common_utils11printf_core7convertILNS0_9WriteModeE0EEEiPNS0_6WriterIXT_EEERKNS0_13FormatSectionE[_ZN24__llvm_libc_common_utils11printf_core7convertILNS0_9WriteModeE0EEEiPNS0_6WriterIXT_EEERKNS0_13FormatSectionE]+0x556): undefined reference to `__llvm_libc_common_utils::internal::wcrtomb(char*, wchar_t, __llvm_libc_common_utils::internal::mbstate*)'
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > bot: https://lab.llvm.org/buildbot/#/builders/73/builds/15649
> 
> Yes looking into it! Apologies I wasn't aware of the AMD openmp tests.

Thanks! If anything we can help with, feel feel to let us know :)

https://github.com/llvm/llvm-project/pull/169983