[libc-commits] [libc] [libc] Support %lc in printf (PR #169983)

[LLVM Continuous Integration via libc-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `libc` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/20528

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
                 from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/cmake/Modules/../../libc/shared/rpc_server.h:13,
                 from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/tools/llvm-gpu-loader/server.h:17,
                 from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/tools/llvm-gpu-loader/amdhsa.cpp:17:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/cmake/Modules/../../libc/src/stdio/printf_core/writer.h:49:30: warning: ‘maybe_unused’ attribute ignored [-Wattributes]
   49 |   [[maybe_unused]] WriteMode write_mode_;
      |                              ^~~~~~~~~~~
10.688 [690/21/4106] Linking CXX shared library lib/libLLVMSelectionDAG.so.23.0git
10.701 [689/21/4107] Creating library symlink lib/libLLVMSelectionDAG.so
10.755 [688/21/4108] Building AMDGPUGenRegBankGICombiner.inc...
10.776 [688/20/4109] Linking CXX executable bin/llvm-gpu-loader
FAILED: bin/llvm-gpu-loader 
: && /usr/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -Wl,-rpath-link,/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./lib  -Wl,--gc-sections tools/llvm-gpu-loader/CMakeFiles/llvm-gpu-loader.dir/llvm-gpu-loader.cpp.o tools/llvm-gpu-loader/CMakeFiles/llvm-gpu-loader.dir/amdhsa.cpp.o -o bin/llvm-gpu-loader  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib:/opt/rocm/lib:"  lib/libLLVMOption.so.23.0git  lib/libLLVMFrontendOffloading.so.23.0git  /opt/rocm/lib/libhsa-runtime64.so.1.14.60302  lib/libLLVMObject.so.23.0git  lib/libLLVMBinaryFormat.so.23.0git  lib/libLLVMTargetParser.so.23.0git  lib/libLLVMSupport.so.23.0git  -Wl,-rpath-link,/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib && :
/usr/bin/ld: tools/llvm-gpu-loader/CMakeFiles/llvm-gpu-loader.dir/amdhsa.cpp.o: in function `int __llvm_libc_common_utils::printf_core::convert<(__llvm_libc_common_utils::printf_core::WriteMode)0>(__llvm_libc_common_utils::printf_core::Writer<(__llvm_libc_common_utils::printf_core::WriteMode)0>*, __llvm_libc_common_utils::printf_core::FormatSection const&)':
amdhsa.cpp:(.text._ZN24__llvm_libc_common_utils11printf_core7convertILNS0_9WriteModeE0EEEiPNS0_6WriterIXT_EEERKNS0_13FormatSectionE[_ZN24__llvm_libc_common_utils11printf_core7convertILNS0_9WriteModeE0EEEiPNS0_6WriterIXT_EEERKNS0_13FormatSectionE]+0x556): undefined reference to `__llvm_libc_common_utils::internal::wcrtomb(char*, wchar_t, __llvm_libc_common_utils::internal::mbstate*)'
collect2: error: ld returned 1 exit status
10.817 [688/19/4110] Building CXX object tools/lld/Common/CMakeFiles/lldCommon.dir/Version.cpp.o
10.866 [688/18/4111] Linking CXX shared library lib/libLLVMGlobalISel.so.23.0git
11.006 [688/17/4112] Building AMDGPUGenPreLegalizeGICombiner.inc...
11.055 [688/16/4113] Building AMDGPUGenDisassemblerTables.inc...
11.103 [688/15/4114] Linking CXX shared library lib/libclangAST.so.23.0git
11.124 [688/14/4115] Building AMDGPUGenPostLegalizeGICombiner.inc...
11.380 [688/13/4116] Building AMDGPUGenSubtargetInfo.inc...
11.685 [688/12/4117] Building AMDGPUGenMCCodeEmitter.inc...
12.072 [688/11/4118] Building AMDGPUGenSearchableTables.inc...
14.047 [688/10/4119] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
14.129 [688/9/4120] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
17.199 [688/8/4121] Building AMDGPUGenCallingConv.inc...
17.989 [688/7/4122] Building AMDGPUGenAsmWriter.inc...
21.047 [688/6/4123] Building AMDGPUGenGlobalISel.inc...
21.759 [688/5/4124] Building AMDGPUGenInstrInfo.inc...
21.870 [688/4/4125] Building AMDGPUGenDAGISel.inc...
26.117 [688/3/4126] Building AMDGPUGenAsmMatcher.inc...
27.086 [688/2/4127] Building AMDGPUGenRegisterInfo.inc...
27.411 [688/1/4128] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/169983