[libc-commits] [libc] 79be97d - [libc][math] Refactor ilogbf16 implementation to header-only in src/__support/math folder. (#175450)
via libc-commits
libc-commits at lists.llvm.org
Sun Jan 11 19:05:39 PST 2026
Author: mitchell
Date: 2026-01-12T05:05:35+02:00
New Revision: 79be97d90a5aa1bfe8667ce494c30ed4c4dcccf6
URL: https://github.com/llvm/llvm-project/commit/79be97d90a5aa1bfe8667ce494c30ed4c4dcccf6
DIFF: https://github.com/llvm/llvm-project/commit/79be97d90a5aa1bfe8667ce494c30ed4c4dcccf6.diff
LOG: [libc][math] Refactor ilogbf16 implementation to header-only in src/__support/math folder. (#175450)
Closes [#175346](https://github.com/llvm/llvm-project/issues/175346),
Part of #175344
Added:
libc/shared/math/ilogbf16.h
libc/src/__support/math/ilogbf16.h
Modified:
libc/shared/math.h
libc/src/__support/math/CMakeLists.txt
libc/src/math/generic/CMakeLists.txt
libc/src/math/generic/ilogbf16.cpp
libc/test/shared/CMakeLists.txt
libc/test/shared/shared_math_test.cpp
utils/bazel/llvm-project-overlay/libc/BUILD.bazel
Removed:
################################################################################
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 010658357b144..287f3aea1565a 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -60,6 +60,7 @@
#include "math/frexpf.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"
+#include "math/ilogbf16.h"
#include "math/ldexpf.h"
#include "math/ldexpf128.h"
#include "math/ldexpf16.h"
diff --git a/libc/shared/math/ilogbf16.h b/libc/shared/math/ilogbf16.h
new file mode 100644
index 0000000000000..6be207b589e0c
--- /dev/null
+++ b/libc/shared/math/ilogbf16.h
@@ -0,0 +1,28 @@
+//===-- Shared ilogbf16 function --------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_ILOGBF16_H
+#define LLVM_LIBC_SHARED_MATH_ILOGBF16_H
+
+#include "include/llvm-libc-macros/float16-macros.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT16
+
+#include "src/__support/math/ilogbf16.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::ilogbf16;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT16
+
+#endif // LLVM_LIBC_SHARED_MATH_ILOGBF16_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 7219800a3e9d2..4139a1b1d3444 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -631,6 +631,17 @@ add_header_library(
libc.src.__support.FPUtil.manipulation_functions
)
+add_header_library(
+ ilogbf16
+ HDRS
+ ilogbf16.h
+ DEPENDS
+ libc.src.__support.macros.config
+ libc.src.__support.macros.properties.types
+ libc.src.__support.FPUtil.manipulation_functions
+ libc.include.llvm-libc-macros.float16_macros
+)
+
add_header_library(
ldexpf128
HDRS
diff --git a/libc/src/__support/math/ilogbf16.h b/libc/src/__support/math/ilogbf16.h
new file mode 100644
index 0000000000000..db9b8494f8a15
--- /dev/null
+++ b/libc/src/__support/math/ilogbf16.h
@@ -0,0 +1,34 @@
+//===-- Implementation header for ilogbf16 ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ILOGBF16_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_ILOGBF16_H
+
+#include "include/llvm-libc-macros/float16-macros.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT16
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+LIBC_INLINE constexpr int ilogbf16(float16 x) {
+ return fputil::intlogb<int>(x);
+}
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT16
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ILOGBF16_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index feaedbe55100b..6de4cf376bf02 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1792,8 +1792,7 @@ add_entrypoint_object(
HDRS
../ilogbf16.h
DEPENDS
- libc.src.__support.macros.properties.types
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.ilogbf16
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/ilogbf16.cpp b/libc/src/math/generic/ilogbf16.cpp
index 9217cdfe01651..451b704618e44 100644
--- a/libc/src/math/generic/ilogbf16.cpp
+++ b/libc/src/math/generic/ilogbf16.cpp
@@ -7,14 +7,10 @@
//===----------------------------------------------------------------------===//
#include "src/math/ilogbf16.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/ilogbf16.h"
namespace LIBC_NAMESPACE_DECL {
-LLVM_LIBC_FUNCTION(int, ilogbf16, (float16 x)) {
- return fputil::intlogb<int>(x);
-}
+LLVM_LIBC_FUNCTION(int, ilogbf16, (float16 x)) { return math::ilogbf16(x); }
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/CMakeLists.txt b/libc/test/shared/CMakeLists.txt
index aa6881025ab71..c5955ecfd54cb 100644
--- a/libc/test/shared/CMakeLists.txt
+++ b/libc/test/shared/CMakeLists.txt
@@ -56,6 +56,7 @@ add_fp_unittest(
libc.src.__support.math.frexpf
libc.src.__support.math.frexpf128
libc.src.__support.math.frexpf16
+ libc.src.__support.math.ilogbf16
libc.src.__support.math.log
libc.src.__support.math.ldexpf
libc.src.__support.math.ldexpf128
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index f7cd06644b69e..20a98a1a9138c 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -41,6 +41,8 @@ TEST(LlvmLibcSharedMathTest, AllFloat16) {
0.75f16, LIBC_NAMESPACE::shared::frexpf16(24.0f16, &exponent));
EXPECT_EQ(exponent, 5);
+ EXPECT_EQ(0, LIBC_NAMESPACE::shared::ilogbf16(1.0f16));
+
EXPECT_FP_EQ(0x1.921fb6p+0f16, LIBC_NAMESPACE::shared::acosf16(0.0f16));
}
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 3de847b268499..c03c21b834895 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2842,6 +2842,17 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_ilogbf16",
+ hdrs = ["src/__support/math/ilogbf16.h"],
+ deps = [
+ ":__support_common",
+ ":__support_fputil_manipulation_functions",
+ ":__support_macros_config",
+ ":llvm_libc_macros_float16_macros",
+ ],
+)
+
libc_support_library(
name = "__support_math_ldexpf128",
hdrs = ["src/__support/math/ldexpf128.h"],
@@ -4327,7 +4338,12 @@ libc_math_function(name = "ilogbl")
libc_math_function(name = "ilogbf128")
-libc_math_function(name = "ilogbf16")
+libc_math_function(
+ name = "ilogbf16",
+ additional_deps = [
+ ":__support_math_ilogbf16",
+ ],
+)
libc_math_function(name = "ldexp")
More information about the libc-commits
mailing list