[libc-commits] [libc] [llvm] [libc][math] Refactor logf16 to header-only shared math (PR #175408)
via libc-commits
libc-commits at lists.llvm.org
Sat Jan 10 22:16:46 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- libc/shared/math/logf16.h libc/src/__support/math/logf16.h libc/shared/math.h libc/src/math/generic/logf16.cpp libc/test/shared/shared_math_test.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libc/shared/math/logf16.h b/libc/shared/math/logf16.h
index 8d04d5a21..d7170b52e 100644
--- a/libc/shared/math/logf16.h
+++ b/libc/shared/math/logf16.h
@@ -1,4 +1,5 @@
-//===-- Shared logf16 function ------------------------------------*- C++ -*-===//
+//===-- Shared logf16 function ------------------------------------*- C++
+//-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
diff --git a/libc/src/__support/math/logf16.h b/libc/src/__support/math/logf16.h
index ef88febec..86bb586c8 100644
--- a/libc/src/__support/math/logf16.h
+++ b/libc/src/__support/math/logf16.h
@@ -167,5 +167,4 @@ LIBC_INLINE float16 logf16(float16 x) {
} // namespace LIBC_NAMESPACE_DECL
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LOGF16_H
diff --git a/libc/src/math/generic/logf16.cpp b/libc/src/math/generic/logf16.cpp
index 1ae287fc9..7149081a8 100644
--- a/libc/src/math/generic/logf16.cpp
+++ b/libc/src/math/generic/logf16.cpp
@@ -11,8 +11,6 @@
namespace LIBC_NAMESPACE_DECL {
-LLVM_LIBC_FUNCTION(float16, logf16, (float16 x)) {
- return math::logf16(x);
-}
+LLVM_LIBC_FUNCTION(float16, logf16, (float16 x)) { return math::logf16(x); }
} // namespace LIBC_NAMESPACE_DECL
``````````
</details>
https://github.com/llvm/llvm-project/pull/175408
More information about the libc-commits
mailing list