[libc-commits] [libc] [libc][wctype] Upstream custom slice implementation from PtrHash-cc prototype to LLVM libc (PR #174779)

[Muhammad Bassiouni via libc-commits]

================
@@ -0,0 +1,117 @@
+//===-- Internal utils for wctype conversion code - slice -------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+// Similar to cpp::span with additional functionality
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_WCTYPE_CONVERSION_UTILS_SLICE_H
+#define LLVM_LIBC_SRC___SUPPORT_WCTYPE_CONVERSION_UTILS_SLICE_H
+
+#include "hdr/types/size_t.h"
+#include "src/__support/CPP/algorithm.h"
+#include "src/__support/CPP/expected.h"
+#include "src/__support/CPP/span.h"
+#include "src/__support/libc_assert.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace wctype_internal {
+
+namespace conversion_utils {
+
+enum class Ordering {
+  /// An ordering where a compared value is less than another.
+  Less = -1,
+  /// An ordering where a compared value is equal to another.
+  Equal = 0,
+  /// An ordering where a compared value is greater than another.
+  Greater = 1,
+};
+
+template <typename T> struct Slice : public cpp::span<T> {
----------------
bassiounix wrote:

To illustrate what I mean, here's a call to this method in the hasher

```cc
    for (auto part_in_shard : Range(1, parts_per_shard_ + 1)) {
      part_starts[part_in_shard] =
          Slice(hashes)
              .binary_search_by([&](typename Hx::H h) {
                if (this->part(h) < shard * parts_per_shard_ + part_in_shard) {
                  return Ordering::Less;
                } else {
                  return Ordering::Greater;
                }
              })
              .error();
    }
```

There's no `value` I am searching for as part of the `std::binary_search` signature.
This code is not standard C++, it's something else.

https://github.com/llvm/llvm-project/pull/174779