[libc-commits] [libc] [llvm] [libc][math] Refactor sin implementation to header-only in src/__support/math folder. (PR #175200)

Muhammad Bassiouni via libc-commits libc-commits at lists.llvm.org
Fri Jan 9 09:11:10 PST 2026


================
@@ -89,6 +89,7 @@ TEST(LlvmLibcSharedMathTest, AllDouble) {
   EXPECT_FP_EQ(0x1p+0, LIBC_NAMESPACE::shared::exp2(0.0));
   EXPECT_FP_EQ(0x1p+0, LIBC_NAMESPACE::shared::exp10(0.0));
   EXPECT_FP_EQ(0x0p+0, LIBC_NAMESPACE::shared::expm1(0.0));
+  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::sin(0.0));
----------------
bassiounix wrote:

Just to follow the number convention. Current is fine anyway
```suggestion
  EXPECT_FP_EQ(0x0p+0, LIBC_NAMESPACE::shared::sin(0.0));
```

https://github.com/llvm/llvm-project/pull/175200


More information about the libc-commits mailing list