[libc-commits] [libc] [libc] Add getc, ungetc, fflush to enable libc++ iostream on baremetal (PR #175530)

[Petr Hosek via libc-commits]

petrhosek wrote:

> I've confirmed that reverting your patch fixed the issue in 2 stage builds. I'm not totally sure why this is only showing up there on windows, though.
> 
> Bot w/ revert: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-windows-x64/b8689944263317709073/overview
> 
> @petrhosek any clue as to why this would happen? maybe some CMake interactions? or somethign in the stage2 plumbing for the runtimes builds that only shows up on Windows?

I don't see any obvious reason why this change would lead to that particular issue. I'd need to reproduce locally this to figure out what's going on but I'm out this week without an access to a Windows instance.

I'd suggest revert this change in the meantime. A possible path forward could be to break up this change into multiple PRs and land them piecemeal (e.g. one PR for `getc`, one PR for `fflush` and one PR for `ungetc`) to help pinpoint the issue.

https://github.com/llvm/llvm-project/pull/175530