[libc-commits] [libc] [libc] Fix warnings for the GPU test suite (PR #181763)
Joseph Huber via libc-commits
libc-commits at lists.llvm.org
Mon Feb 16 17:05:50 PST 2026
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/181763
Summary:
A lot of fixes mostly around unused variables.
>From eff336b26cb5243628c2197f8e208983bf26d65c Mon Sep 17 00:00:00 2001
From: Joseph Huber <huberjn at outlook.com>
Date: Mon, 16 Feb 2026 19:04:40 -0600
Subject: [PATCH] [libc] Fix warnings for the GPU test suite
Summary:
A lot of fixes mostly around unused variables.
---
libc/test/UnitTest/FEnvSafeTest.cpp | 3 ++-
libc/test/integration/src/__support/GPU/fixedstack_test.cpp | 2 +-
libc/test/integration/src/__support/GPU/match.cpp | 2 +-
libc/test/integration/src/__support/GPU/scan_reduce.cpp | 2 +-
libc/test/integration/src/__support/GPU/shuffle.cpp | 4 ++--
libc/test/integration/src/stdio/gpu/printf_test.cpp | 2 +-
libc/test/integration/src/stdlib/gpu/malloc_stress.cpp | 4 ++--
libc/test/integration/startup/gpu/init_fini_array_test.cpp | 2 +-
libc/test/integration/startup/gpu/rpc_interface_test.cpp | 2 +-
libc/test/integration/startup/gpu/rpc_test.cpp | 2 +-
libc/test/src/stdio/fopen_test.cpp | 4 ++--
libc/test/src/stdlib/strtof_test.cpp | 3 ++-
libc/test/src/stdlib/strtold_test.cpp | 2 +-
libc/test/src/time/mktime_test.cpp | 3 ++-
14 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/libc/test/UnitTest/FEnvSafeTest.cpp b/libc/test/UnitTest/FEnvSafeTest.cpp
index 73cf6a856c776..0747b6224cf87 100644
--- a/libc/test/UnitTest/FEnvSafeTest.cpp
+++ b/libc/test/UnitTest/FEnvSafeTest.cpp
@@ -115,7 +115,8 @@ void FEnvSafeTest::expect_fenv_eq(const fenv_t &before_fenv,
#else
// No arch-specific `fenv_t` support, so nothing to compare.
-
+ (void)before_fenv;
+ (void)after_fenv;
#endif
}
diff --git a/libc/test/integration/src/__support/GPU/fixedstack_test.cpp b/libc/test/integration/src/__support/GPU/fixedstack_test.cpp
index fde51df325ab8..40d713c64b1d1 100644
--- a/libc/test/integration/src/__support/GPU/fixedstack_test.cpp
+++ b/libc/test/integration/src/__support/GPU/fixedstack_test.cpp
@@ -37,7 +37,7 @@ void run() {
;
}
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
run();
return 0;
diff --git a/libc/test/integration/src/__support/GPU/match.cpp b/libc/test/integration/src/__support/GPU/match.cpp
index 70c22b7f3a91b..fe6751b2dcda9 100644
--- a/libc/test/integration/src/__support/GPU/match.cpp
+++ b/libc/test/integration/src/__support/GPU/match.cpp
@@ -30,7 +30,7 @@ static void test_match() {
#endif
}
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
if (gpu::get_thread_id() >= gpu::get_lane_size())
return 0;
diff --git a/libc/test/integration/src/__support/GPU/scan_reduce.cpp b/libc/test/integration/src/__support/GPU/scan_reduce.cpp
index 1d50e1f99bf31..3861a612c587a 100644
--- a/libc/test/integration/src/__support/GPU/scan_reduce.cpp
+++ b/libc/test/integration/src/__support/GPU/scan_reduce.cpp
@@ -97,7 +97,7 @@ static void test_scan_divergent() {
}
}
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
if (gpu::get_thread_id() >= gpu::get_lane_size())
return 0;
diff --git a/libc/test/integration/src/__support/GPU/shuffle.cpp b/libc/test/integration/src/__support/GPU/shuffle.cpp
index c346a2eb3f0c2..01a2d04643ec0 100644
--- a/libc/test/integration/src/__support/GPU/shuffle.cpp
+++ b/libc/test/integration/src/__support/GPU/shuffle.cpp
@@ -16,14 +16,14 @@ using namespace LIBC_NAMESPACE;
// Each iteration reduces the width, so it will broadcast to a subset we check.
static void test_shuffle() {
uint64_t mask = gpu::get_lane_mask();
- EXPECT_EQ(cpp::popcount(mask), gpu::get_lane_size());
+ EXPECT_EQ(static_cast<uint32_t>(cpp::popcount(mask)), gpu::get_lane_size());
uint32_t x = gpu::get_lane_id();
for (uint32_t width = gpu::get_lane_size(); width > 0; width /= 2)
EXPECT_EQ(gpu::shuffle(mask, 0, x, width), (x / width) * width);
}
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
if (gpu::get_thread_id() >= gpu::get_lane_size())
return 0;
diff --git a/libc/test/integration/src/stdio/gpu/printf_test.cpp b/libc/test/integration/src/stdio/gpu/printf_test.cpp
index 5f78737a2aca2..e787d80ce39c6 100644
--- a/libc/test/integration/src/stdio/gpu/printf_test.cpp
+++ b/libc/test/integration/src/stdio/gpu/printf_test.cpp
@@ -16,7 +16,7 @@ using namespace LIBC_NAMESPACE;
FILE *file = LIBC_NAMESPACE::fopen("testdata/test_data.txt", "w");
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
ASSERT_TRUE(file && "failed to open file");
// Check basic printing.
int written = 0;
diff --git a/libc/test/integration/src/stdlib/gpu/malloc_stress.cpp b/libc/test/integration/src/stdlib/gpu/malloc_stress.cpp
index 4c540a8a57cab..dc68fd0b7fa48 100644
--- a/libc/test/integration/src/stdlib/gpu/malloc_stress.cpp
+++ b/libc/test/integration/src/stdlib/gpu/malloc_stress.cpp
@@ -30,11 +30,11 @@ static inline uint32_t xorshift32(uint32_t &state) {
static inline void use(uint8_t *ptr, uint32_t size) {
EXPECT_NE(ptr, nullptr);
- for (int i = 0; i < size; ++i)
+ for (uint32_t i = 0; i < size; ++i)
ptr[i] = uint8_t(i + gpu::get_thread_id());
// Try to detect if some other thread manages to clobber our memory.
- for (int i = 0; i < size; ++i)
+ for (uint32_t i = 0; i < size; ++i)
EXPECT_EQ(ptr[i], uint8_t(i + gpu::get_thread_id()));
}
diff --git a/libc/test/integration/startup/gpu/init_fini_array_test.cpp b/libc/test/integration/startup/gpu/init_fini_array_test.cpp
index ceedd5fc81358..31af074063c84 100644
--- a/libc/test/integration/startup/gpu/init_fini_array_test.cpp
+++ b/libc/test/integration/startup/gpu/init_fini_array_test.cpp
@@ -53,7 +53,7 @@ __attribute__((destructor(101))) void reset_initval() {
initval = 0;
}
-TEST_MAIN(int argc, char **argv, char **env) {
+TEST_MAIN(int, char **, char **) {
ASSERT_EQ(global.get(GLOBAL_INDEX), INITVAL_INITIALIZER);
ASSERT_EQ(initval, INITVAL_INITIALIZER);
return 0;
diff --git a/libc/test/integration/startup/gpu/rpc_interface_test.cpp b/libc/test/integration/startup/gpu/rpc_interface_test.cpp
index 0b7ff549fe39a..05b58d1f937c5 100644
--- a/libc/test/integration/startup/gpu/rpc_interface_test.cpp
+++ b/libc/test/integration/startup/gpu/rpc_interface_test.cpp
@@ -57,7 +57,7 @@ static void test_interface(bool end_with_send) {
ASSERT_TRUE(cnt == 9 && "Invalid number of increments");
}
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
test_interface(true);
test_interface(false);
diff --git a/libc/test/integration/startup/gpu/rpc_test.cpp b/libc/test/integration/startup/gpu/rpc_test.cpp
index 018745a9e29cd..1069353f3a9c0 100644
--- a/libc/test/integration/startup/gpu/rpc_test.cpp
+++ b/libc/test/integration/startup/gpu/rpc_test.cpp
@@ -39,7 +39,7 @@ static void test_noop(uint8_t data) {
});
}
-TEST_MAIN(int argc, char **argv, char **envp) {
+TEST_MAIN(int, char **, char **) {
test_add_simple();
if (gpu::get_thread_id() % 2)
diff --git a/libc/test/src/stdio/fopen_test.cpp b/libc/test/src/stdio/fopen_test.cpp
index 3f651f755e7f3..60852ddf09388 100644
--- a/libc/test/src/stdio/fopen_test.cpp
+++ b/libc/test/src/stdio/fopen_test.cpp
@@ -15,7 +15,7 @@
#include "test/UnitTest/Test.h"
TEST(LlvmLibcFOpenTest, PrintToFile) {
- int result;
+ size_t result;
FILE *file =
LIBC_NAMESPACE::fopen(APPEND_LIBC_TEST("testdata/test.txt"), "w");
@@ -23,7 +23,7 @@ TEST(LlvmLibcFOpenTest, PrintToFile) {
static constexpr char STRING[] = "A simple string written to a file\n";
result = LIBC_NAMESPACE::fwrite(STRING, 1, sizeof(STRING) - 1, file);
- EXPECT_GE(result, 0);
+ EXPECT_GE(result, size_t(0));
ASSERT_EQ(0, LIBC_NAMESPACE::fclose(file));
diff --git a/libc/test/src/stdlib/strtof_test.cpp b/libc/test/src/stdlib/strtof_test.cpp
index 6df1ddda93bfa..1cd2b165ea91d 100644
--- a/libc/test/src/stdlib/strtof_test.cpp
+++ b/libc/test/src/stdlib/strtof_test.cpp
@@ -23,7 +23,8 @@ class LlvmLibcStrToFTest : public LIBC_NAMESPACE::testing::ErrnoCheckingTest,
ForceRoundingModeTest<RoundingMode::Nearest> {
public:
void run_test(const char *inputString, const ptrdiff_t expectedStrLen,
- const uint32_t expectedRawData, const int expectedErrno = 0) {
+ const uint32_t expectedRawData,
+ [[maybe_unused]] const int expectedErrno = 0) {
// expectedRawData is the expected float result as a uint32_t, organized
// according to IEEE754:
//
diff --git a/libc/test/src/stdlib/strtold_test.cpp b/libc/test/src/stdlib/strtold_test.cpp
index eb4056dc7ba64..79fe682e81a66 100644
--- a/libc/test/src/stdlib/strtold_test.cpp
+++ b/libc/test/src/stdlib/strtold_test.cpp
@@ -78,7 +78,7 @@ class LlvmLibcStrToLDTest : public LIBC_NAMESPACE::testing::ErrnoCheckingTest {
using FPBits = LIBC_NAMESPACE::fputil::FPBits<long double>;
FPBits expected_fp =
FPBits(static_cast<FPBits::StorageType>(expectedRawData));
- const int expected_errno = expectedErrno;
+ [[maybe_unused]] const int expected_errno = expectedErrno;
long double result = LIBC_NAMESPACE::strtold(inputString, &str_end);
diff --git a/libc/test/src/time/mktime_test.cpp b/libc/test/src/time/mktime_test.cpp
index 4942ca88f9611..eb41490fde745 100644
--- a/libc/test/src/time/mktime_test.cpp
+++ b/libc/test/src/time/mktime_test.cpp
@@ -36,7 +36,8 @@ TEST(LlvmLibcMkTime, FailureSetsErrno) {
.tm_wday = 0,
.tm_yday = 0,
.tm_isdst = 0};
- EXPECT_THAT(LIBC_NAMESPACE::mktime(&tm_data), Fails(EOVERFLOW));
+ EXPECT_THAT(static_cast<int>(LIBC_NAMESPACE::mktime(&tm_data)),
+ Fails(EOVERFLOW));
}
TEST(LlvmLibcMkTime, InvalidSeconds) {
More information about the libc-commits
mailing list