[libc-commits] [libc] [libc][stdfix] Implement sqrtfx for remaining fixed point types (PR #214741)

via libc-commits libc-commits at lists.llvm.org
Tue Aug 25 11:52:44 PDT 2026


================
@@ -131,8 +132,25 @@ template <> struct SqrtConfig<unsigned int> {
   using HalfType = unsigned short;
 };
 
-// TODO: unsigned long accum type is 64-bit, and will need 64-bit fract type.
-// Probably we will use DyadicFloat<64> for intermediate computations instead.
+template <typename T> struct FXUnsigned;
----------------
PiJoules wrote:

nit: Should we also have a templated `enable_if` that just has

```
using Type = T;
```

if `T` is fixed point and unsigned anyway? I suppose if this is conditional on the sole `FXUnsigned` usage below then this might not be needed anyway if we end up only accepting unsigned params.

https://github.com/llvm/llvm-project/pull/214741


More information about the libc-commits mailing list