[libc-commits] [libc] [libc][stdfix] Implement fixed point fxdivi functions in llvm-libc (PR #210020)

[via libc-commits]

sohail103 wrote:

> Thanks for the fixes, and the exact-divide path is a better fix than what I suggested: lkdivi from 43 ulp to 0, ulkdivi from 22 ulp to 0, lrdivi/ulrdivi from 1 ulp to 0.
> 
> I'll just request you wait for @lntue's review before landing this.
> 
> I also had an agent reviewing this PR too and it only had one note (not a change request), I'll copy it here verbatim:
> 
> > One note rather than a request: the new guard is under if constexpr (INTEGRAL_LEN > 0), so it is skipped for the _Fract types, which now also take the exact-divide branch. I checked that combination separately and saturation still holds there — the existing res > max_val check covers it, because WideFXType really is wider for those. Just worth knowing the two paths are relying on different guards.

Thanks for verifying, will wait for Tue's review.

https://github.com/llvm/llvm-project/pull/210020