[libc-commits] [libc] [llvm] [libc] Make classification functions use the emulated float128 type (PR #217134)
via libc-commits
libc-commits at lists.llvm.org
Fri Aug 21 03:27:00 PDT 2026
https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/217134
>From a57ad384ed45714a9dec966c76abb73da1877235 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Wed, 19 Aug 2026 02:34:08 +0530
Subject: [PATCH 1/5] iscanonicalf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 2 +-
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
libc/shared/math/iscanonicalf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/iscanonicalf128.h | 13 +++++--------
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/iscanonicalf128.cpp | 5 ++++-
libc/src/math/iscanonicalf128.h | 5 +++++
libc/test/shared/shared_math_constexpr_test.cpp | 2 +-
libc/test/shared/shared_math_test.cpp | 2 +-
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/iscanonicalf128_test.cpp | 5 +++++
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++-
.../libc/test/src/math/smoke/BUILD.bazel | 8 ++++++++
25 files changed, 48 insertions(+), 27 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 982e66c136598..452c0ac1914a1 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -478,6 +478,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -775,7 +776,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 2274654b15c93..9bbb5ed53fd0e 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -490,6 +490,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -786,7 +787,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 3f4ebe87c9062..ae53e35f02363 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -486,6 +486,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -783,7 +784,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 4ff3aaf377486..2f446779b01af 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -297,6 +297,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -595,7 +596,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index b616ba0d6e002..94ca312678f6e 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -173,6 +173,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.ilogb
#libc.src.math.ilogbf
#libc.src.math.ilogbl
+ #libc.src.math.iscanonicalf128
#libc.src.math.llrint
#libc.src.math.llrintf
#libc.src.math.llrintf128
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index 3ae2a2e467c9d..b7a3311ff5b06 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -217,6 +217,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogb
libc.src.math.ilogbf
libc.src.math.ilogbl
+ libc.src.math.iscanonicalf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
@@ -534,7 +535,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 792dd363544af..356f27a6c29d3 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -423,6 +423,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogb
libc.src.math.ilogbf
libc.src.math.ilogbl
+ libc.src.math.iscanonicalf128
libc.src.math.isnan
libc.src.math.isnanf
libc.src.math.isnanl
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index c12292d43c5d8..f92ca30019788 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -420,6 +420,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogb
libc.src.math.ilogbf
libc.src.math.ilogbl
+ libc.src.math.iscanonicalf128
libc.src.math.isnan
libc.src.math.isnanf
libc.src.math.isnanl
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 7a5e8930636be..fb083f269cd4b 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -638,6 +638,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -929,7 +930,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 652187d1ba4e3..a5ad291a5cc87 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -459,6 +459,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogb
libc.src.math.ilogbf
libc.src.math.ilogbl
+ libc.src.math.iscanonicalf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 71fcd346599ef..a34532be8168d 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -706,6 +706,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -1014,7 +1015,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 445220c40e19d..8f8c34732090c 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -716,6 +716,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonical
libc.src.math.iscanonicalf
+ libc.src.math.iscanonicalf128
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
@@ -1024,7 +1025,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.iscanonicalf128
libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 7c46f2b42c3d5..9a351599b213d 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -250,6 +250,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogb
libc.src.math.ilogbf
libc.src.math.ilogbl
+ libc.src.math.iscanonicalf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/shared/math/iscanonicalf128.h b/libc/shared/math/iscanonicalf128.h
index d8a6450243ec8..fa2a3ccf2acff 100644
--- a/libc/shared/math/iscanonicalf128.h
+++ b/libc/shared/math/iscanonicalf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_ISCANONICALF128_H
#define LLVM_LIBC_SHARED_MATH_ISCANONICALF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/iscanonicalf128.h"
@@ -24,6 +20,4 @@ using math::iscanonicalf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_ISCANONICALF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 3a3a78313a2d0..99220343d42aa 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1683,7 +1683,7 @@ add_header_library(
HDRS
iscanonicalf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/iscanonicalf128.h b/libc/src/__support/math/iscanonicalf128.h
index b711b3bc55d95..d517038ec6d70 100644
--- a/libc/src/__support/math/iscanonicalf128.h
+++ b/libc/src/__support/math/iscanonicalf128.h
@@ -9,24 +9,21 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ISCANONICALF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_ISCANONICALF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr int iscanonicalf128(float128 x) {
- float128 temp{};
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr int iscanonicalf128(Float128 x) {
+ Float128 temp{};
return fputil::canonicalize(temp, x) == 0;
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ISCANONICALF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 3408f25dd8555..c2bf152926ef2 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -101,6 +101,7 @@ add_entrypoint_object(
HDRS
../iscanonicalf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.iscanonicalf128
)
diff --git a/libc/src/math/generic/iscanonicalf128.cpp b/libc/src/math/generic/iscanonicalf128.cpp
index d2bb749b7b461..8bfeba078346e 100644
--- a/libc/src/math/generic/iscanonicalf128.cpp
+++ b/libc/src/math/generic/iscanonicalf128.cpp
@@ -7,12 +7,15 @@
//===----------------------------------------------------------------------===//
#include "src/math/iscanonicalf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/iscanonicalf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(int, iscanonicalf128, (float128 x)) {
- return math::iscanonicalf128(x);
+ return math::iscanonicalf128(cpp::bit_cast<Float128>(x));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/iscanonicalf128.h b/libc/src/math/iscanonicalf128.h
index 9ba021c86ec14..7974ac7c8fb33 100644
--- a/libc/src/math/iscanonicalf128.h
+++ b/libc/src/math/iscanonicalf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_ISCANONICALF128_H
#define LLVM_LIBC_SRC_MATH_ISCANONICALF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
int iscanonicalf128(float128 x);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 80e8845859c8d..a980c07187219 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,7 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
static_assert(Float128(0.0) ==
@@ -502,7 +503,6 @@ static_assert(0.0f ==
static_assert(float128(0.0) ==
LIBC_NAMESPACE::shared::nextafterf128(float128(0.0),
float128(0.0)));
-static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(float128(0.0)));
static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(float128(0.0)));
static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(float128(0.0)));
static_assert(1 == [] {
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index bfca2578ddda2..abec1ab386c36 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,6 +584,7 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0)));
@@ -752,7 +753,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
LIBC_NAMESPACE::shared::fsubf128(float128(0.0), float128(0.0)));
EXPECT_FP_EQ(0x0p+0f,
LIBC_NAMESPACE::shared::fmulf128(float128(0.0), float128(0.0)));
- EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(float128(0.0)));
EXPECT_TRUE(FPBits(LIBC_NAMESPACE::shared::nanf128("")).is_nan());
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 9a43e2271ec38..7959909f897fd 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -528,6 +528,7 @@ add_fp_unittest(
HDRS
IsCanonicalTest.h
DEPENDS
+ libc.src.__support.FPUtil.float128
libc.src.math.iscanonicalf128
)
diff --git a/libc/test/src/math/smoke/iscanonicalf128_test.cpp b/libc/test/src/math/smoke/iscanonicalf128_test.cpp
index 0176ae2f223da..f4320791e11ff 100644
--- a/libc/test/src/math/smoke/iscanonicalf128_test.cpp
+++ b/libc/test/src/math/smoke/iscanonicalf128_test.cpp
@@ -7,7 +7,12 @@
//===----------------------------------------------------------------------===//
#include "IsCanonicalTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/iscanonicalf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_ISCANONICAL_TESTS(float128, LIBC_NAMESPACE::iscanonicalf128)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index e76ee60d70d4e..5af22ef957183 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -6196,8 +6196,8 @@ libc_support_library(
hdrs = ["src/__support/math/iscanonicalf128.h"],
deps = [
":__support_fputil_basic_operations",
+ ":__support_fputil_float128",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -10932,6 +10932,8 @@ libc_math_function(
libc_math_function(
name = "iscanonicalf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_iscanonicalf128",
],
)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index cf75a206a0598..72eab06e51664 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -87,6 +87,14 @@ math_test(
hdrs = ["IsCanonicalTest.h"],
)
+math_test(
+ name = "iscanonicalf128",
+ hdrs = ["IsCanonicalTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
+)
+
math_test(name = "cbrt")
math_test(name = "cbrtf")
>From c796accdda6fbce1b4b24741934b3447a8879be8 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Wed, 19 Aug 2026 02:35:52 +0530
Subject: [PATCH 2/5] isnanf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 1 +
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
libc/shared/math/isnanf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/isnanf128.h | 13 +++++--------
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/isnanf128.cpp | 7 ++++++-
libc/src/math/isnanf128.h | 5 +++++
libc/test/shared/shared_math_constexpr_test.cpp | 2 +-
libc/test/shared/shared_math_test.cpp | 2 +-
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/isnanf128_test.cpp | 5 +++++
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++-
.../libc/test/src/math/smoke/BUILD.bazel | 3 +++
25 files changed, 45 insertions(+), 26 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 452c0ac1914a1..4d285a4de2ff8 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -482,6 +482,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -776,7 +777,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 9bbb5ed53fd0e..f153f79d76691 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -494,6 +494,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -787,7 +788,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index ae53e35f02363..ad415bf43547d 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -490,6 +490,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -784,7 +785,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 2f446779b01af..c9cb14139b3d5 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -301,6 +301,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -596,7 +597,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 94ca312678f6e..8ae4bcec1c6e9 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -174,6 +174,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.ilogbf
#libc.src.math.ilogbl
#libc.src.math.iscanonicalf128
+ #libc.src.math.isnanf128
#libc.src.math.llrint
#libc.src.math.llrintf
#libc.src.math.llrintf128
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index b7a3311ff5b06..4f43dd87f25e7 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -218,6 +218,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbf
libc.src.math.ilogbl
libc.src.math.iscanonicalf128
+ libc.src.math.isnanf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 356f27a6c29d3..013314cdbf93f 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -426,6 +426,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicalf128
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.ldexp
libc.src.math.ldexpf
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index f92ca30019788..ddf3f321aa6b8 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -423,6 +423,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicalf128
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.ldexp
libc.src.math.ldexpf
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index fb083f269cd4b..1ffe9ebcd3593 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -642,6 +642,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -930,7 +931,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index a5ad291a5cc87..7f99eb7810e84 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -460,6 +460,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbf
libc.src.math.ilogbl
libc.src.math.iscanonicalf128
+ libc.src.math.isnanf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index a34532be8168d..b656c8720497c 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -710,6 +710,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -1015,7 +1016,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 8f8c34732090c..cf2691a6b9189 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -720,6 +720,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.iscanonicall
libc.src.math.isnan
libc.src.math.isnanf
+ libc.src.math.isnanf128
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
@@ -1025,7 +1026,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.isnanf128
libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 9a351599b213d..ad37e7e2cdb1e 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -251,6 +251,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbf
libc.src.math.ilogbl
libc.src.math.iscanonicalf128
+ libc.src.math.isnanf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/shared/math/isnanf128.h b/libc/shared/math/isnanf128.h
index a84e26a640f23..c5d812bb5a70e 100644
--- a/libc/shared/math/isnanf128.h
+++ b/libc/shared/math/isnanf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_ISNANF128_H
#define LLVM_LIBC_SHARED_MATH_ISNANF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/isnanf128.h"
@@ -24,6 +20,4 @@ using math::isnanf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_ISNANF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 99220343d42aa..a536857422f6e 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1730,7 +1730,7 @@ add_header_library(
HDRS
isnanf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.fp_bits
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/isnanf128.h b/libc/src/__support/math/isnanf128.h
index ff9d31f34d8fe..422b8c453a6da 100644
--- a/libc/src/__support/math/isnanf128.h
+++ b/libc/src/__support/math/isnanf128.h
@@ -9,23 +9,20 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ISNANF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_ISNANF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/FPBits.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE LIBC_CONSTEXPR int isnanf128(float128 x) {
- return fputil::FPBits<float128>(x).is_nan();
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE LIBC_CONSTEXPR int isnanf128(Float128 x) {
+ return fputil::FPBits<Float128>(x).is_nan();
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ISNANF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index c2bf152926ef2..b282abce27b66 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -3086,6 +3086,7 @@ add_entrypoint_object(
HDRS
../isnanf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.isnanf128
)
diff --git a/libc/src/math/generic/isnanf128.cpp b/libc/src/math/generic/isnanf128.cpp
index 919136fe3e4fb..2c06506dbeebb 100644
--- a/libc/src/math/generic/isnanf128.cpp
+++ b/libc/src/math/generic/isnanf128.cpp
@@ -7,10 +7,15 @@
//===----------------------------------------------------------------------===//
#include "src/math/isnanf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/isnanf128.h"
namespace LIBC_NAMESPACE_DECL {
-LLVM_LIBC_FUNCTION(int, isnanf128, (float128 x)) { return math::isnanf128(x); }
+using LIBC_NAMESPACE::fputil::Float128;
+
+LLVM_LIBC_FUNCTION(int, isnanf128, (float128 x)) {
+ return math::isnanf128(cpp::bit_cast<Float128>(x));
+}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/isnanf128.h b/libc/src/math/isnanf128.h
index 968e858519421..cb776be5e0481 100644
--- a/libc/src/math/isnanf128.h
+++ b/libc/src/math/isnanf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_ISNANF128_H
#define LLVM_LIBC_SRC_MATH_ISNANF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
int isnanf128(float128 x);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index a980c07187219..654130afcd7fe 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,7 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
@@ -503,7 +504,6 @@ static_assert(0.0f ==
static_assert(float128(0.0) ==
LIBC_NAMESPACE::shared::nextafterf128(float128(0.0),
float128(0.0)));
-static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(float128(0.0)));
static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(float128(0.0)));
static_assert(1 == [] {
const char arg{};
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index abec1ab386c36..269cfa41c9220 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,6 +584,7 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0),
@@ -753,7 +754,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
LIBC_NAMESPACE::shared::fsubf128(float128(0.0), float128(0.0)));
EXPECT_FP_EQ(0x0p+0f,
LIBC_NAMESPACE::shared::fmulf128(float128(0.0), float128(0.0)));
- EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(float128(0.0)));
EXPECT_TRUE(FPBits(LIBC_NAMESPACE::shared::nanf128("")).is_nan());
}
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 7959909f897fd..4baef32e90ddc 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -554,6 +554,7 @@ add_fp_unittest(
HDRS
IsNanTest.h
DEPENDS
+ libc.src.__support.FPUtil.float128
libc.src.math.isnanf128
)
diff --git a/libc/test/src/math/smoke/isnanf128_test.cpp b/libc/test/src/math/smoke/isnanf128_test.cpp
index 061370adce558..ada4fd28fd483 100644
--- a/libc/test/src/math/smoke/isnanf128_test.cpp
+++ b/libc/test/src/math/smoke/isnanf128_test.cpp
@@ -7,7 +7,12 @@
//===----------------------------------------------------------------------===//
#include "IsNanTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/isnanf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_ISNAN_TESTS(float128, LIBC_NAMESPACE::isnanf128)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 5af22ef957183..f04fa5e186cfd 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -6242,9 +6242,9 @@ libc_support_library(
name = "__support_math_isnanf128",
hdrs = ["src/__support/math/isnanf128.h"],
deps = [
+ ":__support_fputil_float128",
":__support_fputil_fp_bits",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -10962,6 +10962,8 @@ libc_math_function(
libc_math_function(
name = "isnanf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_isnanf128",
],
)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index 72eab06e51664..b6d3285fd790a 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -1031,6 +1031,9 @@ math_test(
math_test(
name = "isnanf128",
hdrs = ["IsNanTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
)
math_test(
>From 90ff6155de456d656cdc6ebabb5a5487d455e275 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Wed, 19 Aug 2026 02:38:51 +0530
Subject: [PATCH 3/5] issignallingf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 2 +-
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
libc/shared/math/issignalingf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/issignalingf128.h | 11 ++++-------
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/issignalingf128.cpp | 5 ++++-
libc/src/math/issignalingf128.h | 5 +++++
libc/test/shared/shared_math_constexpr_test.cpp | 2 +-
libc/test/shared/shared_math_test.cpp | 2 +-
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/issignalingf128_test.cpp | 5 +++++
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++-
24 files changed, 39 insertions(+), 26 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 4d285a4de2ff8..c9cad49711b88 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -486,6 +486,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -777,7 +778,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index f153f79d76691..a5005fd21bbe7 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -498,6 +498,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -788,7 +789,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index ad415bf43547d..f9f19a9c7b795 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -494,6 +494,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -785,7 +786,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index c9cb14139b3d5..7d7c35926fef3 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -305,6 +305,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -597,7 +598,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 8ae4bcec1c6e9..7827471b7b309 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -175,6 +175,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.ilogbl
#libc.src.math.iscanonicalf128
#libc.src.math.isnanf128
+ #libc.src.math.issignalingf128
#libc.src.math.llrint
#libc.src.math.llrintf
#libc.src.math.llrintf128
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index 4f43dd87f25e7..251ba60779514 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -219,6 +219,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonicalf128
libc.src.math.isnanf128
+ libc.src.math.issignalingf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
@@ -536,7 +537,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 013314cdbf93f..59e3e2a5e95b3 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -428,6 +428,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanf
libc.src.math.isnanf128
libc.src.math.isnanl
+ libc.src.math.issignalingf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index ddf3f321aa6b8..57e35bdabb7b0 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -425,6 +425,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanf
libc.src.math.isnanf128
libc.src.math.isnanl
+ libc.src.math.issignalingf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 1ffe9ebcd3593..468b00efad35e 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -646,6 +646,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -931,7 +932,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 7f99eb7810e84..15d475835b2e8 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -461,6 +461,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonicalf128
libc.src.math.isnanf128
+ libc.src.math.issignalingf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index b656c8720497c..ca6a3d872c71d 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -714,6 +714,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -1016,7 +1017,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index cf2691a6b9189..9f7da5e10b66c 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -724,6 +724,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.isnanl
libc.src.math.issignaling
libc.src.math.issignalingf
+ libc.src.math.issignalingf128
libc.src.math.issignalingl
libc.src.math.ldexp
libc.src.math.ldexpf
@@ -1026,7 +1027,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.fsubf128
libc.src.math.getpayloadf128
libc.src.math.ilogbf128
- libc.src.math.issignalingf128
libc.src.math.ldexpf128
libc.src.math.llogbf128
libc.src.math.logbf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index ad37e7e2cdb1e..075a691fbff43 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -252,6 +252,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.ilogbl
libc.src.math.iscanonicalf128
libc.src.math.isnanf128
+ libc.src.math.issignalingf128
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
diff --git a/libc/shared/math/issignalingf128.h b/libc/shared/math/issignalingf128.h
index 2c7acc3195cb9..cddc1e0d39529 100644
--- a/libc/shared/math/issignalingf128.h
+++ b/libc/shared/math/issignalingf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_ISSIGNALINGF128_H
#define LLVM_LIBC_SHARED_MATH_ISSIGNALINGF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/issignalingf128.h"
@@ -24,6 +20,4 @@ using math::issignalingf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_ISSIGNALINGF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index a536857422f6e..4f5889fd5ba4b 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1787,7 +1787,7 @@ add_header_library(
HDRS
issignalingf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/issignalingf128.h b/libc/src/__support/math/issignalingf128.h
index ae1ced6b8dabe..62949159c33b0 100644
--- a/libc/src/__support/math/issignalingf128.h
+++ b/libc/src/__support/math/issignalingf128.h
@@ -9,23 +9,20 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ISSIGNALINGF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_ISSIGNALINGF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr int issignalingf128(float128 x) {
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr int issignalingf128(Float128 x) {
return fputil::issignaling_impl(x);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ISSIGNALINGF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index b282abce27b66..e80741e20d397 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -3046,6 +3046,7 @@ add_entrypoint_object(
HDRS
../issignalingf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.issignalingf128
)
diff --git a/libc/src/math/generic/issignalingf128.cpp b/libc/src/math/generic/issignalingf128.cpp
index 3a42b9f1bc406..8edf5806da75a 100644
--- a/libc/src/math/generic/issignalingf128.cpp
+++ b/libc/src/math/generic/issignalingf128.cpp
@@ -7,12 +7,15 @@
//===----------------------------------------------------------------------===//
#include "src/math/issignalingf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/issignalingf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(int, issignalingf128, (float128 x)) {
- return math::issignalingf128(x);
+ return math::issignalingf128(cpp::bit_cast<Float128>(x));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/issignalingf128.h b/libc/src/math/issignalingf128.h
index 7d1bfdec646de..9232284e263fc 100644
--- a/libc/src/math/issignalingf128.h
+++ b/libc/src/math/issignalingf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_ISSIGNALINGF128_H
#define LLVM_LIBC_SRC_MATH_ISSIGNALINGF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
int issignalingf128(float128 x);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 654130afcd7fe..41a49a6513f52 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,7 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
static_assert(Float128(0.0) ==
@@ -504,7 +505,6 @@ static_assert(0.0f ==
static_assert(float128(0.0) ==
LIBC_NAMESPACE::shared::nextafterf128(float128(0.0),
float128(0.0)));
-static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(float128(0.0)));
static_assert(1 == [] {
const char arg{};
return LIBC_NAMESPACE::fputil::FPBits<float128>(
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 269cfa41c9220..9e74ccf470cb3 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,6 +584,7 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
@@ -754,7 +755,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
LIBC_NAMESPACE::shared::fsubf128(float128(0.0), float128(0.0)));
EXPECT_FP_EQ(0x0p+0f,
LIBC_NAMESPACE::shared::fmulf128(float128(0.0), float128(0.0)));
- EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(float128(0.0)));
EXPECT_TRUE(FPBits(LIBC_NAMESPACE::shared::nanf128("")).is_nan());
}
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 4baef32e90ddc..97b4d927a0804 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -2176,6 +2176,7 @@ add_fp_unittest(
HDRS
IsSignalingTest.h
DEPENDS
+ libc.src.__support.FPUtil.float128
libc.src.math.issignalingf128
)
diff --git a/libc/test/src/math/smoke/issignalingf128_test.cpp b/libc/test/src/math/smoke/issignalingf128_test.cpp
index 929e32a8facdd..ddd9a8af2fdaf 100644
--- a/libc/test/src/math/smoke/issignalingf128_test.cpp
+++ b/libc/test/src/math/smoke/issignalingf128_test.cpp
@@ -7,7 +7,12 @@
//===----------------------------------------------------------------------===//
#include "IsSignalingTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/issignalingf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_ISSIGNALING_TESTS(float128, LIBC_NAMESPACE::issignalingf128)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index f04fa5e186cfd..1358df81b86d9 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -6300,8 +6300,8 @@ libc_support_library(
hdrs = ["src/__support/math/issignalingf128.h"],
deps = [
":__support_fputil_basic_operations",
+ ":__support_fputil_float128",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -11013,6 +11013,8 @@ libc_math_function(
libc_math_function(
name = "issignalingf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_issignalingf128",
],
)
>From 395f745761eaa90494369b67eafd0baae998d0dc Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Wed, 19 Aug 2026 02:50:32 +0530
Subject: [PATCH 4/5] nit
---
.../libc/test/src/math/smoke/BUILD.bazel | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index b6d3285fd790a..f84e7ec8cb990 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -1775,6 +1775,14 @@ math_test(
hdrs = ["IsSignalingTest.h"],
)
+math_test(
+ name = "issignalingf128",
+ hdrs = ["IsSignalingTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
+)
+
math_test(name = "log10f16")
math_test(name = "log2f16")
>From 1723ec8724bc2b935cc2cf62b914c1d684fe1c4f Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Fri, 21 Aug 2026 15:56:41 +0530
Subject: [PATCH 5/5] nit
---
libc/test/shared/shared_math_constexpr_test.cpp | 6 +++---
libc/test/shared/shared_math_test.cpp | 6 +++---
libc/test/src/math/smoke/iscanonicalf128_test.cpp | 2 +-
libc/test/src/math/smoke/isnanf128_test.cpp | 2 +-
libc/test/src/math/smoke/issignalingf128_test.cpp | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 41a49a6513f52..c04f1a361395a 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,15 +381,15 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
-static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
-static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
-static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0)));
+static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
+static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
+static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
static_assert(0LL == LIBC_NAMESPACE::shared::llrintf128(Float128(0.0)));
static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(Float128(0.0)));
static_assert(0L == LIBC_NAMESPACE::shared::lrintf128(Float128(0.0)));
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 9e74ccf470cb3..737efdb09d8c5 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,14 +584,14 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
- EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
- EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
- EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0)));
+ EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
+ EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
+ EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llrintf128(Float128(0.0)));
EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(Float128(0.0)));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lrintf128(Float128(0.0)));
diff --git a/libc/test/src/math/smoke/iscanonicalf128_test.cpp b/libc/test/src/math/smoke/iscanonicalf128_test.cpp
index f4320791e11ff..7c93315ac8560 100644
--- a/libc/test/src/math/smoke/iscanonicalf128_test.cpp
+++ b/libc/test/src/math/smoke/iscanonicalf128_test.cpp
@@ -7,8 +7,8 @@
//===----------------------------------------------------------------------===//
#include "IsCanonicalTest.h"
-#include "src/__support/FPUtil/float128.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/iscanonicalf128.h"
#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
diff --git a/libc/test/src/math/smoke/isnanf128_test.cpp b/libc/test/src/math/smoke/isnanf128_test.cpp
index ada4fd28fd483..70af9b6b71af2 100644
--- a/libc/test/src/math/smoke/isnanf128_test.cpp
+++ b/libc/test/src/math/smoke/isnanf128_test.cpp
@@ -7,8 +7,8 @@
//===----------------------------------------------------------------------===//
#include "IsNanTest.h"
-#include "src/__support/FPUtil/float128.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/isnanf128.h"
#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
diff --git a/libc/test/src/math/smoke/issignalingf128_test.cpp b/libc/test/src/math/smoke/issignalingf128_test.cpp
index ddd9a8af2fdaf..e856e2e60b33f 100644
--- a/libc/test/src/math/smoke/issignalingf128_test.cpp
+++ b/libc/test/src/math/smoke/issignalingf128_test.cpp
@@ -7,8 +7,8 @@
//===----------------------------------------------------------------------===//
#include "IsSignalingTest.h"
-#include "src/__support/FPUtil/float128.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/issignalingf128.h"
#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
More information about the libc-commits
mailing list