[libc-commits] [libc] [libc] Modify nearbyintf128 to use emulated Float128 type (PR #217025)
via libc-commits
libc-commits at lists.llvm.org
Tue Aug 18 06:11:09 PDT 2026
https://github.com/Sukumarsawant created https://github.com/llvm/llvm-project/pull/217025
None
>From 1e7032ed4dcb5007cc5bb471618979adb56ecbfc Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Tue, 18 Aug 2026 18:32:32 +0530
Subject: [PATCH] nearbyintf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 2 +-
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
libc/shared/math/nearbyintf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/nearbyintf128.h | 11 ++++-------
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/nearbyintf128.cpp | 6 +++++-
libc/src/math/nearbyintf128.h | 5 +++++
libc/test/shared/shared_math_constexpr_test.cpp | 4 ++--
libc/test/shared/shared_math_test.cpp | 4 ++--
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/nearbyintf128_test.cpp | 5 +++++
23 files changed, 39 insertions(+), 27 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 09b81be24c8d8..c84845c5ca2e5 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -519,6 +519,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -777,7 +778,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index d6cb433ba01a5..04dde76c1b3ef 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -531,6 +531,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -788,7 +789,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index b7a7b9aa7142b..d4fe511502648 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -527,6 +527,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -785,7 +786,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 9642dacf6426d..4241413af3463 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -338,6 +338,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -597,7 +598,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 9ece581ce10eb..79546eb48719c 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -200,6 +200,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.nanl
#libc.src.math.nearbyint
#libc.src.math.nearbyintf
+ #libc.src.math.nearbyintf128
#libc.src.math.nearbyintl
#libc.src.math.nextafter
#libc.src.math.nextafterf
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index bb468f0467d23..b91ea6c1390e9 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -248,6 +248,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -535,7 +536,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index e44147e9699f4..89958e5f08a8f 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -462,6 +462,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index efd4fb8fc5682..e41e9a4557ae7 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -459,6 +459,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 04dbcb4e4cf9e..64c79688fd830 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -673,6 +673,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -925,7 +926,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 83c3b65498f0c..9e1d72e0aa14d 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -493,6 +493,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 81ef813a1fa64..ccda807c6635e 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -746,6 +746,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -1015,7 +1016,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 37576491a73bb..a54ba91a36f2d 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -751,6 +751,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
@@ -1020,7 +1021,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.lroundf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.nearbyintf128
libc.src.math.nextafterf128
libc.src.math.nextdownf128
libc.src.math.nextupf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index bdc209bd330b5..a0ade576dbaed 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -281,6 +281,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nanl
libc.src.math.nearbyint
libc.src.math.nearbyintf
+ libc.src.math.nearbyintf128
libc.src.math.nearbyintl
libc.src.math.nextafter
libc.src.math.nextafterf
diff --git a/libc/shared/math/nearbyintf128.h b/libc/shared/math/nearbyintf128.h
index 142b2f0f2d9e9..00d842b913655 100644
--- a/libc/shared/math/nearbyintf128.h
+++ b/libc/shared/math/nearbyintf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_NEARBYINTF128_H
#define LLVM_LIBC_SHARED_MATH_NEARBYINTF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/nearbyintf128.h"
@@ -24,6 +20,4 @@ using math::nearbyintf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_NEARBYINTF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 613e0adf385c7..c727be9142b0b 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -2240,7 +2240,7 @@ add_header_library(
HDRS
nearbyintf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.nearest_integer_operations
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/nearbyintf128.h b/libc/src/__support/math/nearbyintf128.h
index 3f3d4bf9e419f..8eb90f9c3b09e 100644
--- a/libc/src/__support/math/nearbyintf128.h
+++ b/libc/src/__support/math/nearbyintf128.h
@@ -9,23 +9,20 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_NEARBYINTF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_NEARBYINTF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/NearestIntegerOperations.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr float128 nearbyintf128(float128 x) {
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr Float128 nearbyintf128(Float128 x) {
return fputil::round_using_current_rounding_mode(x);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_NEARBYINTF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 13c4ff8126c9f..1598c81233571 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1166,6 +1166,7 @@ add_entrypoint_object(
HDRS
../nearbyintf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.nearbyintf128
)
diff --git a/libc/src/math/generic/nearbyintf128.cpp b/libc/src/math/generic/nearbyintf128.cpp
index 9e6ef72a624e7..515fb8451f712 100644
--- a/libc/src/math/generic/nearbyintf128.cpp
+++ b/libc/src/math/generic/nearbyintf128.cpp
@@ -7,12 +7,16 @@
//===----------------------------------------------------------------------===//
#include "src/math/nearbyintf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/nearbyintf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, nearbyintf128, (float128 x)) {
- return math::nearbyintf128(x);
+ return cpp::bit_cast<float128>(
+ math::nearbyintf128(cpp::bit_cast<Float128>(x)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/nearbyintf128.h b/libc/src/math/nearbyintf128.h
index 9c4fdd5963dac..4f8e80388f56a 100644
--- a/libc/src/math/nearbyintf128.h
+++ b/libc/src/math/nearbyintf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_NEARBYINTF128_H
#define LLVM_LIBC_SRC_MATH_NEARBYINTF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 nearbyintf128(float128 x);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index df5496c7af6bf..dbfb0423364b7 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,8 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(float128(0.0) ==
+ LIBC_NAMESPACE::shared::nearbyintf128(Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
@@ -492,8 +494,6 @@ static_assert(0LL == LIBC_NAMESPACE::shared::llrintf128(float128(0.0)));
static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(float128(0.0)));
static_assert(0L == LIBC_NAMESPACE::shared::lrintf128(float128(0.0)));
static_assert(0L == LIBC_NAMESPACE::shared::lroundf128(float128(0.0)));
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::nearbyintf128(float128(0.0)));
static_assert(float128(0.0) ==
LIBC_NAMESPACE::shared::nextafterf128(float128(0.0),
float128(0.0)));
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index c507c51d8b48a..4315a6f9c2a05 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -582,6 +582,8 @@ TEST(LlvmLibcSharedMathTest, AllLongDouble) {
// Emulated float128 tests
TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_FP_EQ(float128(0.0),
+ LIBC_NAMESPACE::shared::nearbyintf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
}
@@ -745,8 +747,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(float128(0.0)));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lrintf128(float128(0.0)));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lroundf128(float128(0.0)));
- EXPECT_FP_EQ(float128(0.0),
- LIBC_NAMESPACE::shared::nearbyintf128(float128(0.0)));
EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::rintf128(float128(0.0)));
EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(float128(0.0)));
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index ba6d8764f1292..32012b4567b17 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3966,6 +3966,7 @@ add_fp_unittest(
NearbyIntTest.h
DEPENDS
libc.hdr.fenv_macros
+ libc.src.__support.FPUtil.float128
libc.src.math.nearbyintf128
)
diff --git a/libc/test/src/math/smoke/nearbyintf128_test.cpp b/libc/test/src/math/smoke/nearbyintf128_test.cpp
index 98fbb2858fafa..59a618fef7d1b 100644
--- a/libc/test/src/math/smoke/nearbyintf128_test.cpp
+++ b/libc/test/src/math/smoke/nearbyintf128_test.cpp
@@ -7,7 +7,12 @@
//===----------------------------------------------------------------------===//
#include "NearbyIntTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/nearbyintf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_NEARBYINT_TESTS(float128, LIBC_NAMESPACE::nearbyintf128)
More information about the libc-commits
mailing list