[libc-commits] [libc] [libc] Convert test framework libraries to standard target infrastructure (PR #216931)

[Pavel Labath via libc-commits]

================
@@ -918,19 +926,9 @@ function(add_libc_hermetic test_name)
       libc.startup.${LIBC_TARGET_OS}.crt1
       ${HERMETIC_TEST_LINK_LIBRARIES}
       ${fq_target_name}.__libc__
-      LibcHermeticTestSupport
-      # Working around dependency issues caused by compiler introduced libcalls.
-      # We need to repeat the libc target so that we can resolve libcalls which
-      # pull in functions from LibcHermeticTestSupport (which then foward to
-      # internal implementations).
-      # TODO: clean this up
-      ${fq_target_name}.__libc__
----------------
labath wrote:

This here. There's a cycle when a compiler introduces a memcpy call to some libc function. See also: https://github.com/llvm/llvm-project/pull/216406

https://github.com/llvm/llvm-project/pull/216931