[libc-commits] [libc] [libc][test] Condition out tests that can't work on bare metal (PR #215830)

Pavel Labath via libc-commits libc-commits at lists.llvm.org
Mon Aug 17 05:02:15 PDT 2026


https://github.com/labath approved this pull request.

That is an interesting question. I don't know the history here, but if I had to guess, I'd say that at some point in the past (when the clock check was added), we were not creating these custom SKIPPED targets, but when we later started creating them, there were no targets without clock support around.

Your code, although not very elegant, is correct. I considered skipping the `if(TARGET)` check (as querying a nonexisting property returns a false-like value), but I think that won't work because the overlay build does not even define this target. `if (signal IN_LIST TARGET_ENTRYPOINT_NAME_LIST)` should work, though I'm unclear as to whether that's preferred (i'd be okay if you wanted to switch to that). I think this is good enough to be checked in though. Sorry it took so long.

https://github.com/llvm/llvm-project/pull/215830


More information about the libc-commits mailing list