[libc-commits] [libc] [libc] Modify `atan2f128` to use emulated Float128 type (PR #216508)
via libc-commits
libc-commits at lists.llvm.org
Sun Aug 16 02:27:33 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Zorojuro (Sukumarsawant)
<details>
<summary>Changes</summary>
---
Patch is 23.00 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/216508.diff
25 Files Affected:
- (modified) libc/config/baremetal/aarch64/entrypoints.txt (+1-1)
- (modified) libc/config/baremetal/arm/entrypoints.txt (+1-1)
- (modified) libc/config/baremetal/riscv/entrypoints.txt (+1-1)
- (modified) libc/config/darwin/aarch64/entrypoints.txt (+1-1)
- (modified) libc/config/darwin/x86_64/entrypoints.txt (+1)
- (modified) libc/config/freebsd/x86_64/entrypoints.txt (+1-1)
- (modified) libc/config/gpu/amdgpu/entrypoints.txt (+1)
- (modified) libc/config/gpu/nvptx/entrypoints.txt (+1)
- (modified) libc/config/linux/aarch64/entrypoints.txt (+1-1)
- (modified) libc/config/linux/arm/entrypoints.txt (+1)
- (modified) libc/config/linux/riscv/entrypoints.txt (+1-1)
- (modified) libc/config/linux/x86_64/entrypoints.txt (+1-1)
- (modified) libc/config/windows/entrypoints.txt (+1)
- (modified) libc/shared/math/atan2f128.h (-6)
- (modified) libc/src/__support/math/CMakeLists.txt (+2)
- (modified) libc/src/__support/math/atan2f128.h (+13-13)
- (modified) libc/src/math/atan2f128.h (+5)
- (modified) libc/src/math/generic/CMakeLists.txt (+1)
- (modified) libc/src/math/generic/atan2f128.cpp (+5-1)
- (modified) libc/src/math/generic/atan2l.cpp (+2-7)
- (modified) libc/test/shared/shared_math_test.cpp (+2-2)
- (modified) libc/test/src/math/CMakeLists.txt (+1)
- (modified) libc/test/src/math/atan2f128_test.cpp (+10-7)
- (modified) libc/test/src/math/smoke/CMakeLists.txt (+2)
- (modified) libc/test/src/math/smoke/atan2f128_test.cpp (+37-13)
``````````diff
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 81958d224f70d..b107d7c765507 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -359,6 +359,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
# libc.src.math.atan2l
libc.src.math.atan
libc.src.math.atanf
@@ -731,7 +732,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.canonicalizef128
libc.src.math.copysignf128
libc.src.math.daddf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index ee3ec63132cc2..b574cd9190862 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -371,6 +371,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan2l
libc.src.math.atan
libc.src.math.atanf
@@ -742,7 +743,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.canonicalizef128
libc.src.math.copysignf128
libc.src.math.daddf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index c9f7c042bf4a8..3b250b0be6e5b 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -367,6 +367,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
# libc.src.math.atan2l
libc.src.math.atan
libc.src.math.atanf
@@ -739,7 +740,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.canonicalizef128
libc.src.math.copysignf128
libc.src.math.daddf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 0ca00419a916c..d66c509756d5c 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -179,6 +179,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan
libc.src.math.atanf
libc.src.math.atanhf
@@ -551,7 +552,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.canonicalizef128
libc.src.math.copysignf128
libc.src.math.daddf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 136d5a458d484..118d5d48ce37b 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -118,6 +118,7 @@ set(TARGET_LIBM_ENTRYPOINTS
## Currently disabled for failing tests.
# math.h entrypoints
+ #libc.src.math.atan2f128
#libc.src.math.copysign
#libc.src.math.copysignf
#libc.src.math.copysignl
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index 2223504718444..d096a542e726b 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -125,6 +125,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinhf
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atanf
libc.src.math.atanhf
libc.src.math.cbrt
@@ -489,7 +490,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
- libc.src.math.atan2f128
libc.src.math.atan2l
libc.src.math.canonicalizef128
libc.src.math.copysignf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 12783aa4e5316..25b8b3c077d4c 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -311,6 +311,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.atan
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan2l
libc.src.math.atanf
libc.src.math.atanhf
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index 5820448e06663..98274141410d4 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -307,6 +307,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.atan
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan2l
libc.src.math.atanf
libc.src.math.atanhf
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 071a7830b43d3..95de08a934471 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -517,6 +517,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan
libc.src.math.atanf
libc.src.math.atanhf
@@ -878,7 +879,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.canonicalizef128
libc.src.math.copysignf128
libc.src.math.daddf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 1adbb04bb4cbe..371afe56307a8 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -357,6 +357,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan
libc.src.math.atanf
libc.src.math.atanhf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 66dd9dd790737..458729ca769ea 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -586,6 +586,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan
libc.src.math.atanf
libc.src.math.atanhf
@@ -967,7 +968,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.atan2l
libc.src.math.canonicalizef128
libc.src.math.copysignf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 6045886c2f11c..1dc33d59150ee 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -591,6 +591,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan
libc.src.math.atanf
libc.src.math.atanhf
@@ -972,7 +973,6 @@ endif()
if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# math.h C23 _Float128 entrypoints
- libc.src.math.atan2f128
libc.src.math.atan2l
libc.src.math.canonicalizef128
libc.src.math.copysignf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 142b83e71efe6..339eff084d653 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -155,6 +155,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.asinpif
libc.src.math.atan2
libc.src.math.atan2f
+ libc.src.math.atan2f128
libc.src.math.atan
libc.src.math.atanf
libc.src.math.atanhf
diff --git a/libc/shared/math/atan2f128.h b/libc/shared/math/atan2f128.h
index 45a970c814b06..7a7fab1c37642 100644
--- a/libc/shared/math/atan2f128.h
+++ b/libc/shared/math/atan2f128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_ATAN2F128_H
#define LLVM_LIBC_SHARED_MATH_ATAN2F128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/atan2f128.h"
@@ -24,6 +20,4 @@ using math::atan2f128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_ATAN2F128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index db514db61a9df..a9983e8f447a0 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -316,8 +316,10 @@ add_header_library(
.atan_utils
libc.src.__support.integer_literals
libc.src.__support.uint128
+ libc.src.__support.FPUtil.cast
libc.src.__support.FPUtil.dyadic_float
libc.src.__support.FPUtil.fp_bits
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.multiply_add
libc.src.__support.FPUtil.nearest_integer
libc.src.__support.macros.optimization
diff --git a/libc/src/__support/math/atan2f128.h b/libc/src/__support/math/atan2f128.h
index 5907f54a540c5..0d6e518c08c2b 100644
--- a/libc/src/__support/math/atan2f128.h
+++ b/libc/src/__support/math/atan2f128.h
@@ -9,13 +9,10 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ATAN2F128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_ATAN2F128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "atan_utils.h"
#include "src/__support/FPUtil/FPBits.h"
#include "src/__support/FPUtil/dyadic_float.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/FPUtil/nearest_integer.h"
#include "src/__support/integer_literals.h"
#include "src/__support/macros/config.h"
@@ -26,6 +23,8 @@ namespace LIBC_NAMESPACE_DECL {
namespace math {
+using LIBC_NAMESPACE::fputil::Float128;
+
// There are several range reduction steps we can take for atan2(y, x) as
// follow:
@@ -81,7 +80,7 @@ namespace math {
// and relative errors bounded by:
// |(atan(u) - P(u)) / P(u)| < 2^-114.
-LIBC_INLINE float128 atan2f128(float128 y, float128 x) {
+LIBC_INLINE Float128 atan2f128(Float128 y, Float128 x) {
using DFloat128 = fputil::DyadicFloat<128>;
constexpr DFloat128 ZERO = {Sign::POS, 0, 0_u128};
@@ -106,7 +105,7 @@ LIBC_INLINE float128 atan2f128(float128 y, float128 x) {
{{MPI, PI_OVER_2}, {MPI, PI_OVER_2}}};
using namespace atan_internal;
- using FPBits = fputil::FPBits<float128>;
+ using FPBits = fputil::FPBits<Float128>;
using DFloat128 = fputil::DyadicFloat<128>;
FPBits x_bits(x), y_bits(y);
@@ -130,8 +129,8 @@ LIBC_INLINE float128 atan2f128(float128 y, float128 x) {
if (LIBC_UNLIKELY(max_exp >= 0x7fffU || min_exp == 0U)) {
if (x_bits.is_nan() || y_bits.is_nan())
return FPBits::quiet_nan().get_val();
- unsigned x_except = x == 0 ? 0 : (FPBits(x_abs).is_inf() ? 2 : 1);
- unsigned y_except = y == 0 ? 0 : (FPBits(y_abs).is_inf() ? 2 : 1);
+ unsigned x_except = x == Float128(0) ? 0 : (FPBits(x_abs).is_inf() ? 2 : 1);
+ unsigned y_except = y == Float128(0) ? 0 : (FPBits(y_abs).is_inf() ? 2 : 1);
// Exceptional cases:
// EXCEPT[y_except][x_except][x_is_neg]
@@ -151,7 +150,8 @@ LIBC_INLINE float128 atan2f128(float128 y, float128 x) {
DFloat128 r = EXCEPTS[y_except][x_except][x_sign];
if (y_sign)
r.sign = r.sign.negate();
- return static_cast<float128>(r);
+ return r.template as<Float128, /*ShouldSignalExceptions=*/false>();
+ (r);
}
}
@@ -165,7 +165,8 @@ LIBC_INLINE float128 atan2f128(float128 y, float128 x) {
DFloat128 result = quick_add(const_term, quotient);
if (final_sign)
result.sign = result.sign.negate();
- return static_cast<float128>(result);
+ return result.template as<Float128, /*ShouldSignalExceptions=*/false>();
+ (result);
}
// Take 24 leading bits of num and den to convert to float for fast division.
@@ -203,13 +204,12 @@ LIBC_INLINE float128 atan2f128(float128 y, float128 x) {
if (final_sign)
r.sign = r.sign.negate();
- return static_cast<float128>(r);
+ return r.template as<Float128, /*ShouldSignalExceptions=*/false>();
+ (r);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ATAN2F128_H
diff --git a/libc/src/math/atan2f128.h b/libc/src/math/atan2f128.h
index 26f7ec624940c..1f78947005a53 100644
--- a/libc/src/math/atan2f128.h
+++ b/libc/src/math/atan2f128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_ATAN2F128_H
#define LLVM_LIBC_SRC_MATH_ATAN2F128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 atan2f128(float128 x, float128 y);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 80c2053066f16..70507fff2fa9a 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -4039,6 +4039,7 @@ add_entrypoint_object(
../atan2f128.h
DEPENDS
libc.src.__support.math.atan2f128
+ libc.src.__support.CPP.bit
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/atan2f128.cpp b/libc/src/math/generic/atan2f128.cpp
index ec051ddd4e00b..06cbd03188b51 100644
--- a/libc/src/math/generic/atan2f128.cpp
+++ b/libc/src/math/generic/atan2f128.cpp
@@ -7,12 +7,16 @@
//===----------------------------------------------------------------------===//
#include "src/math/atan2f128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/atan2f128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, atan2f128, (float128 y, float128 x)) {
- return math::atan2f128(y, x);
+ return cpp::bit_cast<float128>(
+ math::atan2f128(cpp::bit_cast<Float128>(y), cpp::bit_cast<Float128>(x)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/atan2l.cpp b/libc/src/math/generic/atan2l.cpp
index ce7948229c740..e61fc779ddbd3 100644
--- a/libc/src/math/generic/atan2l.cpp
+++ b/libc/src/math/generic/atan2l.cpp
@@ -19,14 +19,9 @@ LLVM_LIBC_FUNCTION(long double, atan2l, (long double y, long double x)) {
#if defined(LIBC_TYPES_LONG_DOUBLE_IS_FLOAT64)
return static_cast<long double>(
math::atan2(static_cast<double>(y), static_cast<double>(x)));
-#elif defined(LIBC_TYPES_HAS_NATIVE_FLOAT128)
- // TODO: Once we have a software implementation of float128,
- // we can use it here unconditionally, even if float128 is not
- // available as a host type.
- return fputil::cast<long double>(
- math::atan2f128(fputil::cast<float128>(y), fputil::cast<float128>(x)));
#else
-#error "Extended precision is not yet supported"
+ return fputil::cast<long double>(math::atan2f128(
+ fputil::cast<fputil::Float128>(y), fputil::cast<fputil::Float128>(x)));
#endif
}
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 8850deda1c805..d6a7b4ac099ad 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -582,6 +582,8 @@ TEST(LlvmLibcSharedMathTest, AllLongDouble) {
// Emulated float128 tests
TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_FP_EQ(Float128(0.0),
+ LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
}
#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
@@ -590,8 +592,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
using FPBits = LIBC_NAMESPACE::fputil::FPBits<float128>;
int exponent;
- EXPECT_FP_EQ(float128(0.0),
- LIBC_NAMESPACE::shared::atan2f128(float128(0.0), float128(0.0)));
EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::ffmaf128(
float128(0.0), float128(0.0), float128(0.0)));
EXPECT_FP_EQ(1.0f, LIBC_NAMESPACE::shared::fsqrtf128(float128(1.0f)));
diff --git a/libc/test/src/math/CMakeLists.txt b/libc/test/src/math/CMakeLists.txt
index bf337783bfe23..15b07f2dd7d9f 100644
--- a/libc/test/src/math/CMakeLists.txt
+++ b/libc/test/src/math/CMakeLists.txt
@@ -2874,6 +2874,7 @@ add_fp_unittest(
atan2f128_test.cpp
DEPENDS
libc.src.math.atan2f128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.fp_bits
)
diff --git a/libc/test/src/math/atan2f128_test.cpp b/libc/test/src/math/atan2f128_test.cpp
index 0bfec1bd276ed..824a0765c2192 100644
--- a/libc/test/src/math/atan2f128_test.cpp
+++ b/libc/test/src/math/atan2f128_test.cpp
@@ -6,11 +6,16 @@
//
//===----------------------------------------------------------------------===//
+#include "src/__support/FPUtil/float128.h"
#include "src/math/atan2f128.h"
#include "test/UnitTest/FPMatcher.h"
#include "test/UnitTest/Test.h"
#include "utils/MPFRWrapper/MPFRUtils.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
using LlvmLibcAtan2f128Test = LIBC_NAMESPACE::testing::FPTest<float128>;
using LIBC_NAMESPACE::testing::tlog;
@@ -18,15 +23,13 @@ namespace mpfr = LIBC_NAMESPACE::testing::mpfr;
TEST_F(LlvmLibcAtan2f128Test, InQuadRange) {
constexpr StorageType X_COUNT = 123;
- constexpr StorageType X_START =
- FPBits(static_cast<float128>(0.25q)).uintval();
- constexpr StorageType X_STOP = FPBits(static_cast<float128>(4.0q)).uintval();
+ constexpr StorageType X_START = FPBits(static_cast<float128>(0.25)).uintval();
+ constexpr StorageType X_STOP = FPBits(static_cast<float128>(4.0)).uintval();
constexpr StorageType X_STEP = (X_STOP - X_START) / X_COUNT;
constexpr StorageType Y_COUNT = 137;
- constexpr StorageType Y_START =
- FPBits(static_cast<float128>(0.25q)).uintval();
- constexpr StorageType Y_STOP = FPBits(static_cast<float128>(4.0q)).uintval();
+ constexpr StorageType Y_START = FPBits(static_cast<float128>(0.25)).uintval();
+ constexpr StorageType Y_STOP = FPBits(static_cast<float128>(4.0)).uintval();
constexpr StorageType Y_STEP = (Y_STOP - Y_START) / Y_COUNT;
auto test = [&](mpfr::RoundingMode rounding_mode) {
@@ -42,7 +45,7 @@ TEST_F(LlvmLibcAtan2f128Test, InQuadRange) {
for (StorageType i = 0, v = X_START; i <= X_COUNT; ++i, v += X_STEP) {
float128 x = FPBits(v).get_val();
- if (FPBits(x).is_inf_or_nan() || x < 0.0q)
+ if (FPBits(x).is_inf_or_nan() || x < float128(0.0))
continue;
for (StorageType j = 0, w = Y_START; j <= Y_COUNT; ++j, w += Y_STEP) {
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 91d76f2c7973c..8efa4a3ba3eb3 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -5065,6 +5065,8 @@ add_fp_unittest(
atan2f128_test.cpp
DEPENDS
libc.src.math.atan2f128
+ libc.src.__support.FPUtil.float128
+ libc.src.__support.integer_literals
)
add_fp_unittest(
diff --git a/libc/test/src/math/smoke/atan2f128_test.cpp b/libc/test/src/math/smoke/atan2f128_test.cpp
index 82feb28173ff6..9957fa74728de 100644
--- a/libc/test/src/math/smoke/atan2f128_test.cpp
+++ b/libc/test/src/math/smoke/atan2f128_test.cpp
@@ -6,17 +6,32 @@
//
//===----------------------------------------------------------------------===//
+#include "src/__support/FPUtil/float128.h"
+#include "src/__support/integer_literals.h"
#include "src/math/atan2f128.h"
#include "test/UnitTest/FPMatcher.h"
#include "test/UnitTest/Test.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
+using LIBC_NAMESPACE::operator""_u128;
+
using LlvmLibcAtan2f128Test = LIBC_NAMESPACE::testing::FPTest<float...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/216508
More information about the libc-commits
mailing list