[libc-commits] [libc] [libc] Make sqrtf128 use emulated float128 (PR #216500)

via libc-commits libc-commits at lists.llvm.org
Sat Aug 15 13:39:11 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Zorojuro (Sukumarsawant)

<details>
<summary>Changes</summary>



---

Patch is 32.18 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/216500.diff


26 Files Affected:

- (modified) libc/config/baremetal/aarch64/entrypoints.txt (+1-1) 
- (modified) libc/config/baremetal/arm/entrypoints.txt (+1-1) 
- (modified) libc/config/baremetal/riscv/entrypoints.txt (+1-1) 
- (modified) libc/config/darwin/aarch64/entrypoints.txt (+1-1) 
- (modified) libc/config/darwin/x86_64/entrypoints.txt (+1) 
- (modified) libc/config/freebsd/x86_64/entrypoints.txt (+1-1) 
- (modified) libc/config/gpu/amdgpu/entrypoints.txt (+1) 
- (modified) libc/config/gpu/nvptx/entrypoints.txt (+1) 
- (modified) libc/config/linux/aarch64/entrypoints.txt (+1-1) 
- (modified) libc/config/linux/arm/entrypoints.txt (+1) 
- (modified) libc/config/linux/riscv/entrypoints.txt (+1-1) 
- (modified) libc/config/linux/x86_64/entrypoints.txt (+1-1) 
- (modified) libc/config/windows/entrypoints.txt (+1) 
- (modified) libc/shared/math/sqrtf128.h (-6) 
- (modified) libc/src/__support/math/CMakeLists.txt (+1-1) 
- (modified) libc/src/__support/math/sqrtf128.h (+6-9) 
- (modified) libc/src/math/generic/CMakeLists.txt (+1) 
- (modified) libc/src/math/generic/sqrtf128.cpp (+4-1) 
- (modified) libc/src/math/sqrtf128.h (+5) 
- (modified) libc/test/shared/shared_math_test.cpp (+1-1) 
- (modified) libc/test/src/math/CMakeLists.txt (+2) 
- (modified) libc/test/src/math/smoke/CMakeLists.txt (+3) 
- (modified) libc/test/src/math/smoke/ceilf128_test.cpp (+1) 
- (modified) libc/test/src/math/smoke/generic_sqrtf128_test.cpp (+5) 
- (modified) libc/test/src/math/smoke/sqrtf128_test.cpp (+148-66) 
- (modified) libc/test/src/math/sqrtf128_test.cpp (+46-20) 


``````````diff
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 81958d224f70d..af670ce5b0bad 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -568,6 +568,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -790,7 +791,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index ee3ec63132cc2..c87dff4dbad44 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -580,6 +580,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -801,7 +802,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index c9f7c042bf4a8..0be619b4ac4ac 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -576,6 +576,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -798,7 +799,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 0ca00419a916c..eadd20cf2907c 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -387,6 +387,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -610,7 +611,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 136d5a458d484..80571247d24ff 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -223,6 +223,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     #libc.src.math.sinf
     #libc.src.math.sqrt
     #libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     #libc.src.math.sqrtl
     #libc.src.math.tanf
     #libc.src.math.tanhf
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index 2223504718444..09edbaaa79599 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -281,6 +281,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinhf
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -548,7 +549,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 12783aa4e5316..91f22187dc62a 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -511,6 +511,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index 5820448e06663..bfb1fda9e362c 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -508,6 +508,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 071a7830b43d3..a2921ab9bd2fa 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -721,6 +721,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -937,7 +938,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 1adbb04bb4cbe..e8d2862db2313 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -538,6 +538,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinhf
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 66dd9dd790737..83af6597993e7 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -794,6 +794,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -1027,7 +1028,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 6045886c2f11c..c37f6ebd876aa 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -799,6 +799,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinpif
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
@@ -1032,7 +1033,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
     libc.src.math.scalbnf128
     libc.src.math.setpayloadf128
     libc.src.math.setpayloadsigf128
-    libc.src.math.sqrtf128
     libc.src.math.totalorderf128
     libc.src.math.totalordermagf128
     libc.src.math.truncf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 142b83e71efe6..ebd0caa57eafc 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -314,6 +314,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.sinhf
     libc.src.math.sqrt
     libc.src.math.sqrtf
+    libc.src.math.sqrtf128
     libc.src.math.sqrtl
     libc.src.math.tan
     libc.src.math.tanf
diff --git a/libc/shared/math/sqrtf128.h b/libc/shared/math/sqrtf128.h
index d91814aa377f9..39120396012ce 100644
--- a/libc/shared/math/sqrtf128.h
+++ b/libc/shared/math/sqrtf128.h
@@ -9,10 +9,6 @@
 #ifndef LLVM_LIBC_SHARED_MATH_SQRTF128_H
 #define LLVM_LIBC_SHARED_MATH_SQRTF128_H
 
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
 #include "shared/libc_common.h"
 #include "src/__support/math/sqrtf128.h"
 
@@ -24,6 +20,4 @@ using math::sqrtf128;
 } // namespace shared
 } // namespace LIBC_NAMESPACE_DECL
 
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
 #endif // LLVM_LIBC_SHARED_MATH_SQRTF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index db514db61a9df..d05e2ffd959f0 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -5403,7 +5403,7 @@ add_header_library(
     libc.src.__support.common
     libc.src.__support.macros.optimization
     libc.src.__support.uint128
-    libc.include.llvm-libc-types.float128
+    libc.src.__support.FPUtil.float128
 )
 
 add_header_library(
diff --git a/libc/src/__support/math/sqrtf128.h b/libc/src/__support/math/sqrtf128.h
index b7654dce9e8a1..a1fe100ff4b22 100644
--- a/libc/src/__support/math/sqrtf128.h
+++ b/libc/src/__support/math/sqrtf128.h
@@ -9,13 +9,10 @@
 #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_SQRTF128_H
 #define LLVM_LIBC_SRC___SUPPORT_MATH_SQRTF128_H
 
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
 #include "src/__support/CPP/bit.h"
 #include "src/__support/FPUtil/FEnvImpl.h"
 #include "src/__support/FPUtil/FPBits.h"
+#include "src/__support/FPUtil/float128.h"
 #include "src/__support/FPUtil/rounding_mode.h"
 #include "src/__support/common.h"
 #include "src/__support/macros/optimization.h"
@@ -58,6 +55,8 @@
 namespace LIBC_NAMESPACE_DECL {
 namespace math {
 
+using LIBC_NAMESPACE::fputil::Float128;
+
 namespace sqrtf128_internal {
 
 template <typename T, typename U = T> LIBC_INLINE constexpr T prod_hi(T, U);
@@ -280,9 +279,9 @@ LIBC_INLINE constexpr uint64_t rsqrt_approx(uint64_t m) {
 
 } // namespace sqrtf128_internal
 
-LIBC_INLINE float128 sqrtf128(float128 x) {
+LIBC_INLINE Float128 sqrtf128(Float128 x) {
   using namespace sqrtf128_internal;
-  using FPBits = fputil::FPBits<float128>;
+  using FPBits = fputil::FPBits<Float128>;
   // Get rounding mode.
   uint32_t rm = fputil::get_round();
 
@@ -441,12 +440,10 @@ LIBC_INLINE float128 sqrtf128(float128 x) {
   // if(frac) fputil::raise_except_if_required(FE_INEXACT);
 
   v += static_cast<UInt128>(e2) << FPBits::FRACTION_LEN; // place exponent
-  return cpp::bit_cast<float128>(v);
+  return cpp::bit_cast<Float128>(v);
 }
 
 } // namespace math
 } // namespace LIBC_NAMESPACE_DECL
 
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
 #endif // LLVM_LIBC_SRC___SUPPORT_MATH_SQRTF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 80c2053066f16..e15b53d0a53f1 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2698,6 +2698,7 @@ add_entrypoint_object(
     ../sqrtf128.h
   DEPENDS
     libc.src.__support.math.sqrtf128
+    libc.src.__support.CPP.bit
 )
 
 add_entrypoint_object(
diff --git a/libc/src/math/generic/sqrtf128.cpp b/libc/src/math/generic/sqrtf128.cpp
index 47e4da97581ba..3837dbc485b82 100644
--- a/libc/src/math/generic/sqrtf128.cpp
+++ b/libc/src/math/generic/sqrtf128.cpp
@@ -7,12 +7,15 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/math/sqrtf128.h"
+#include "src/__support/CPP/bit.h"
 #include "src/__support/math/sqrtf128.h"
 
 namespace LIBC_NAMESPACE_DECL {
 
+using LIBC_NAMESPACE::fputil::Float128;
+
 LLVM_LIBC_FUNCTION(float128, sqrtf128, (float128 x)) {
-  return math::sqrtf128(x);
+  return cpp::bit_cast<float128>(math::sqrtf128(cpp::bit_cast<Float128>(x)));
 }
 
 } // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/sqrtf128.h b/libc/src/math/sqrtf128.h
index 81f4c12eff90d..e73f3a25c41c2 100644
--- a/libc/src/math/sqrtf128.h
+++ b/libc/src/math/sqrtf128.h
@@ -9,11 +9,16 @@
 #ifndef LLVM_LIBC_SRC_MATH_SQRTF128_H
 #define LLVM_LIBC_SRC_MATH_SQRTF128_H
 
+#include "src/__support/FPUtil/float128.h"
 #include "src/__support/macros/config.h"
 #include "src/__support/macros/properties/types.h"
 
 namespace LIBC_NAMESPACE_DECL {
 
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
 float128 sqrtf128(float128 x);
 
 } // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 8850deda1c805..9043557c2e119 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -582,6 +582,7 @@ TEST(LlvmLibcSharedMathTest, AllLongDouble) {
 // Emulated float128 tests
 TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
   EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+  EXPECT_FP_EQ(Float128(1.0), LIBC_NAMESPACE::shared::sqrtf128(Float128(1.0)));
 }
 
 #ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
@@ -607,7 +608,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
   EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::logbf128(float128(1.0)));
   EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dfmaf128(
                         float128(0.0), float128(0.0), float128(0.0)));
-  EXPECT_FP_EQ(float128(1.0), LIBC_NAMESPACE::shared::sqrtf128(float128(1.0)));
   EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0)));
 
   EXPECT_EQ(0L, LIBC_NAMESPACE::shared::llogbf128(float128(1.0)));
diff --git a/libc/test/src/math/CMakeLists.txt b/libc/test/src/math/CMakeLists.txt
index bf337783bfe23..667967211e48e 100644
--- a/libc/test/src/math/CMakeLists.txt
+++ b/libc/test/src/math/CMakeLists.txt
@@ -1791,6 +1791,8 @@ add_fp_unittest(
     SqrtTest.h
   DEPENDS
     libc.src.math.sqrtf128
+    libc.src.__support.FPUtil.float128
+    libc.src.__support.integer_literals
 )
 
 add_fp_unittest(
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 91d76f2c7973c..1e511222c088d 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3609,6 +3609,8 @@ add_fp_unittest(
     SqrtTest.h
   DEPENDS
     libc.src.math.sqrtf128
+    libc.src.__support.FPUtil.float128
+    libc.src.__support.integer_literals
 )
 
 add_fp_unittest(
@@ -3678,6 +3680,7 @@ add_fp_unittest(
     # The dependency on sqrtf128 is used to disable the test when float128
     # support is not available.
     libc.src.math.sqrtf128
+    libc.src.__support.FPUtil.float128
     libc.src.__support.FPUtil.generic.sqrt
   COMPILE_OPTIONS
     ${libc_opt_high_flag}
diff --git a/libc/test/src/math/smoke/ceilf128_test.cpp b/libc/test/src/math/smoke/ceilf128_test.cpp
index 2547e38256270..ba5a768610a65 100644
--- a/libc/test/src/math/smoke/ceilf128_test.cpp
+++ b/libc/test/src/math/smoke/ceilf128_test.cpp
@@ -7,6 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "CeilTest.h"
+
 #include "src/__support/FPUtil/float128.h"
 #include "src/math/ceilf128.h"
 
diff --git a/libc/test/src/math/smoke/generic_sqrtf128_test.cpp b/libc/test/src/math/smoke/generic_sqrtf128_test.cpp
index 790ff0a47bd3a..e35d522597fa1 100644
--- a/libc/test/src/math/smoke/generic_sqrtf128_test.cpp
+++ b/libc/test/src/math/smoke/generic_sqrtf128_test.cpp
@@ -8,6 +8,11 @@
 
 #include "SqrtTest.h"
 
+#include "src/__support/FPUtil/float128.h"
 #include "src/__support/FPUtil/generic/sqrt.h"
 
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
 LIST_SQRT_TESTS(float128, LIBC_NAMESPACE::fputil::sqrt<float128>);
diff --git a/libc/test/src/math/smoke/sqrtf128_test.cpp b/libc/test/src/math/smoke/sqrtf128_test.cpp
index 2fca74842d313..646be121c903a 100644
--- a/libc/test/src/math/smoke/sqrtf128_test.cpp
+++ b/libc/test/src/math/smoke/sqrtf128_test.cpp
@@ -8,9 +8,16 @@
 
 #include "SqrtTest.h"
 
-#include "src/__support/uint128.h"
+#include "src/__support/FPUtil/float128.h"
+#include "src/__support/integer_literals.h"
 #include "src/math/sqrtf128.h"
 
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
+using LIBC_NAMESPACE::operator""_u128;
+
 LIST_SQRT_TESTS(float128, LIBC_NAMESPACE::sqrtf128);
 
 TEST_F(LlvmLibcSqrtTest, HardToRound) {
@@ -24,69 +31,129 @@ TEST_F(LlvmLibcSqrtTest, HardToRound) {
   // cases for the round to nearest mode but also the directional
   // modes.
   float128 HARD_TO_ROUND[][2] = {
-      {0x0.000000dee2f5b6a26c8f07f05442p-16382q,
-       -0x1.ddbd8763a617cff753e2a31083p-8204q},
-      {0x0.000000c86d174c5ad8ae54a548e7p-16382q,
-       0x1.c507bb538940719890851ec1ca88p-8204q},
-      {0x0.000020ab15cfe0b8e488e128f535p-16382q,
-       -0x1.6dccb402560213bc0d62d62e910bp-8201q},
-      {0x0.0000219e97732a9970f2511989bap-16382q,
-       0x1.73163d28be706f4b5052791e28a5p-8201q},
-      {0x0.000026e477546ae99ef57066f9fdp-16382q,
-       -0x1.8f20dd0d0c570a23ea59bc2bf009p-8201q},
-      {0x0.00002d0f88d27a496b3e533f5067p-16382q,
-       0x1.ad9d4abe9f047225a7352bcc52c1p-8201q},
-      {0x1.0000000000000000000000000001p+0q, 0x1p+0q},
-      {0x1.0000000000000000000000000002p+0q,
-       -0x1.0000000000000000000000000001p+0q},
-      {0x1.0000000000000000000000000003p+0q,
-       0x1.0000000000000000000000000001p+0q},
-      {0x1.0000000000000000000000000005p+0q,
-       0x1.0000000000000000000000000002p+0q},
-      {0x1.0000000000000000000000000006p+0q,
-       -0x1.0000000000000000000000000003p+0q},
-      {0x1.1d4c381cbf3a0aa15b9aee344892p+0q,
-       0x1.0e408c3fadc5e64b449c63673f4bp+0q},
-      {0x1.2af17a4ae6f93d11310c49c11b59p+0q,
-       -0x1.14a3bdf0ea5231f12d421a5dbe33p+0q},
-      {0x1.96f893bf29fb91e0fbe19a46d0c8p+0q,
-       0x1.42c6bf6202e66f2295807dee44d9p+0q},
-      {0x1.97fb3839925b66804c429289cce8p+0q,
-       -0x1.432d4049ac1c85a241f333d326e9p+0q},
-      {0x1.be1d900eaeb1533f0f19cc15c7e6p+0q,
-       0x1.51f1715154da44f3bf11f3d96c2dp+0q},
-      {0x1.c4f5074269525063a26051a0ad27p+0q,
-       0x1.54864e9b1daa4d9135ff00663366p+0q},
-      {0x1.035cb5f298a801dc4be9b1f8cd97p+1q,
-       -0x1.6c688775bffcb3f507ba11d0abb9p+0q},
-      {0x1.274be02380427e709beab4dedeb4p+1q,
-       -0x1.84d5763281f2318422392e506b1cp+0q},
-      {0x1.64e797cfdbaa3f7e2f33279dbc6p+1q,
-       0x1.ab79b164e255b26eca00ff99cc99p+0q},
-      {0x1.693a741358c9dac44a570a7e9f6cp+1q,
-       0x1.ae0e8eaeab25bb0c40ee0c2693d3p+0q},
-      {0x1.8275db3fc4d822596047adcb71b9p+1q,
-       -0x1.bcd2bfb653e37a5dbe0ccc2cd917p+0q},
-      {0x1.83280bb98c4a7b88bd6f535899d9p+1q,
-       0x1.bd39409dfd1990dd6a7f8211bb27p+0q},
-      {0x1.d78d8352b48608b510bfd5c75315p+1q,
-       -0x1.eb5c420f15adce0ed2bde5a241cep+0q},
-      {0x1.e3e4774f564b526edff84ce46668p+1q,
-       0x1.f1bf73c0523a19b4bb639c98c0b5p+0q},
-      {0x1.fffffffffffffffffffffffffffap+1q,
-       -0x1.fffffffffffffffffffffffffffdp+0q},
-      {0x1.fffffffffffffffffffffffffffbp+1q,
-       0x1.fffffffffffffffffffffffffffdp+0q},
-      {0x1.fffffffffffffffffffffffffffdp+1q,
-       0x1.fffffffffffffffffffffffffffep+0q},
-      {0x1.fffffffffffffffffffffffffffep+1q,
-       -0x1.ffffffffffffffffffffffffffffp+0q},
-      {0x1.ffffffffffffffffffffffffffffp+1q,
-       0x1.ffffffffffffffffffffffffffffp+0q},
+      {FPBits(0x00000000'00dee2f5'b6a26c8f'07f05442_u128)
+           .get_val(), // 0x0.000000dee2f5b6a26c8f07f05442p-16382q
+       FPBits(0x9ff3ddbd'8763a617'cff753e2'a3108300_u128)
+           .get_val()}, // -0x1.ddbd8763a617cff753e2a31083p-8204q
+      {FPBits(0x00000000'00c86d17'4c5ad8ae'54a548e7_u128)
+           .get_val(), // 0x0.000000c86d174c5ad8ae54a548e7p-16382q
+       FPBits(0x1ff3c507'bb538940'71989085'1ec1ca88_u128)
+           .get_val()}, // 0x1.c507bb538940719890851ec1ca88p-8204q
+      {FPBits(0x00000000'20ab15cf'e0b8e488'e128f535_u128)
+           .get_val(), // 0x0.000020ab15cfe0b8e488e128f535p-16382q
+       FPBits(0x9ff66dcc'b4025...
[truncated]

``````````

</details>


https://github.com/llvm/llvm-project/pull/216500


More information about the libc-commits mailing list