[libc-commits] [libc] [libc] Read multiple interfaces per netlink message in if_nameindex (PR #213952)
via libc-commits
libc-commits at lists.llvm.org
Tue Aug 4 07:37:13 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- libc/src/net/linux/if_nameindex_impl.h libc/test/src/net/linux/if_nameindex_test.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libc/src/net/linux/if_nameindex_impl.h b/libc/src/net/linux/if_nameindex_impl.h
index eac01efde..5cea8aca4 100644
--- a/libc/src/net/linux/if_nameindex_impl.h
+++ b/libc/src/net/linux/if_nameindex_impl.h
@@ -184,9 +184,8 @@ LIBC_INLINE ErrorOr<struct if_nameindex *> if_nameindex() {
// TODO: Read more than one message.
// TODO: Deduplicate interfaces to handle restarts.
BlockStore<detail::InterfaceEntry, 16> store;
- cpp::scope_exit destroy_store([&store]() {
- BlockStore<detail::InterfaceEntry, 16>::destroy(&store);
- });
+ cpp::scope_exit destroy_store(
+ [&store]() { BlockStore<detail::InterfaceEntry, 16>::destroy(&store); });
if (ErrorOr<int> parse_res = detail::parse_netlink_messages(
{buf, static_cast<size_t>(*recv_res)}, store);
``````````
</details>
https://github.com/llvm/llvm-project/pull/213952
More information about the libc-commits
mailing list