[libc-commits] [libc] [libc] Enable most tests in hermetic mode (PR #213852)

via libc-commits libc-commits at lists.llvm.org
Tue Aug 4 00:04:18 PDT 2026 

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Pavel Labath (labath)

<details>
<summary>Changes</summary>

This is mostly a straightforward search&replace, as I've addressed the blockers in previous patches. The nontrivial parts are:
- adding a SUITE to a single (FP) test which doesn't have it (turns out hermetic tests require a SUITE argument)
- using APPEND_LIBC_TESTS in a couple of tests creating files (to avoid races between unit and hermetic versions)
- renaming add_libc_unittest to _add_libc_unittest to prevent accidental creations of non-hermetic tests (one can still use the UNIT_TEST_ONLY arg to add_libc_test to achieve this effect)

---

Patch is 45.54 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/213852.diff


51 Files Affected:

- (modified) libc/cmake/modules/LLVMLibCTestRules.cmake (+6-6) 
- (modified) libc/test/integration/startup/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/__support/printf_core/CMakeLists.txt (+3-3) 
- (modified) libc/test/src/arpa/inet/CMakeLists.txt (+8-8) 
- (modified) libc/test/src/compiler/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/dirent/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/errno/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/fcntl/CMakeLists.txt (+3-3) 
- (modified) libc/test/src/fenv/CMakeLists.txt (+7-7) 
- (modified) libc/test/src/link/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/net/linux/CMakeLists.txt (+3-3) 
- (modified) libc/test/src/netinet/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/poll/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/pthread/CMakeLists.txt (+4-4) 
- (modified) libc/test/src/pwd/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/regex/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/sched/CMakeLists.txt (+13-13) 
- (modified) libc/test/src/setjmp/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/signal/CMakeLists.txt (+10-10) 
- (modified) libc/test/src/spawn/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/stdio/scanf_core/CMakeLists.txt (+3-3) 
- (modified) libc/test/src/sys/epoll/linux/CMakeLists.txt (+6-6) 
- (modified) libc/test/src/sys/ioctl/linux/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/ipc/linux/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/personality/linux/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/prctl/linux/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/random/linux/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/resource/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/select/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/sys/sem/linux/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/sendfile/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/sendfile/sendfile_test.cpp (+3-2) 
- (modified) libc/test/src/sys/socket/linux/CMakeLists.txt (+14-14) 
- (modified) libc/test/src/sys/stat/CMakeLists.txt (+8-8) 
- (modified) libc/test/src/sys/statfs/linux/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/sys/statvfs/linux/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/sys/time/CMakeLists.txt (+4-4) 
- (modified) libc/test/src/sys/time/utimes_test.cpp (+1-1) 
- (modified) libc/test/src/sys/utsname/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/sys/wait/CMakeLists.txt (+2-2) 
- (modified) libc/test/src/termios/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/time/CMakeLists.txt (+10-10) 
- (modified) libc/test/src/ucontext/CMakeLists.txt (+1-1) 
- (modified) libc/test/src/unistd/CMakeLists.txt (+37-37) 
- (modified) libc/test/src/unistd/access_test.cpp (+1-1) 
- (modified) libc/test/src/unistd/dup2_test.cpp (+1-1) 
- (modified) libc/test/src/unistd/faccessat_test.cpp (+4-3) 
- (modified) libc/test/src/unistd/pread_pwrite_test.cpp (+1-1) 
- (modified) libc/test/src/wchar/CMakeLists.txt (+1-1) 
- (modified) libc/test/utils/FPUtil/CMakeLists.txt (+3-1) 
- (modified) libc/test/utils/UnitTest/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/libc/cmake/modules/LLVMLibCTestRules.cmake b/libc/cmake/modules/LLVMLibCTestRules.cmake
index 1abf21dda1249..33c70f1210483 100644
--- a/libc/cmake/modules/LLVMLibCTestRules.cmake
+++ b/libc/cmake/modules/LLVMLibCTestRules.cmake
@@ -242,7 +242,7 @@ endfunction()
 
 # Rule to add a libc unittest.
 # Usage
-#    add_libc_unittest(
+#    create_libc_unittest(
 #      <target name>
 #      SUITE <name of the suite this test belongs to>
 #      SRCS  <list of .cpp files for the test>
@@ -265,11 +265,11 @@ function(create_libc_unittest fq_target_name)
     ${ARGN}
   )
   if(NOT LIBC_UNITTEST_SRCS)
-    message(FATAL_ERROR "'add_libc_unittest' target requires a SRCS list of .cpp "
+    message(FATAL_ERROR "'create_libc_unittest' target requires a SRCS list of .cpp "
                         "files.")
   endif()
   if(NOT LIBC_UNITTEST_DEPENDS)
-    message(FATAL_ERROR "'add_libc_unittest' target requires a DEPENDS list of "
+    message(FATAL_ERROR "'create_libc_unittest' target requires a DEPENDS list of "
                         "'add_entrypoint_object' targets.")
   endif()
 
@@ -406,13 +406,13 @@ function(create_libc_unittest fq_target_name)
   endif()
 endfunction(create_libc_unittest)
 
-function(add_libc_unittest target_name)
+function(_add_libc_unittest target_name)
   add_target_with_flags(
     ${target_name}
     CREATE_TARGET create_libc_unittest
     ${ARGN}
   )
-endfunction(add_libc_unittest)
+endfunction(_add_libc_unittest)
 
 function(add_libc_exhaustive_testsuite suite_name)
   add_custom_target(${suite_name})
@@ -1025,7 +1025,7 @@ function(add_libc_test test_name)
     ${ARGN}
   )
   if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY)
-    add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
+    _add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
   endif()
   if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY)
     add_libc_hermetic(
diff --git a/libc/test/integration/startup/CMakeLists.txt b/libc/test/integration/startup/CMakeLists.txt
index 3a01d49b5e6c4..b6c315af84f50 100644
--- a/libc/test/integration/startup/CMakeLists.txt
+++ b/libc/test/integration/startup/CMakeLists.txt
@@ -1,5 +1,5 @@
 # A rule to add startup system tests. When we have a complete startup system,
-# we should be able to use the add_libc_unittest rule or an extension of it.
+# we should be able to use the add_libc_test rule or an extension of it.
 # But, while the system is being developed,  we need to use a special rule like
 # this.
 function(add_startup_test target_name)
diff --git a/libc/test/src/__support/printf_core/CMakeLists.txt b/libc/test/src/__support/printf_core/CMakeLists.txt
index b4db465666363..0314b1d7cfd01 100644
--- a/libc/test/src/__support/printf_core/CMakeLists.txt
+++ b/libc/test/src/__support/printf_core/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_libc_unittest(
+add_libc_test(
   parser_test
   SUITE
     libc-support-tests
@@ -13,7 +13,7 @@ add_libc_unittest(
     libc.src.__support.arg_list
 )
 
-add_libc_unittest(
+add_libc_test(
   writer_test
   SUITE
     libc-support-tests
@@ -25,7 +25,7 @@ add_libc_unittest(
     libc.src.__support.CPP.string_view
 )
 
-add_libc_unittest(
+add_libc_test(
   converter_test
   SUITE
     libc-support-tests
diff --git a/libc/test/src/arpa/inet/CMakeLists.txt b/libc/test/src/arpa/inet/CMakeLists.txt
index d6d92eacddabb..c8e1ca5bf7f35 100644
--- a/libc/test/src/arpa/inet/CMakeLists.txt
+++ b/libc/test/src/arpa/inet/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_arpa_inet_unittests)
 
-add_libc_unittest(
+add_libc_test(
   htonl
   SUITE
     libc_arpa_inet_unittests
@@ -11,7 +11,7 @@ add_libc_unittest(
     libc.src.arpa.inet.ntohl
 )
 
-add_libc_unittest(
+add_libc_test(
   htons
   SUITE
     libc_arpa_inet_unittests
@@ -22,7 +22,7 @@ add_libc_unittest(
     libc.src.arpa.inet.ntohs
 )
 
-add_libc_unittest(
+add_libc_test(
   inet_addr
   SUITE
     libc_arpa_inet_unittests
@@ -33,7 +33,7 @@ add_libc_unittest(
     libc.src.arpa.inet.inet_addr
 )
 
-add_libc_unittest(
+add_libc_test(
   inet_aton
   SUITE
     libc_arpa_inet_unittests
@@ -44,7 +44,7 @@ add_libc_unittest(
     libc.src.arpa.inet.inet_aton
 )
 
-add_libc_unittest(
+add_libc_test(
   inet_ntoa
   SUITE
     libc_arpa_inet_unittests
@@ -56,7 +56,7 @@ add_libc_unittest(
     libc.src.__support.endian_internal
 )
 
-add_libc_unittest(
+add_libc_test(
   inet_ntop
   SUITE
     libc_arpa_inet_unittests
@@ -72,7 +72,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   ntohl
   SUITE
     libc_arpa_inet_unittests
@@ -83,7 +83,7 @@ add_libc_unittest(
     libc.src.arpa.inet.ntohl
 )
 
-add_libc_unittest(
+add_libc_test(
   ntohs
   SUITE
     libc_arpa_inet_unittests
diff --git a/libc/test/src/compiler/CMakeLists.txt b/libc/test/src/compiler/CMakeLists.txt
index a45fa8c55e512..dc7f83deb1c50 100644
--- a/libc/test/src/compiler/CMakeLists.txt
+++ b/libc/test/src/compiler/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_stack_chk_guard_unittests)
 
-add_libc_unittest(
+add_libc_test(
   stack_chk_guard_test
   SUITE
     libc_stack_chk_guard_unittests
diff --git a/libc/test/src/dirent/CMakeLists.txt b/libc/test/src/dirent/CMakeLists.txt
index af18006c5d122..dd5c9783d87b8 100644
--- a/libc/test/src/dirent/CMakeLists.txt
+++ b/libc/test/src/dirent/CMakeLists.txt
@@ -1,7 +1,7 @@
 add_subdirectory(testdata)
 add_custom_target(libc_dirent_unittests)
 
-add_libc_unittest(
+add_libc_test(
   dirent_test
   SUITE
     libc_dirent_unittests
@@ -17,7 +17,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   fdopendir_test
   SUITE
     libc_dirent_unittests
diff --git a/libc/test/src/errno/CMakeLists.txt b/libc/test/src/errno/CMakeLists.txt
index 264574204e6cb..187e955e7b71c 100644
--- a/libc/test/src/errno/CMakeLists.txt
+++ b/libc/test/src/errno/CMakeLists.txt
@@ -4,7 +4,7 @@ endif()
 
 add_custom_target(libc_errno_unittests)
 
-add_libc_unittest(
+add_libc_test(
   errno_test
   SUITE
     libc_errno_unittests
diff --git a/libc/test/src/fcntl/CMakeLists.txt b/libc/test/src/fcntl/CMakeLists.txt
index b8202e5279c48..dd2b473d954c5 100644
--- a/libc/test/src/fcntl/CMakeLists.txt
+++ b/libc/test/src/fcntl/CMakeLists.txt
@@ -2,7 +2,7 @@ add_custom_target(libc_fcntl_unittests)
 
 add_subdirectory(testdata)
 
-add_libc_unittest(
+add_libc_test(
   creat_test
   SUITE
     libc_fcntl_unittests
@@ -19,7 +19,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   fcntl_test
   SUITE
     libc_fcntl_unittests
@@ -40,7 +40,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   openat_test
   SUITE
     libc_fcntl_unittests
diff --git a/libc/test/src/fenv/CMakeLists.txt b/libc/test/src/fenv/CMakeLists.txt
index d79b4a49a5e4f..a82eebd63ad2f 100644
--- a/libc/test/src/fenv/CMakeLists.txt
+++ b/libc/test/src/fenv/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_fenv_unittests)
 
-add_libc_unittest(
+add_libc_test(
   rounding_mode_test
   SUITE
     libc_fenv_unittests
@@ -13,7 +13,7 @@ add_libc_unittest(
     LibcFPTestHelpers
 )
 
-add_libc_unittest(
+add_libc_test(
   exception_status_test
   SUITE
     libc_fenv_unittests
@@ -29,7 +29,7 @@ add_libc_unittest(
     LibcFPTestHelpers
 )
 
-add_libc_unittest(
+add_libc_test(
   getenv_and_setenv_test
   SUITE
     libc_fenv_unittests
@@ -46,7 +46,7 @@ add_libc_unittest(
     LibcFPTestHelpers
 )
 
-add_libc_unittest(
+add_libc_test(
   exception_flags_test
   SUITE
     libc_fenv_unittests
@@ -61,7 +61,7 @@ add_libc_unittest(
     LibcFPTestHelpers
 )
 
-add_libc_unittest(
+add_libc_test(
   feupdateenv_test
   SUITE
     libc_fenv_unittests
@@ -75,7 +75,7 @@ add_libc_unittest(
     LibcFPTestHelpers
 )
 
-add_libc_unittest(
+add_libc_test(
   feclearexcept_test
   SUITE
     libc_fenv_unittests
@@ -88,7 +88,7 @@ add_libc_unittest(
     LibcFPTestHelpers
 )
 
-add_libc_unittest(
+add_libc_test(
   feenableexcept_test
   SUITE
     libc_fenv_unittests
diff --git a/libc/test/src/link/CMakeLists.txt b/libc/test/src/link/CMakeLists.txt
index efae9cf7e3d9b..823c96508626e 100644
--- a/libc/test/src/link/CMakeLists.txt
+++ b/libc/test/src/link/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_link_unittests)
 
-add_libc_unittest(
+add_libc_test(
   dl_iterate_phdr_test
   SUITE
     libc_link_unittests
diff --git a/libc/test/src/net/linux/CMakeLists.txt b/libc/test/src/net/linux/CMakeLists.txt
index 22f4c2429805e..0b737d6f82976 100644
--- a/libc/test/src/net/linux/CMakeLists.txt
+++ b/libc/test/src/net/linux/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_net_unittests)
 
-add_libc_unittest(
+add_libc_test(
   if_indextoname_test
   SUITE
     libc_net_unittests
@@ -14,7 +14,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   if_nametoindex_test
   SUITE
     libc_net_unittests
@@ -26,7 +26,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   if_nameindex_test
   SUITE
     libc_net_unittests
diff --git a/libc/test/src/netinet/CMakeLists.txt b/libc/test/src/netinet/CMakeLists.txt
index a9ac0c2d3c6fd..68499c648cd62 100644
--- a/libc/test/src/netinet/CMakeLists.txt
+++ b/libc/test/src/netinet/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_netinet_unittests)
 
-add_libc_unittest(
+add_libc_test(
   in_test
   SUITE
     libc_netinet_unittests
@@ -25,7 +25,7 @@ add_libc_unittest(
     libc.src.string.memcmp
 )
 
-add_libc_unittest(
+add_libc_test(
   udp_test
   SUITE
     libc_netinet_unittests
diff --git a/libc/test/src/poll/CMakeLists.txt b/libc/test/src/poll/CMakeLists.txt
index 54e00330f2bff..b6f18c5dbf4bf 100644
--- a/libc/test/src/poll/CMakeLists.txt
+++ b/libc/test/src/poll/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_poll_unittests)
 
-add_libc_unittest(
+add_libc_test(
   poll_test
   SUITE
     libc_poll_unittests
diff --git a/libc/test/src/pthread/CMakeLists.txt b/libc/test/src/pthread/CMakeLists.txt
index 2cb80e2b6ae2e..a4bbf21953653 100644
--- a/libc/test/src/pthread/CMakeLists.txt
+++ b/libc/test/src/pthread/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_pthread_unittests)
 
-add_libc_unittest(
+add_libc_test(
   pthread_attr_test
   SUITE
     libc_pthread_unittests
@@ -21,7 +21,7 @@ add_libc_unittest(
     libc.hdr.errno_macros
 )
 
-add_libc_unittest(
+add_libc_test(
   pthread_mutexattr_test
   SUITE
     libc_pthread_unittests
@@ -40,7 +40,7 @@ add_libc_unittest(
     libc.hdr.errno_macros
 )
 
-add_libc_unittest(
+add_libc_test(
   pthread_condattr_test
   SUITE
     libc_pthread_unittests
@@ -58,7 +58,7 @@ add_libc_unittest(
     libc.src.pthread.pthread_condattr_setpshared
 )
 
-add_libc_unittest(
+add_libc_test(
   pthread_rwlockattr_test
   SUITE
     libc_pthread_unittests
diff --git a/libc/test/src/pwd/CMakeLists.txt b/libc/test/src/pwd/CMakeLists.txt
index eb6c96f2f296f..c2d313157e5c9 100644
--- a/libc/test/src/pwd/CMakeLists.txt
+++ b/libc/test/src/pwd/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_pwd_unittests)
 
-add_libc_unittest(
+add_libc_test(
   pwd_utils_test
   SUITE
     libc_pwd_unittests
diff --git a/libc/test/src/regex/CMakeLists.txt b/libc/test/src/regex/CMakeLists.txt
index 915b8a5d42638..165dcb3b066a9 100644
--- a/libc/test/src/regex/CMakeLists.txt
+++ b/libc/test/src/regex/CMakeLists.txt
@@ -1,7 +1,7 @@
 if(LLVM_LIBC_FULL_BUILD AND LLVM_LIBC_ENABLE_EXPERIMENTAL_ENTRYPOINTS)
   add_custom_target(libc_regex_unittests)
 
-  add_libc_unittest(
+  add_libc_test(
     regerror_test
     SUITE
       libc_regex_unittests
@@ -12,7 +12,7 @@ if(LLVM_LIBC_FULL_BUILD AND LLVM_LIBC_ENABLE_EXPERIMENTAL_ENTRYPOINTS)
       libc.src.regex.regerror
   )
 
-  add_libc_unittest(
+  add_libc_test(
     regex_basic_test
     SUITE
       libc_regex_unittests
diff --git a/libc/test/src/sched/CMakeLists.txt b/libc/test/src/sched/CMakeLists.txt
index c7c9ceb01879c..c8bf9fea96383 100644
--- a/libc/test/src/sched/CMakeLists.txt
+++ b/libc/test/src/sched/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_sched_unittests)
 
-add_libc_unittest(
+add_libc_test(
   affinity_test
   SUITE
     libc_sched_unittests
@@ -18,7 +18,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   yield_test
   SUITE
     libc_sched_unittests
@@ -30,7 +30,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   get_priority_test
   SUITE
     libc_sched_unittests
@@ -44,7 +44,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   getcpu_test
   SUITE
     libc_sched_unittests
@@ -56,7 +56,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   sched_getcpu_test
   SUITE
     libc_sched_unittests
@@ -68,7 +68,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   scheduler_test
   SUITE
     libc_sched_unittests
@@ -88,7 +88,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   sched_rr_get_interval_test
   SUITE
     libc_sched_unittests
@@ -106,7 +106,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   cpu_alloc_test
   SUITE
     libc_sched_unittests
@@ -123,7 +123,7 @@ add_libc_unittest(
     libc.src.sched.__sched_setcpuzero
 )
 
-add_libc_unittest(
+add_libc_test(
   cpu_count_test
   SUITE
     libc_sched_unittests
@@ -146,7 +146,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   sched_andcpuset_test
   SUITE
     libc_sched_unittests
@@ -161,7 +161,7 @@ add_libc_unittest(
     libc.src.sched.__sched_setcpuzero
 )
 
-add_libc_unittest(
+add_libc_test(
   sched_cpuequal_test
   SUITE
     libc_sched_unittests
@@ -174,7 +174,7 @@ add_libc_unittest(
     libc.src.sched.__sched_setcpuzero
 )
 
-add_libc_unittest(
+add_libc_test(
   sched_orcpuset_test
   SUITE
     libc_sched_unittests
@@ -189,7 +189,7 @@ add_libc_unittest(
     libc.src.sched.__sched_setcpuzero
 )
 
-add_libc_unittest(
+add_libc_test(
   sched_xorcpuset_test
   SUITE
     libc_sched_unittests
diff --git a/libc/test/src/setjmp/CMakeLists.txt b/libc/test/src/setjmp/CMakeLists.txt
index e95476e00e54b..66c485159ea7a 100644
--- a/libc/test/src/setjmp/CMakeLists.txt
+++ b/libc/test/src/setjmp/CMakeLists.txt
@@ -5,7 +5,7 @@ if(LLVM_USE_SANITIZER)
   return()
 endif()
 
-add_libc_unittest(
+add_libc_test(
   setjmp_test
   SUITE
     libc_setjmp_unittests
@@ -18,7 +18,7 @@ add_libc_unittest(
     libc.src.setjmp.setjmp
 )
 
-add_libc_unittest(
+add_libc_test(
   sigsetjmp_test
   SUITE
     libc_setjmp_unittests
diff --git a/libc/test/src/signal/CMakeLists.txt b/libc/test/src/signal/CMakeLists.txt
index ba056090ff8f5..ac394ea6b7ab7 100644
--- a/libc/test/src/signal/CMakeLists.txt
+++ b/libc/test/src/signal/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_signal_unittests)
 
-add_libc_unittest(
+add_libc_test(
   raise_test
   SUITE
     libc_signal_unittests
@@ -11,7 +11,7 @@ add_libc_unittest(
     libc.src.signal.raise
 )
 
-add_libc_unittest(
+add_libc_test(
   kill_test
   SUITE
     libc_signal_unittests
@@ -25,7 +25,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   sigaction_test
   SUITE
     libc_signal_unittests
@@ -39,7 +39,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   sigprocmask_test
   SUITE
     libc_signal_unittests
@@ -55,7 +55,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   pthread_sigmask_test
   SUITE
     libc_signal_unittests
@@ -70,7 +70,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoCheckingTest
 )
 
-add_libc_unittest(
+add_libc_test(
   sigaddset_test
   SUITE
     libc_signal_unittests
@@ -83,7 +83,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   signal_test
   SUITE
     libc_signal_unittests
@@ -97,7 +97,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   sigfillset_test
   SUITE
     libc_signal_unittests
@@ -112,7 +112,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   sigdelset_test
   SUITE
     libc_signal_unittests
@@ -128,7 +128,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   sigaltstack_test
   SUITE
     libc_signal_unittests
diff --git a/libc/test/src/spawn/CMakeLists.txt b/libc/test/src/spawn/CMakeLists.txt
index 103925cf3a22d..1b28df216075e 100644
--- a/libc/test/src/spawn/CMakeLists.txt
+++ b/libc/test/src/spawn/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_spawn_unittests)
 
-add_libc_unittest(
+add_libc_test(
   posix_spawn_file_actions_test
   SUITE
     libc_spawn_unittests
diff --git a/libc/test/src/stdio/scanf_core/CMakeLists.txt b/libc/test/src/stdio/scanf_core/CMakeLists.txt
index abf982e4ea00e..d2931c9cc4821 100644
--- a/libc/test/src/stdio/scanf_core/CMakeLists.txt
+++ b/libc/test/src/stdio/scanf_core/CMakeLists.txt
@@ -3,7 +3,7 @@ if(NOT(LLVM_LIBC_FULL_BUILD))
   libc_set_definition(use_system_file "LIBC_COPT_STDIO_USE_SYSTEM_FILE")
 endif()
 
-add_libc_unittest(
+add_libc_test(
   parser_test
   SUITE
     libc_stdio_unittests
@@ -25,7 +25,7 @@ if(NOT(TARGET libc.src.__support.File.file) AND LLVM_LIBC_FULL_BUILD AND
   return()
 endif()
 
-add_libc_unittest(
+add_libc_test(
   reader_test
   SUITE
     libc_stdio_unittests
@@ -38,7 +38,7 @@ add_libc_unittest(
     ${use_system_file}
 )
 
-add_libc_unittest(
+add_libc_test(
   converter_test
   SUITE
     libc_stdio_unittests
diff --git a/libc/test/src/sys/epoll/linux/CMakeLists.txt b/libc/test/src/sys/epoll/linux/CMakeLists.txt
index eba480c4b6f81..06a6ce23bfa57 100644
--- a/libc/test/src/sys/epoll/linux/CMakeLists.txt
+++ b/libc/test/src/sys/epoll/linux/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_sys_epoll_unittests)
 
-add_libc_unittest(
+add_libc_test(
   epoll_create_test
   SUITE
     libc_sys_epoll_unittests
@@ -15,7 +15,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   epoll_create1_test
   SUITE
     libc_sys_epoll_unittests
@@ -30,7 +30,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   epoll_ctl_test
   SUITE
     libc_sys_epoll_unittests
@@ -48,7 +48,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   epoll_wait_test
   SUITE
     libc_sys_epoll_unittests
@@ -67,7 +67,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   epoll_pwait_test
   SUITE
     libc_sys_epoll_unittests
@@ -86,7 +86,7 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
-add_libc_unittest(
+add_libc_test(
   epoll_pwait2_test
   SUITE
     libc_sys_epoll_unittests
diff --git a/libc/test/src/sys/ioctl/linux/CMakeLists.txt b/libc/test/src/sys/ioctl/linux/CMakeLists.txt
index 69a521249dd9c..1d43f72389e10 100644
--- a/libc/test/src/sys/ioctl/linux/CMakeLists.txt
+++ b/libc/test/src/sys/ioctl/linux/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_sys_ioctl_unittests)
 
-add_libc_unittest(
+add_libc_test(
   ioctl_test
   SUITE
     libc_sys_ioctl_unittests
diff --git a/libc/test/src/sys/ipc/linux/CMakeLists.txt b/libc/test/src/sys/ipc/linux/CMakeLists.txt
index 21d501a3029ef..c635cbefd041d 100644
--- a/libc/test/src/sys/ipc/linux/CMakeLists.txt
+++ b/libc/test/src/sys/ipc/linux/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_custom_target(libc_sys_ipc_unittests)
 
-add_libc_unittest(
+add_libc_test(
   ftok_test
   SUITE
     libc_sys_ipc_unittests
diff --git a/libc/test/src/sys/personality/linux/CMakeLists.txt b/libc/test/src/sys/personality/linux/CMakeLists.txt
index 18ab52d33dc65..46382360a5058 100644
--- a/libc/test/src/sys/personality/linux/CMakeLists.txt
+++ b/libc/test/src/sys/personality/linux/CMakeLists.txt...
[truncated]

``````````

</details>


https://github.com/llvm/llvm-project/pull/213852

More information about the libc-commits mailing list