[libc-commits] [libc] [libc] Add optional::value_or and clean up if_nameindex_test TODOs (PR #213682)

[via libc-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- libc/src/__support/CPP/optional.h libc/test/src/__support/CPP/optional_test.cpp libc/test/src/net/linux/if_nameindex_test.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libc/src/__support/CPP/optional.h b/libc/src/__support/CPP/optional.h
index 0d52badf8..3b3153f6f 100644
--- a/libc/src/__support/CPP/optional.h
+++ b/libc/src/__support/CPP/optional.h
@@ -138,8 +138,7 @@ public:
                        : static_cast<T>(forward<U>(default_value));
   }
 
-  template <typename U>
-  LIBC_INLINE constexpr T value_or(U &&default_value) && {
+  template <typename U> LIBC_INLINE constexpr T value_or(U &&default_value) && {
     return has_value() ? move(storage.stored_value)
                        : static_cast<T>(forward<U>(default_value));
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/213682