[libc-commits] [libc] [libc] Replace check-libc with lit-based test execution (PR #184163)

[Joseph Huber via libc-commits]

https://github.com/jhuber6 approved this pull request.

```> ninja -C runtimes/runtimes-amdgcn-amd-amdhsa-bins check-libc-lit
ninja: Entering directory `runtimes/runtimes-amdgcn-amd-amdhsa-bins'                                   
[1988/2742] Building CXX object libc/test/src/time/CMakeFiles/libc.test.src.time.mktime_test.__hermetic__.__build__.dir/mktime_test.cpp.o
In file included from /home/jhuber/Documents/llvm/llvm-project/libc/test/src/time/mktime_test.cpp:12:
In file included from /home/jhuber/Documents/llvm/llvm-project/libc/test/UnitTest/ErrnoSetterMatcher.h:18:
In file included from /home/jhuber/Documents/llvm/llvm-project/libc/test/UnitTest/Test.h:37:
/home/jhuber/Documents/llvm/llvm-project/libc/test/UnitTest/LibcTest.h:204:36: warning: implicit conversion loses integer precision: 'long long' to 'int' [-Wshorten-64-to-32]
  204 |     return testMatch(Matcher.match(Value), Matcher, ValueStr, MatcherStr, Loc);
      |                              ~~~~~ ^~~~~
/home/jhuber/Documents/llvm/llvm-project/libc/test/src/time/mktime_test.cpp:107:5: note: in instantiation of function template specialization '__llvm_libc_23_0_0_git::testing::Test::matchAndExplain<__llvm_libc_23_0_0_git::testing::internal::ErrnoSetterMatcher<int>, long long>' requested here
  107 |     EXPECT_THAT(LIBC_NAMESPACE::mktime(&tm_data),
      |     ^
/home/jhuber/Documents/llvm/llvm-project/libc/test/UnitTest/LibcTest.h:514:3: note: expanded from macro 'EXPECT_THAT'
  514 |   LIBC_TEST_MATCH_(MATCHER, MATCH, #MATCHER, #MATCH, )
      |   ^
/home/jhuber/Documents/llvm/llvm-project/libc/test/UnitTest/LibcTest.h:509:26: note: expanded from macro 'LIBC_TEST_MATCH_'
  509 |   LIBC_TEST_SCAFFOLDING_(matchAndExplain(MATCHER, MATCH, MATCHER_STR,          \
      |                          ^
/home/jhuber/Documents/llvm/llvm-project/libc/test/UnitTest/LibcTest.h:428:7: note: expanded from macro 'LIBC_TEST_SCAFFOLDING_'
  428 |   if (TEST)                                                                    \
      |       ^
1 warning generated.
[2741/2742] Running libc tests via lit

Testing Time: 13.05s

Total Discovered Tests: 705
  Passed: 705 (100.00%)
```
Seems good, though I have one concern. We limit the threads of the GPU tests because these can quickly consume finite resources (GPU queues, scratch memory, etc). Does lit run everything with full threads?

https://github.com/llvm/llvm-project/pull/184163