[libc-commits] [libc] [libc][hdrgen] Extend guard attribute support for types (PR #191663)

Victor Campos via libc-commits libc-commits at lists.llvm.org
Tue Apr 14 03:30:37 PDT 2026


================
@@ -338,3 +337,14 @@ def json_data(self):
             "standards": self.standards,
             "includes": sorted(str(file) for file in {COMMON_HEADER} | self.includes()),
         }
+
+    def __emit_guard(self, content, current_guard, new_guard):
----------------
vhscampos wrote:

Yes.

But AFAIK, that sort of naming style is just a convention as Python doesn't have enforceable function visibility in that sense. In any case, pretty much all the functions in this file are "private" as well and they don't have leading underscores. We should choose only one style and make the whole file follow it.

https://github.com/llvm/llvm-project/pull/191663


More information about the libc-commits mailing list