[libc-commits] [libc] [llvm] [libc][math] Refactor fmaximum_mag_num family to header-only (PR #182169)
via libc-commits
libc-commits at lists.llvm.org
Mon Apr 13 07:55:24 PDT 2026
https://github.com/hulxv updated https://github.com/llvm/llvm-project/pull/182169
>From ca2651eaa7c7439b1c116995b5f0b52c6eec65f5 Mon Sep 17 00:00:00 2001
From: hulxv <hulxxv at gmail.com>
Date: Thu, 19 Feb 2026 00:33:28 +0200
Subject: [PATCH 1/4] [libc][math] Refactor fmaximum_mag_num family to
header-only
Refactored functions:
- fmaximum_mag_num
- fmaximum_mag_numbf16
- fmaximum_mag_numf
---
libc/shared/math.h | 3 ++
libc/shared/math/fmaximum_mag_num.h | 22 ++++++++
libc/shared/math/fmaximum_mag_numbf16.h | 22 ++++++++
libc/shared/math/fmaximum_mag_numf.h | 22 ++++++++
libc/src/__support/math/CMakeLists.txt | 25 +++++++++
libc/src/__support/math/fmaximum_mag_num.h | 26 +++++++++
.../src/__support/math/fmaximum_mag_numbf16.h | 27 ++++++++++
libc/src/__support/math/fmaximum_mag_numf.h | 26 +++++++++
libc/src/math/generic/CMakeLists.txt | 11 ++--
libc/src/math/generic/fmaximum_mag_num.cpp | 6 +--
.../src/math/generic/fmaximum_mag_numbf16.cpp | 7 +--
libc/src/math/generic/fmaximum_mag_numf.cpp | 6 +--
libc/test/shared/CMakeLists.txt | 3 ++
libc/test/shared/shared_math_test.cpp | 7 +++
.../llvm-project-overlay/libc/BUILD.bazel | 54 ++++++++++++++++---
15 files changed, 239 insertions(+), 28 deletions(-)
create mode 100644 libc/shared/math/fmaximum_mag_num.h
create mode 100644 libc/shared/math/fmaximum_mag_numbf16.h
create mode 100644 libc/shared/math/fmaximum_mag_numf.h
create mode 100644 libc/src/__support/math/fmaximum_mag_num.h
create mode 100644 libc/src/__support/math/fmaximum_mag_numbf16.h
create mode 100644 libc/src/__support/math/fmaximum_mag_numf.h
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 275b89db3179a..ef48732ae02c1 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -154,6 +154,9 @@
#include "math/fmaxf.h"
#include "math/fmaxf128.h"
#include "math/fmaxf16.h"
+#include "math/fmaximum_mag_num.h"
+#include "math/fmaximum_mag_numbf16.h"
+#include "math/fmaximum_mag_numf.h"
#include "math/fmaxl.h"
#include "math/frexpf.h"
#include "math/frexpf128.h"
diff --git a/libc/shared/math/fmaximum_mag_num.h b/libc/shared/math/fmaximum_mag_num.h
new file mode 100644
index 0000000000000..f356682277b73
--- /dev/null
+++ b/libc/shared/math/fmaximum_mag_num.h
@@ -0,0 +1,22 @@
+//===-- Shared fmaximum_mag_num function ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUM_H
+#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUM_H
+
+#include "src/__support/math/fmaximum_mag_num.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::fmaximum_mag_num;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUM_H
diff --git a/libc/shared/math/fmaximum_mag_numbf16.h b/libc/shared/math/fmaximum_mag_numbf16.h
new file mode 100644
index 0000000000000..c650bd2902ac6
--- /dev/null
+++ b/libc/shared/math/fmaximum_mag_numbf16.h
@@ -0,0 +1,22 @@
+//===-- Shared fmaximum_mag_numbf16 function --------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMBF16_H
+#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMBF16_H
+
+#include "src/__support/math/fmaximum_mag_numbf16.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::fmaximum_mag_numbf16;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMBF16_H
diff --git a/libc/shared/math/fmaximum_mag_numf.h b/libc/shared/math/fmaximum_mag_numf.h
new file mode 100644
index 0000000000000..862136f7db490
--- /dev/null
+++ b/libc/shared/math/fmaximum_mag_numf.h
@@ -0,0 +1,22 @@
+//===-- Shared fmaximum_mag_numf function -----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMF_H
+#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMF_H
+
+#include "src/__support/math/fmaximum_mag_numf.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::fmaximum_mag_numf;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMF_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 987ecab8c57ef..c10b4f079bc17 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1460,6 +1460,31 @@ add_header_library(
libc.src.__support.FPUtil.fma
libc.src.__support.macros.config
)
+add_header_library(
+ fmaximum_mag_num
+ HDRS
+ fmaximum_mag_num.h
+ DEPENDS
+ libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.macros.config
+)
+add_header_library(
+ fmaximum_mag_numbf16
+ HDRS
+ fmaximum_mag_numbf16.h
+ DEPENDS
+ libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.FPUtil.bfloat16
+ libc.src.__support.macros.config
+)
+add_header_library(
+ fmaximum_mag_numf
+ HDRS
+ fmaximum_mag_numf.h
+ DEPENDS
+ libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.macros.config
+)
add_header_library(
fmabf16
diff --git a/libc/src/__support/math/fmaximum_mag_num.h b/libc/src/__support/math/fmaximum_mag_num.h
new file mode 100644
index 0000000000000..b69effd9dfbd7
--- /dev/null
+++ b/libc/src/__support/math/fmaximum_mag_num.h
@@ -0,0 +1,26 @@
+//===-- Implementation header for fmaximum_mag_num --------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUM_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUM_H
+
+#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+LIBC_INLINE double fmaximum_mag_num(double x, double y) {
+ return fputil::fmaximum_mag_num(x, y);
+}
+
+} // namespace math
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUM_H
diff --git a/libc/src/__support/math/fmaximum_mag_numbf16.h b/libc/src/__support/math/fmaximum_mag_numbf16.h
new file mode 100644
index 0000000000000..aa87054f44c90
--- /dev/null
+++ b/libc/src/__support/math/fmaximum_mag_numbf16.h
@@ -0,0 +1,27 @@
+//===-- Implementation header for fmaximum_mag_numbf16 ----------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUMBF16_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUMBF16_H
+
+#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/FPUtil/bfloat16.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+LIBC_INLINE bfloat16 fmaximum_mag_numbf16(bfloat16 x, bfloat16 y) {
+ return fputil::fmaximum_mag_num(x, y);
+}
+
+} // namespace math
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUMBF16_H
diff --git a/libc/src/__support/math/fmaximum_mag_numf.h b/libc/src/__support/math/fmaximum_mag_numf.h
new file mode 100644
index 0000000000000..155b220049fd3
--- /dev/null
+++ b/libc/src/__support/math/fmaximum_mag_numf.h
@@ -0,0 +1,26 @@
+//===-- Implementation header for fmaximum_mag_numf -------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUMF_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUMF_H
+
+#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+LIBC_INLINE float fmaximum_mag_numf(float x, float y) {
+ return fputil::fmaximum_mag_num(x, y);
+}
+
+} // namespace math
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_MAG_NUMF_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 5d265b89391e6..e7e8c1bfdfc33 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2456,7 +2456,7 @@ add_entrypoint_object(
HDRS
../fmaximum_mag_num.h
DEPENDS
- libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.math.fmaximum_mag_num
)
add_entrypoint_object(
@@ -2466,7 +2466,7 @@ add_entrypoint_object(
HDRS
../fmaximum_mag_numf.h
DEPENDS
- libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.math.fmaximum_mag_numf
)
add_entrypoint_object(
@@ -2508,12 +2508,7 @@ add_entrypoint_object(
HDRS
../fmaximum_mag_numbf16.h
DEPENDS
- libc.src.__support.FPUtil.basic_operations
- libc.src.__support.FPUtil.bfloat16
- libc.src.__support.macros.config
- libc.src.__support.macros.properties.types
- FLAGS
- MISC_MATH_BASIC_OPS_OPT
+ libc.src.__support.math.fmaximum_mag_numbf16
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/fmaximum_mag_num.cpp b/libc/src/math/generic/fmaximum_mag_num.cpp
index de250bbd32b7b..40c8f6e3755d0 100644
--- a/libc/src/math/generic/fmaximum_mag_num.cpp
+++ b/libc/src/math/generic/fmaximum_mag_num.cpp
@@ -7,14 +7,12 @@
//===----------------------------------------------------------------------===//
#include "src/math/fmaximum_mag_num.h"
-#include "src/__support/FPUtil/BasicOperations.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/fmaximum_mag_num.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(double, fmaximum_mag_num, (double x, double y)) {
- return fputil::fmaximum_mag_num(x, y);
+ return math::fmaximum_mag_num(x, y);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/fmaximum_mag_numbf16.cpp b/libc/src/math/generic/fmaximum_mag_numbf16.cpp
index 485e32959b53a..a54725b7f1eee 100644
--- a/libc/src/math/generic/fmaximum_mag_numbf16.cpp
+++ b/libc/src/math/generic/fmaximum_mag_numbf16.cpp
@@ -7,15 +7,12 @@
//===----------------------------------------------------------------------===//
#include "src/math/fmaximum_mag_numbf16.h"
-#include "src/__support/FPUtil/BasicOperations.h"
-#include "src/__support/FPUtil/bfloat16.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/fmaximum_mag_numbf16.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(bfloat16, fmaximum_mag_numbf16, (bfloat16 x, bfloat16 y)) {
- return fputil::fmaximum_mag_num(x, y);
+ return math::fmaximum_mag_numbf16(x, y);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/fmaximum_mag_numf.cpp b/libc/src/math/generic/fmaximum_mag_numf.cpp
index e372f1bd1f9d3..97039ef845aec 100644
--- a/libc/src/math/generic/fmaximum_mag_numf.cpp
+++ b/libc/src/math/generic/fmaximum_mag_numf.cpp
@@ -7,14 +7,12 @@
//===----------------------------------------------------------------------===//
#include "src/math/fmaximum_mag_numf.h"
-#include "src/__support/FPUtil/BasicOperations.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/fmaximum_mag_numf.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float, fmaximum_mag_numf, (float x, float y)) {
- return fputil::fmaximum_mag_num(x, y);
+ return math::fmaximum_mag_numf(x, y);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/CMakeLists.txt b/libc/test/shared/CMakeLists.txt
index 9c4b7edb377e2..e0c3bbc19efc4 100644
--- a/libc/test/shared/CMakeLists.txt
+++ b/libc/test/shared/CMakeLists.txt
@@ -151,6 +151,9 @@ add_fp_unittest(
libc.src.__support.math.fmaxf
libc.src.__support.math.fmaxf128
libc.src.__support.math.fmaxf16
+ libc.src.__support.math.fmaximum_mag_num
+ libc.src.__support.math.fmaximum_mag_numbf16
+ libc.src.__support.math.fmaximum_mag_numf
libc.src.__support.math.fmaxl
libc.src.__support.math.frexpf
libc.src.__support.math.frexpf128
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 4c58c834960ed..6b9a1b0b37226 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -177,6 +177,8 @@ TEST(LlvmLibcSharedMathTest, AllFloat) {
EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::fdimf(0.0f, 0.0f));
EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::floorf(0.0f));
EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::fmaxf(0.0f, 0.0f));
+ EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::fmaximum_mag_numf(0.0f, 0.0f));
+
float getpayloadf_x = 0.0f;
EXPECT_FP_EQ(-1.0f, LIBC_NAMESPACE::shared::getpayloadf(&getpayloadf_x));
@@ -259,6 +261,8 @@ TEST(LlvmLibcSharedMathTest, AllDouble) {
EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::fdim(0.0, 0.0));
EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::floor(0.0));
EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::fmax(0.0, 0.0));
+ EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::fmaximum_mag_num(0.0, 0.0));
+
double getpayload_x = 0.0;
EXPECT_FP_EQ(-1.0, LIBC_NAMESPACE::shared::getpayload(&getpayload_x));
@@ -468,6 +472,9 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
EXPECT_FP_EQ(bfloat16(0.0),
LIBC_NAMESPACE::shared::fmaxbf16(bfloat16(0.0), bfloat16(0.0)));
+ EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::fmaximum_mag_numbf16(
+ bfloat16(0.0), bfloat16(0.0)));
+
bfloat16 getpayloadbf16_x = bfloat16(0.0);
EXPECT_FP_EQ(bfloat16(-1.0),
LIBC_NAMESPACE::shared::getpayloadbf16(&getpayloadbf16_x));
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index d97d65e4ee43a..b28f60f5c27a1 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -4548,12 +4548,39 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_fmaximum_mag_num",
+ hdrs = ["src/__support/math/fmaximum_mag_num.h"],
+ deps = [
+ ":__support_fputil_basic_operations",
+ ":__support_macros_config",
+ ],
+)
+
+libc_support_library(
+ name = "__support_math_fmaximum_mag_numbf16",
+ hdrs = ["src/__support/math/fmaximum_mag_numbf16.h"],
+ deps = [
+ ":__support_fputil_basic_operations",
+ ":__support_fputil_bfloat16",
+ ":__support_macros_config",
+ ],
+)
+
+libc_support_library(
+ name = "__support_math_fmaximum_mag_numf",
+ hdrs = ["src/__support/math/fmaximum_mag_numf.h"],
+ deps = [
+ ":__support_fputil_basic_operations",
+ ":__support_macros_config",
+ ],
+)
+
libc_support_library(
name = "__support_math_fmaxf",
hdrs = ["src/__support/math/fmaxf.h"],
deps = [
":__support_fputil_basic_operations",
- ":__support_macros_config",
],
)
@@ -4581,10 +4608,6 @@ libc_support_library(
name = "__support_math_fmaxl",
hdrs = ["src/__support/math/fmaxl.h"],
deps = [
- ":__support_fputil_basic_operations",
- ":__support_macros_config",
- ],
-)
libc_support_library(
name = "__support_math_ffmal",
@@ -7585,9 +7608,26 @@ libc_math_function(
name = "fmaximum_magf16",
)
-libc_math_function(name = "fmaximum_mag_num")
+libc_math_function(
+ name = "fmaximum_mag_num",
+ additional_deps = [
+ ":__support_math_fmaximum_mag_num",
+ ],
+)
+
+libc_math_function(
+ name = "fmaximum_mag_numbf16",
+ additional_deps = [
+ ":__support_math_fmaximum_mag_numbf16",
+ ],
+)
-libc_math_function(name = "fmaximum_mag_numf")
+libc_math_function(
+ name = "fmaximum_mag_numf",
+ additional_deps = [
+ ":__support_math_fmaximum_mag_numf",
+ ],
+)
libc_math_function(name = "fmaximum_mag_numl")
>From db1ed16adef1504d83f474a4f7e21bb6ff795690 Mon Sep 17 00:00:00 2001
From: hulxv <hulxxv at gmail.com>
Date: Wed, 4 Mar 2026 03:50:57 +0200
Subject: [PATCH 2/4] fix: format
---
libc/test/shared/shared_math_test.cpp | 5 +++
.../llvm-project-overlay/libc/BUILD.bazel | 39 +++++++++++--------
2 files changed, 27 insertions(+), 17 deletions(-)
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 6b9a1b0b37226..814d086e74c71 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -461,6 +461,11 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
EXPECT_EQ(0, LIBC_NAMESPACE::shared::canonicalizebf16(&canonicalizebf16_cx,
&canonicalizebf16_x));
EXPECT_FP_EQ(bfloat16(0.0), canonicalizebf16_cx);
+ EXPECT_FP_EQ(bfloat16(5.0), LIBC_NAMESPACE::shared::bf16addf(2.0f, 3.0f));
+ EXPECT_FP_EQ(bfloat16(5.0), LIBC_NAMESPACE::shared::bf16addl(2L, 3L));
+ EXPECT_FP_EQ(bfloat16(10.0),
+ LIBC_NAMESPACE::shared::bf16fmaf(2.0f, 3.0f, 4.0f));
+
EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::cbrtbf16(bfloat16(0.0)));
EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::ceilbf16(bfloat16(0.0)));
EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::floorbf16(bfloat16(0.0)));
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index b28f60f5c27a1..acab0030b06d6 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -4549,8 +4549,8 @@ libc_support_library(
)
libc_support_library(
- name = "__support_math_fmaximum_mag_num",
- hdrs = ["src/__support/math/fmaximum_mag_num.h"],
+ name = "__support_math_fmaxf",
+ hdrs = ["src/__support/math/fmaxf.h"],
deps = [
":__support_fputil_basic_operations",
":__support_macros_config",
@@ -4558,56 +4558,61 @@ libc_support_library(
)
libc_support_library(
- name = "__support_math_fmaximum_mag_numbf16",
- hdrs = ["src/__support/math/fmaximum_mag_numbf16.h"],
+ name = "__support_math_fmaxf128",
+ hdrs = ["src/__support/math/fmaxf128.h"],
deps = [
":__support_fputil_basic_operations",
- ":__support_fputil_bfloat16",
":__support_macros_config",
+ ":llvm_libc_types_float128",
],
)
libc_support_library(
- name = "__support_math_fmaximum_mag_numf",
- hdrs = ["src/__support/math/fmaximum_mag_numf.h"],
+ name = "__support_math_fmaxf16",
+ hdrs = ["src/__support/math/fmaxf16.h"],
deps = [
":__support_fputil_basic_operations",
":__support_macros_config",
+ ":llvm_libc_macros_float16_macros",
],
)
libc_support_library(
- name = "__support_math_fmaxf",
- hdrs = ["src/__support/math/fmaxf.h"],
+ name = "__support_math_fmaxl",
+ hdrs = ["src/__support/math/fmaxl.h"],
deps = [
":__support_fputil_basic_operations",
+ ":__support_macros_config",
],
)
libc_support_library(
- name = "__support_math_fmaxf128",
- hdrs = ["src/__support/math/fmaxf128.h"],
+ name = "__support_math_fmaximum_mag_num",
+ hdrs = ["src/__support/math/fmaximum_mag_num.h"],
deps = [
":__support_fputil_basic_operations",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
libc_support_library(
- name = "__support_math_fmaxf16",
- hdrs = ["src/__support/math/fmaxf16.h"],
+ name = "__support_math_fmaximum_mag_numbf16",
+ hdrs = ["src/__support/math/fmaximum_mag_numbf16.h"],
deps = [
":__support_fputil_basic_operations",
+ ":__support_fputil_bfloat16",
":__support_macros_config",
- ":llvm_libc_macros_float16_macros",
],
)
libc_support_library(
- name = "__support_math_fmaxl",
- hdrs = ["src/__support/math/fmaxl.h"],
+ name = "__support_math_fmaximum_mag_numf",
+ hdrs = ["src/__support/math/fmaximum_mag_numf.h"],
deps = [
+ ":__support_fputil_basic_operations",
+ ":__support_macros_config",
+ ],
+)
libc_support_library(
name = "__support_math_ffmal",
>From d6d1982c141f6e81740ef43680d2f2fbd0fb4cf9 Mon Sep 17 00:00:00 2001
From: hulxv <hulxxv at gmail.com>
Date: Sat, 14 Mar 2026 02:21:29 +0200
Subject: [PATCH 3/4] fix
---
libc/shared/math/fmaximum_mag_num.h | 1 +
libc/shared/math/fmaximum_mag_numbf16.h | 1 +
libc/shared/math/fmaximum_mag_numf.h | 1 +
libc/src/__support/math/CMakeLists.txt | 3 +++
libc/src/__support/math/fmaximum_mag_num.h | 1 -
libc/src/__support/math/fmaximum_mag_numbf16.h | 1 -
libc/src/__support/math/fmaximum_mag_numf.h | 1 -
7 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/libc/shared/math/fmaximum_mag_num.h b/libc/shared/math/fmaximum_mag_num.h
index f356682277b73..a644072cd4406 100644
--- a/libc/shared/math/fmaximum_mag_num.h
+++ b/libc/shared/math/fmaximum_mag_num.h
@@ -9,6 +9,7 @@
#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUM_H
#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUM_H
+#include "shared/libc_common.h"
#include "src/__support/math/fmaximum_mag_num.h"
namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/shared/math/fmaximum_mag_numbf16.h b/libc/shared/math/fmaximum_mag_numbf16.h
index c650bd2902ac6..d6b4067e59451 100644
--- a/libc/shared/math/fmaximum_mag_numbf16.h
+++ b/libc/shared/math/fmaximum_mag_numbf16.h
@@ -9,6 +9,7 @@
#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMBF16_H
#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMBF16_H
+#include "shared/libc_common.h"
#include "src/__support/math/fmaximum_mag_numbf16.h"
namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/shared/math/fmaximum_mag_numf.h b/libc/shared/math/fmaximum_mag_numf.h
index 862136f7db490..57236f4dcf1d9 100644
--- a/libc/shared/math/fmaximum_mag_numf.h
+++ b/libc/shared/math/fmaximum_mag_numf.h
@@ -9,6 +9,7 @@
#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMF_H
#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_MAG_NUMF_H
+#include "shared/libc_common.h"
#include "src/__support/math/fmaximum_mag_numf.h"
namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index c10b4f079bc17..f3fd08d3c4dab 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1460,6 +1460,7 @@ add_header_library(
libc.src.__support.FPUtil.fma
libc.src.__support.macros.config
)
+
add_header_library(
fmaximum_mag_num
HDRS
@@ -1468,6 +1469,7 @@ add_header_library(
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
)
+
add_header_library(
fmaximum_mag_numbf16
HDRS
@@ -1477,6 +1479,7 @@ add_header_library(
libc.src.__support.FPUtil.bfloat16
libc.src.__support.macros.config
)
+
add_header_library(
fmaximum_mag_numf
HDRS
diff --git a/libc/src/__support/math/fmaximum_mag_num.h b/libc/src/__support/math/fmaximum_mag_num.h
index b69effd9dfbd7..2d05351c7fdb0 100644
--- a/libc/src/__support/math/fmaximum_mag_num.h
+++ b/libc/src/__support/math/fmaximum_mag_num.h
@@ -13,7 +13,6 @@
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
-
namespace math {
LIBC_INLINE double fmaximum_mag_num(double x, double y) {
diff --git a/libc/src/__support/math/fmaximum_mag_numbf16.h b/libc/src/__support/math/fmaximum_mag_numbf16.h
index aa87054f44c90..b459f469dc790 100644
--- a/libc/src/__support/math/fmaximum_mag_numbf16.h
+++ b/libc/src/__support/math/fmaximum_mag_numbf16.h
@@ -14,7 +14,6 @@
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
-
namespace math {
LIBC_INLINE bfloat16 fmaximum_mag_numbf16(bfloat16 x, bfloat16 y) {
diff --git a/libc/src/__support/math/fmaximum_mag_numf.h b/libc/src/__support/math/fmaximum_mag_numf.h
index 155b220049fd3..d00243e295947 100644
--- a/libc/src/__support/math/fmaximum_mag_numf.h
+++ b/libc/src/__support/math/fmaximum_mag_numf.h
@@ -13,7 +13,6 @@
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
-
namespace math {
LIBC_INLINE float fmaximum_mag_numf(float x, float y) {
>From c2a44b2556bf6b6e6d1bad569d906e410337cb17 Mon Sep 17 00:00:00 2001
From: hulxv <hulxxv at gmail.com>
Date: Wed, 18 Mar 2026 01:27:32 +0200
Subject: [PATCH 4/4] missed `MISC_MATH_BASIC_OPS_OPT`
---
libc/src/__support/math/CMakeLists.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index f3fd08d3c4dab..dc054dd6cbc23 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1468,6 +1468,8 @@ add_header_library(
DEPENDS
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
+ FLAGS
+ MISC_MATH_BASIC_OPS_OPT
)
add_header_library(
@@ -1478,6 +1480,8 @@ add_header_library(
libc.src.__support.FPUtil.basic_operations
libc.src.__support.FPUtil.bfloat16
libc.src.__support.macros.config
+ FLAGS
+ MISC_MATH_BASIC_OPS_OPT
)
add_header_library(
@@ -1487,6 +1491,8 @@ add_header_library(
DEPENDS
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
+ FLAGS
+ MISC_MATH_BASIC_OPS_OPT
)
add_header_library(
More information about the libc-commits
mailing list