[libc-commits] [libc] [llvm] [libc][math] Fix: Missed adding log10p1f16 to shared math (PR #189185)
via libc-commits
libc-commits at lists.llvm.org
Sun Apr 12 14:37:43 PDT 2026
https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/189185
>From 88360104a1efccbd9a83a4ad5d7cbb130535f5e9 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Sun, 29 Mar 2026 00:20:00 +0530
Subject: [PATCH 1/2] fix:missed adding log10p1f16 to shared math
---
libc/shared/math.h | 1 +
libc/shared/math/log10p1f16.h | 29 +++++++++++++++++++
libc/test/shared/CMakeLists.txt | 1 +
libc/test/shared/shared_math_test.cpp | 7 +++--
.../llvm-project-overlay/libc/BUILD.bazel | 29 +++++++++++++++++++
5 files changed, 64 insertions(+), 3 deletions(-)
create mode 100644 libc/shared/math/log10p1f16.h
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 12a3e2cc546ba..7d31445d7dc98 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -188,6 +188,7 @@
#include "math/log10.h"
#include "math/log10f.h"
#include "math/log10f16.h"
+#include "math/log10p1f16.h"
#include "math/log1p.h"
#include "math/log1pf.h"
#include "math/log2.h"
diff --git a/libc/shared/math/log10p1f16.h b/libc/shared/math/log10p1f16.h
new file mode 100644
index 0000000000000..db1ee4cd699ff
--- /dev/null
+++ b/libc/shared/math/log10p1f16.h
@@ -0,0 +1,29 @@
+//===-- Shared log10p1f16 function ------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_LOG10P1F16_H
+#define LLVM_LIBC_SHARED_MATH_LOG10P1F16_H
+
+#include "include/llvm-libc-macros/float16-macros.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT16
+
+#include "shared/libc_common.h"
+#include "src/__support/math/log10p1f16.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::log10p1f16;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT16
+
+#endif // LLVM_LIBC_SHARED_MATH_LOG10P1F16_H
diff --git a/libc/test/shared/CMakeLists.txt b/libc/test/shared/CMakeLists.txt
index 829a92be0019e..5b742306c8225 100644
--- a/libc/test/shared/CMakeLists.txt
+++ b/libc/test/shared/CMakeLists.txt
@@ -178,6 +178,7 @@ add_fp_unittest(
libc.src.__support.math.log
libc.src.__support.math.log10
libc.src.__support.math.log10f16
+ libc.src.__support.math.log10p1f16
libc.src.__support.math.log10f
libc.src.__support.math.log1p
libc.src.__support.math.log1pf
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 8a60bdcbad095..33ce887acaf61 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -53,9 +53,10 @@ TEST(LlvmLibcSharedMathTest, AllFloat16) {
EXPECT_EQ(exponent, 5);
EXPECT_EQ(0, LIBC_NAMESPACE::shared::ilogbf16(1.0f16));
- EXPECT_FP_EQ(1.0f16, LIBC_NAMESPACE::shared::log10f16(10.0f16));
- EXPECT_FP_EQ(1.0f16, LIBC_NAMESPACE::shared::log2f16(2.0f16));
- EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::logbf16(1.0f16));
+ EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::log10f16(10.0f16));
+ EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::log10p1f16(9.0f16));
+ EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::log2f16(2.0f16));
+ EXPECT_FP_EQ(0x0p+0f16, LIBC_NAMESPACE::shared::logbf16(1.0f16));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::llogbf16(1.0f16));
EXPECT_FP_EQ(0x1.921fb6p+0f16, LIBC_NAMESPACE::shared::acosf16(0.0f16));
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 692f4ebbca32b..55f3f3876810e 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -5254,6 +5254,28 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_log10p1f16",
+ hdrs = ["src/__support/math/log10p1f16.h"],
+ deps = [
+ ":__support_common",
+ ":__support_fputil_cast",
+ ":__support_fputil_except_value_utils",
+ ":__support_fputil_fenv_impl",
+ ":__support_fputil_fp_bits",
+ ":__support_fputil_multiply_add",
+ ":__support_fputil_poly_eval",
+ ":__support_macros_config",
+ ":__support_macros_optimization",
+ ":__support_macros_properties_cpu_features",
+ ":__support_math_exp10_float16_constants",
+ ":__support_math_expxf16_utils",
+ ":hdr_errno_macros",
+ ":hdr_fenv_macros",
+ ":llvm_libc_macros_float16_macros",
+ ],
+)
+
libc_support_library(
name = "__support_math_log10f",
hdrs = ["src/__support/math/log10f.h"],
@@ -7986,6 +8008,13 @@ libc_math_function(
],
)
+libc_math_function(
+ name = "log10p1f16",
+ additional_deps = [
+ ":__support_math_log10p1f16",
+ ],
+)
+
libc_math_function(
name = "log1p",
additional_deps = [":__support_math_log1p"],
>From d37cfa2206242ecf5ee491e3b2f907a795b3bd3b Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Mon, 13 Apr 2026 03:07:05 +0530
Subject: [PATCH 2/2] nit
---
libc/test/shared/shared_math_test.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 33ce887acaf61..8ed174c892caa 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -53,10 +53,10 @@ TEST(LlvmLibcSharedMathTest, AllFloat16) {
EXPECT_EQ(exponent, 5);
EXPECT_EQ(0, LIBC_NAMESPACE::shared::ilogbf16(1.0f16));
- EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::log10f16(10.0f16));
- EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::log10p1f16(9.0f16));
- EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::log2f16(2.0f16));
- EXPECT_FP_EQ(0x0p+0f16, LIBC_NAMESPACE::shared::logbf16(1.0f16));
+ EXPECT_FP_EQ(1.0f16, LIBC_NAMESPACE::shared::log10f16(10.0f16));
+ EXPECT_FP_EQ(1.0f16, LIBC_NAMESPACE::shared::log10p1f16(9.0f16));
+ EXPECT_FP_EQ(1.0f16, LIBC_NAMESPACE::shared::log2f16(2.0f16));
+ EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::logbf16(1.0f16));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::llogbf16(1.0f16));
EXPECT_FP_EQ(0x1.921fb6p+0f16, LIBC_NAMESPACE::shared::acosf16(0.0f16));
More information about the libc-commits
mailing list