[libc-commits] [libc] [libc] Add wchar support to File (PR #189504)

[Jeff Bailey via libc-commits]

================
@@ -509,4 +551,127 @@ File::ModeFlags File::mode_flags(const char *mode) {
   return flags;
 }
 
+FileIOResult File::write_unlocked(const wchar_t *ws, size_t len) {
----------------
kaladron wrote:

This took me a few times to get how this related to the File::write_unlocked that takes a void*, and seems like it's got a good chance of being confusing to others coming along (especially with them so far apart in the file).   I'm still on a first read through, but my initial impression is that it seems like we should be able to do _something_ here to reduce duplication, make it easier to see which part of the code we're in, etc.

https://github.com/llvm/llvm-project/pull/189504