[libc-commits] [libc] [llvm] [libc] Add powerpc64le to libc-shared-tests precommit CI. (PR #190096)

via libc-commits libc-commits at lists.llvm.org
Wed Apr 1 20:49:08 PDT 2026


https://github.com/lntue updated https://github.com/llvm/llvm-project/pull/190096

>From 2164846fdc96a38649aa58a1a7b167f3adb76b3a Mon Sep 17 00:00:00 2001
From: Tue Ly <lntue.h at gmail.com>
Date: Thu, 2 Apr 2026 01:23:26 +0000
Subject: [PATCH 1/2] [libc] Add powerpc64le to libc-shared-tests precommit CI.

---
 .github/workflows/libc-shared-tests.yml | 5 +++++
 libc/test/shared/shared_math_test.cpp   | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/libc-shared-tests.yml b/.github/workflows/libc-shared-tests.yml
index 6307dd54eab12..7ba169494ca37 100644
--- a/.github/workflows/libc-shared-tests.yml
+++ b/.github/workflows/libc-shared-tests.yml
@@ -62,6 +62,11 @@ jobs:
             libcpp: libstdc++6-riscv64-cross
             target_triple: riscv64-linux-gnu
             gcc_arch: riscv64-linux-gnu
+          - arch: ppc64le
+            libc: libc6-dev-ppc64el-cross
+            libcpp: libstdc++6-ppc64el-cross
+            target_triple: powerpc64le-linux-gnu
+            gcc_arch: powerpc64le-linux-gnu
 
     steps:
       - name: Checkout LLVM
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 5dfa7851f6ab6..6b434e26c21c4 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -293,7 +293,7 @@ TEST(LlvmLibcSharedMathTest, AllLongDouble) {
   using FPBits = LIBC_NAMESPACE::fputil::FPBits<long double>;
   EXPECT_FP_EQ(0.0L, LIBC_NAMESPACE::shared::dfmal(0.0L, 0.0L, 0.0L));
   EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::fsqrtl(0.0L));
-  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dsqrtl(0.0));
+  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dsqrtl(0.0L));
   EXPECT_EQ(0, LIBC_NAMESPACE::shared::ilogbl(1.0L));
   EXPECT_EQ(0L, LIBC_NAMESPACE::shared::llogbl(1.0L));
   EXPECT_FP_EQ(0.0L, LIBC_NAMESPACE::shared::logbl(1.0L));
@@ -492,6 +492,7 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
   EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::nextafterbf16(
                                   bfloat16(0.0), bfloat16(0.0)));
   EXPECT_FP_EQ(bfloat16(1.0), LIBC_NAMESPACE::shared::sqrtbf16(bfloat16(1.0)));
+
 #ifndef LIBC_TYPES_LONG_DOUBLE_IS_DOUBLE_DOUBLE
   EXPECT_FP_EQ(bfloat16(0.0),
                LIBC_NAMESPACE::shared::nexttowardbf16(bfloat16(0.0), 0.0L));

>From f54811134f3103beafa87f52b9db5fbe6fe75aa7 Mon Sep 17 00:00:00 2001
From: Tue Ly <lntue.h at gmail.com>
Date: Thu, 2 Apr 2026 03:48:44 +0000
Subject: [PATCH 2/2] Revert libc change.

---
 libc/test/shared/shared_math_test.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 6b434e26c21c4..5dfa7851f6ab6 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -293,7 +293,7 @@ TEST(LlvmLibcSharedMathTest, AllLongDouble) {
   using FPBits = LIBC_NAMESPACE::fputil::FPBits<long double>;
   EXPECT_FP_EQ(0.0L, LIBC_NAMESPACE::shared::dfmal(0.0L, 0.0L, 0.0L));
   EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::shared::fsqrtl(0.0L));
-  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dsqrtl(0.0L));
+  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dsqrtl(0.0));
   EXPECT_EQ(0, LIBC_NAMESPACE::shared::ilogbl(1.0L));
   EXPECT_EQ(0L, LIBC_NAMESPACE::shared::llogbl(1.0L));
   EXPECT_FP_EQ(0.0L, LIBC_NAMESPACE::shared::logbl(1.0L));
@@ -492,7 +492,6 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
   EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::nextafterbf16(
                                   bfloat16(0.0), bfloat16(0.0)));
   EXPECT_FP_EQ(bfloat16(1.0), LIBC_NAMESPACE::shared::sqrtbf16(bfloat16(1.0)));
-
 #ifndef LIBC_TYPES_LONG_DOUBLE_IS_DOUBLE_DOUBLE
   EXPECT_FP_EQ(bfloat16(0.0),
                LIBC_NAMESPACE::shared::nexttowardbf16(bfloat16(0.0), 0.0L));



More information about the libc-commits mailing list