[libc-commits] [libc] [libc] Add -Wall for libc tests (PR #160220)

Vinay Deshmukh via libc-commits libc-commits at lists.llvm.org
Tue Sep 23 03:54:46 PDT 2025


https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/160220

>From ea19762a04ee89768de618fd87d368c1492eae3b Mon Sep 17 00:00:00 2001
From: Vinay Deshmukh <vinay_deshmukh at outlook.com>
Date: Mon, 22 Sep 2025 21:24:32 -0400
Subject: [PATCH] Enable -Wall

---
 libc/cmake/modules/LLVMLibCTestRules.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/cmake/modules/LLVMLibCTestRules.cmake b/libc/cmake/modules/LLVMLibCTestRules.cmake
index 9f00875390b53..19da0ad29cd84 100644
--- a/libc/cmake/modules/LLVMLibCTestRules.cmake
+++ b/libc/cmake/modules/LLVMLibCTestRules.cmake
@@ -39,7 +39,7 @@ function(_get_common_test_compile_options output_var c_test flags)
       list(APPEND compile_options "-ffixed-point")
     endif()
 
-    # list(APPEND compile_options "-Wall")
+    list(APPEND compile_options "-Wall")
     list(APPEND compile_options "-Wextra")
     # -DLIBC_WNO_ERROR=ON if you can't build cleanly with -Werror.
     if(NOT LIBC_WNO_ERROR)



More information about the libc-commits mailing list