[libc-commits] [libc] [libc] Add -Wextra for libc tests (PR #153321)

[LLVM Continuous Integration via libc-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-fullbuild-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/31883

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[2999/3080] Running unit test libc.test.include.fpclassify_test.__unit__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcFpClassifyTest.SpecialNumbers
[       OK ] LlvmLibcFpClassifyTest.SpecialNumbers (3 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[3000/3080] Building C object libc/test/include/CMakeFiles/libc.test.include.isnormal_c_test.__unit__.__build__.dir/isnormal_test.c.o
[3001/3080] Building C object libc/test/include/CMakeFiles/libc.test.include.isinf_c_test.__unit__.__build__.dir/isinf_test.c.o
[3002/3080] Linking CXX executable libc/test/include/libc.test.include.complex_test.__unit__.__build__
[3003/3080] Linking C executable libc/test/include/libc.test.include.isnormal_c_test.__unit__.__build__
[3004/3080] Building C object libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o
FAILED: libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o 
/usr/bin/clang -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -D_DEBUG -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem libc/include -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-comment -Wstring-conversion -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_DEFAULT -DLIBC_THREAD_MODE=LIBC_THREAD_MODE_PLATFORM -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wextra -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -DLIBC_TEST=UNIT -Wall -Werror -MD -MT libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o -MF libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o.d -o libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_test.c
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_test.c:23:
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected expression
STDBIT_STUB_FUNCTION(stdc_leading_zeros, 0xA)
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:28: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                           ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected parameter declarator
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:27: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                          ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected ')'
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:44: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                                           ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: note: to match this '('
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:26: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                         ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: this old-style function definition is not preceded by a prototype [-Werror,-Wstrict-prototypes]
STDBIT_STUB_FUNCTION(stdc_leading_zeros, 0xA)
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:26: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                         ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected expression
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:23:28: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_us([[maybe_unused]] unsigned short x) {                 \
                           ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected parameter declarator
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:23:27: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_us([[maybe_unused]] unsigned short x) {                 \
                          ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected ')'
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:23:44: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_us([[maybe_unused]] unsigned short x) {                 \
                                           ^
Step 8 (libc-unit-tests) failure: libc-unit-tests (failure)
...
[2999/3080] Running unit test libc.test.include.fpclassify_test.__unit__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcFpClassifyTest.SpecialNumbers
[       OK ] LlvmLibcFpClassifyTest.SpecialNumbers (3 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[3000/3080] Building C object libc/test/include/CMakeFiles/libc.test.include.isnormal_c_test.__unit__.__build__.dir/isnormal_test.c.o
[3001/3080] Building C object libc/test/include/CMakeFiles/libc.test.include.isinf_c_test.__unit__.__build__.dir/isinf_test.c.o
[3002/3080] Linking CXX executable libc/test/include/libc.test.include.complex_test.__unit__.__build__
[3003/3080] Linking C executable libc/test/include/libc.test.include.isnormal_c_test.__unit__.__build__
[3004/3080] Building C object libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o
FAILED: libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o 
/usr/bin/clang -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -D_DEBUG -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem libc/include -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-comment -Wstring-conversion -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_DEFAULT -DLIBC_THREAD_MODE=LIBC_THREAD_MODE_PLATFORM -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wextra -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -DLIBC_TEST=UNIT -Wall -Werror -MD -MT libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o -MF libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o.d -o libc/test/include/CMakeFiles/libc.test.include.stdbit_c_test.__unit__.__build__.dir/stdbit_test.c.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_test.c
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_test.c:23:
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected expression
STDBIT_STUB_FUNCTION(stdc_leading_zeros, 0xA)
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:28: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                           ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected parameter declarator
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:27: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                          ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected ')'
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:44: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                                           ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: note: to match this '('
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:26: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                         ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: this old-style function definition is not preceded by a prototype [-Werror,-Wstrict-prototypes]
STDBIT_STUB_FUNCTION(stdc_leading_zeros, 0xA)
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:20:26: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_uc([[maybe_unused]] unsigned char x) {                  \
                         ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected expression
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:23:28: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_us([[maybe_unused]] unsigned short x) {                 \
                           ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected parameter declarator
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:23:27: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_us([[maybe_unused]] unsigned short x) {                 \
                          ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:38:1: error: expected ')'
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/include/stdbit_stub.h:23:44: note: expanded from macro 'STDBIT_STUB_FUNCTION'
  unsigned FUNC_NAME##_us([[maybe_unused]] unsigned short x) {                 \
                                           ^

```

</details>

https://github.com/llvm/llvm-project/pull/153321