[libc-commits] [libc] 39189c3 - [libc] Fix strftime_test (#165770)
via libc-commits
libc-commits at lists.llvm.org
Thu Oct 30 12:36:55 PDT 2025
Author: Michael Jones
Date: 2025-10-30T19:36:51Z
New Revision: 39189c3e99b634a0a8b58cf89312d6d47d0a51ba
URL: https://github.com/llvm/llvm-project/commit/39189c3e99b634a0a8b58cf89312d6d47d0a51ba
DIFF: https://github.com/llvm/llvm-project/commit/39189c3e99b634a0a8b58cf89312d6d47d0a51ba.diff
LOG: [libc] Fix strftime_test (#165770)
A typo in #165711 caused sanitizer failures (the small buffer was used
for the larger test). Renamed the variables to avoid the mistake in
future.
Added:
Modified:
libc/test/src/time/strftime_test.cpp
Removed:
################################################################################
diff --git a/libc/test/src/time/strftime_test.cpp b/libc/test/src/time/strftime_test.cpp
index 38176f77804d5..5222152791905 100644
--- a/libc/test/src/time/strftime_test.cpp
+++ b/libc/test/src/time/strftime_test.cpp
@@ -2329,20 +2329,21 @@ TEST(LlvmLibcStrftimeTest, TimeFormatFullDateTime) {
TEST(LlvmLibcStrftimeTest, BufferTooSmall) {
struct tm time;
- char buffer[1];
+ char tiny_buffer[1];
time.tm_year = get_adjusted_year(2025);
time.tm_mon = 10;
time.tm_mday = 24;
size_t written =
- LIBC_NAMESPACE::strftime(buffer, sizeof(buffer), "%F", &time);
+ LIBC_NAMESPACE::strftime(tiny_buffer, sizeof(tiny_buffer), "%F", &time);
EXPECT_EQ(written, size_t{0});
- char buffer2[10];
+ char small_buffer[10];
// The string "2025-11-24" is 10 chars,
// so strftime needs 10 + 1 bytes to write the string and the null terminator.
- written = LIBC_NAMESPACE::strftime(buffer, sizeof(buffer2), "%F", &time);
+ written =
+ LIBC_NAMESPACE::strftime(small_buffer, sizeof(small_buffer), "%F", &time);
EXPECT_EQ(written, size_t{0});
}
More information about the libc-commits
mailing list