[libc-commits] [libc] [llvm] [Flang-RT][libc] LLVM-independent unittests (PR #164794)

[Michael Kruse via libc-commits]

Meinersbur wrote:

> * There's an impact on cmake used by other projects though, so we need some review from them.

libc also uses `llvm_gtest` and in theory should have the same problems. I tested it with this patch and it worked. 

omptest and compiler-rt have different mechanisms (compiler-rt recompiles gtest-all.cpp for every test), so I left it out.


> Your example though, I see why that cannot be done. Even if we added test specific library choices, those tests would link to a runtime library linked against something else.

My mental model was the the LLVM_RUNTIME_TARGETS=default build existed for the purpose of ensuring ABI compatibility. In practice it seems too difficult to ensure. My fix #139712 was reverted and #158156 even is trying to remove the default build. It seems easier to not depend on it.


https://github.com/llvm/llvm-project/pull/164794