[libc-commits] [libc] [libc] Disable overflow test in strfromtest (PR #166719)

via libc-commits libc-commits at lists.llvm.org
Thu Nov 6 07:17:24 PST 2025


================
@@ -514,6 +514,6 @@ class StrfromTest : public LIBC_NAMESPACE::testing::ErrnoCheckingTest {
     insufficentBufsize(func);                                                  \
   }                                                                            \
   TEST_F(LlvmLibc##name##Test, InfAndNanValues) { infNanValues(func); }        \
-  TEST_F(LlvmLibc##name##Test, CharsWrittenOverflow) {                         \
-    charsWrittenOverflow(func);                                                \
-  }
+  // TEST_F(LlvmLibc##name##Test, CharsWrittenOverflow) { \
+  //   charsWrittenOverflow(func); \
+  // }
----------------
lntue wrote:

Don't disable the test for all targets.  Can you include `src/__support/macros/properties/architectures.h`, then wrap the body of `charsWrittenOverflow` in `#ifndef LIBC_TARGET_ARCH_IS_RISCV32`

https://github.com/llvm/llvm-project/pull/166719


More information about the libc-commits mailing list