[libc-commits] [libc] [libc][uefi] add crt1 (PR #132150)

[Michael Jones via libc-commits]

================
@@ -7,14 +7,15 @@
 //===-----------------------------------------------------------------===//
 
 #include "src/__support/OSUtil/exit.h"
-#include "include/Uefi.h"
+#include "Uefi.h"
----------------
michaelrj-google wrote:

Including the public interface headers is bad practice inside of libc. If you need a type/macro it should go through a proxy header (e.g. https://github.com/llvm/llvm-project/blob/51bceb46f8eeb7c3d060387be315ca41855933c2/libc/hdr/types/struct_epoll_event.h)
If you need a function then it's recommended to create an internal interface for that function and call that both in the entrypoint and externally (e.g. https://github.com/llvm/llvm-project/blob/51bceb46f8eeb7c3d060387be315ca41855933c2/libc/src/__support/str_to_integer.h#L83)

Here and elsewhere in this patch.

https://github.com/llvm/llvm-project/pull/132150