[libc-commits] [libc] 6aed161 - [libc][NFC] Remove incorrect file level dependency in CMake (#132937)
via libc-commits
libc-commits at lists.llvm.org
Tue Mar 25 07:33:29 PDT 2025
Author: Joseph Huber
Date: 2025-03-25T09:33:25-05:00
New Revision: 6aed161cb986234fbe2378d4c3c79d4120eef6b9
URL: https://github.com/llvm/llvm-project/commit/6aed161cb986234fbe2378d4c3c79d4120eef6b9
DIFF: https://github.com/llvm/llvm-project/commit/6aed161cb986234fbe2378d4c3c79d4120eef6b9.diff
LOG: [libc][NFC] Remove incorrect file level dependency in CMake (#132937)
Summary:
CMake doesn't support this type of dependency so it keeps emitting a
warning. Just remove it, because it's not doing anything currently
anyway. If we really wanted this to work you'd need to add a custom
target that has a dependency on the output of a custom command, but that
would only be worhwhile if we ever expected this file to change.
Added:
Modified:
libc/test/src/__support/CMakeLists.txt
Removed:
################################################################################
diff --git a/libc/test/src/__support/CMakeLists.txt b/libc/test/src/__support/CMakeLists.txt
index 8d175e857fcd1..d056969034d69 100644
--- a/libc/test/src/__support/CMakeLists.txt
+++ b/libc/test/src/__support/CMakeLists.txt
@@ -272,7 +272,6 @@ if(NOT LIBC_TARGET_OS_IS_GPU)
add_custom_command(TARGET libc_str_to_float_comparison_test
POST_BUILD
COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
- DEPENDS ${float_test_file}
COMMENT "Test the strtof and strtod implementations against precomputed results."
VERBATIM)
endif()
More information about the libc-commits
mailing list