[libc-commits] [libc] 1f96788 - [libc][math] Fix range and comments in exhaustive hypotf_test (#131769)

[via libc-commits]

Author: Tejas Vipin
Date: 2025-03-24T12:32:11-04:00
New Revision: 1f967887018c63bddf5bf2860e0e6a3aa1e85840

URL: https://github.com/llvm/llvm-project/commit/1f967887018c63bddf5bf2860e0e6a3aa1e85840
DIFF: https://github.com/llvm/llvm-project/commit/1f967887018c63bddf5bf2860e0e6a3aa1e85840.diff

LOG: [libc][math] Fix range and comments in exhaustive hypotf_test (#131769)

`((23U + 127U) << 23) + 1` evaluates to `(2^23)+1` as opposed to `2^24`,
so should instead be `(24U + 127U) << 23`. Additionally, range for both
inputs is inclusive of STOP. The comments have been updated reflecting
these changes.

Added: 
    

Modified: 
    libc/test/src/math/exhaustive/hypotf_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/test/src/math/exhaustive/hypotf_test.cpp b/libc/test/src/math/exhaustive/hypotf_test.cpp
index 04da55d4d3a9f..f4c63eadb42e9 100644
--- a/libc/test/src/math/exhaustive/hypotf_test.cpp
+++ b/libc/test/src/math/exhaustive/hypotf_test.cpp
@@ -21,7 +21,7 @@ struct HypotfChecker : public virtual LIBC_NAMESPACE::testing::Test {
   using StorageType = typename FPBits::StorageType;
 
   uint64_t check(uint32_t start, uint32_t stop, mpfr::RoundingMode rounding) {
-    // Range of the second input: [2^37, 2^48).
+    // Range of the second input: [2^37, 2^48].
     constexpr uint32_t Y_START = (37U + 127U) << 23;
     constexpr uint32_t Y_STOP = (48U + 127U) << 23;
 
@@ -51,9 +51,9 @@ struct HypotfChecker : public virtual LIBC_NAMESPACE::testing::Test {
 
 using LlvmLibcHypotfExhaustiveTest = LlvmLibcExhaustiveMathTest<HypotfChecker>;
 
-// Range of the first input: [2^23, 2^24);
+// Range of the first input: [2^23, 2^24];
 static constexpr uint32_t START = (23U + 127U) << 23;
-static constexpr uint32_t STOP = ((23U + 127U) << 23) + 1;
+static constexpr uint32_t STOP = (24U + 127U) << 23;
 
 TEST_F(LlvmLibcHypotfExhaustiveTest, PositiveRange) {
   test_full_range_all_roundings(START, STOP);