[libc-commits] [libc] [libc][math][c23] Add acoshf16 C23 math function. (PR #130588)

Harrison Hao via libc-commits libc-commits at lists.llvm.org
Sat Mar 22 19:55:33 PDT 2025


harrisonGPU wrote:

> @harrisonGPU aarch64 failure:
> 
> ```
> FAILED: libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.acoshf16_test.__unit__ 
> cd /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/build/libc/test/src/math/smoke && /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/build/libc/test/src/math/smoke/libc.test.src.math.smoke.acoshf16_test.__unit__.__build__
> [==========] Running 1 test from 1 test suite.
> [ RUN      ] LlvmLibcAcoshf16Test.SpecialNumbers
> /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/acoshf16_test.cpp:22: FAILURE
>       Expected: __llvm_libc_20_0_0_git::fputil::test_except( static_cast<int>((0x1 | 0x2 | 0x4 | 0x8 | 0x10))) & ((0x4) ? (0x4) : static_cast<int>((0x1 | 0x2 | 0x4 | 0x8 | 0x10)))
>       Which is: 0
> To be equal to: (0x4)
>       Which is: 4
> ```
> 
> Can you investigate to see if it can be fixed quickly, or temporarily disable the assertion statement if you need more time?

I will remove libc.src.math.acoshf16 for aarch64

https://github.com/llvm/llvm-project/pull/130588


More information about the libc-commits mailing list