[libc-commits] [libc] change the return value type of mktime_internal to time_t (PR #132231)

via libc-commits libc-commits at lists.llvm.org
Thu Mar 20 08:28:17 PDT 2025


================
@@ -18,29 +18,41 @@ namespace LIBC_NAMESPACE_DECL {
 namespace time_utils {
 
 // TODO: clean this up in a followup patch
-int64_t mktime_internal(const tm *tm_out) {
+time_t mktime_internal(const tm *tm_out, bool* out_of_range_flag) {
----------------
lntue wrote:

This internal function does not take care of `nullptr` input.  It's better to change its signature to:
```
time_t mktime_internal(const tm &tm_out, bool& out_of_range_flag)
```

https://github.com/llvm/llvm-project/pull/132231


More information about the libc-commits mailing list