[libc-commits] [libc] [libc] Templatize the scanf Reader interface (PR #131037)

Mon Mar 17 23:58:20 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `libc` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/1542

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
0.502 [173/130/390] Building CXX object libc/src/stdlib/CMakeFiles/libc.src.stdlib.atexit.dir/atexit.cpp.o
0.503 [172/130/391] Building CXX object libc/src/stdio/gpu/CMakeFiles/libc.src.stdio.gpu.getc.dir/getc.cpp.o
0.504 [171/130/392] Building CXX object libc/src/stdio/gpu/CMakeFiles/libc.src.stdio.gpu.fgets.dir/fgets.cpp.o
0.508 [170/130/393] Building CXX object libc/src/stdlib/gpu/CMakeFiles/libc.src.stdlib.gpu.system.dir/system.cpp.o
0.509 [169/130/394] Building CXX object libc/src/stdio/gpu/CMakeFiles/libc.src.stdio.gpu.fread.dir/fread.cpp.o
0.512 [168/130/395] Building CXX object libc/src/stdio/gpu/CMakeFiles/libc.src.stdio.gpu.ungetc.dir/ungetc.cpp.o
0.517 [167/130/396] Building CXX object libc/src/stdio/gpu/CMakeFiles/libc.src.stdio.gpu.getchar.dir/getchar.cpp.o
0.528 [166/130/397] Building CXX object libc/src/stdio/gpu/CMakeFiles/libc.src.stdio.gpu.putchar.dir/putchar.cpp.o
0.537 [165/130/398] Building CXX object libc/src/assert/gpu/CMakeFiles/libc.src.assert.gpu.__assert_fail.dir/__assert_fail.cpp.o
0.540 [164/130/399] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.fscanf.dir/fscanf.cpp.o
FAILED: libc/src/stdio/CMakeFiles/libc.src.stdio.fscanf.dir/fscanf.cpp.o 
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -D__LIBC_USE_FLOAT16_CONVERSION -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc -isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -fpie -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -nogpulib -fvisibility=hidden -fconvergent-functions -flto -Wno-multi-gpu -Xclang -mcode-object-version=none -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -DLIBC_COPT_SCANF_DISABLE_FLOAT -DLIBC_COPT_SCANF_DISABLE_INDEX_MODE -MD -MT libc/src/stdio/CMakeFiles/libc.src.stdio.fscanf.dir/fscanf.cpp.o -MF libc/src/stdio/CMakeFiles/libc.src.stdio.fscanf.dir/fscanf.cpp.o.d -o libc/src/stdio/CMakeFiles/libc.src.stdio.fscanf.dir/fscanf.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/fscanf.cpp
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/fscanf.cpp:14:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:41:42: error: no member named 'getc' in namespace '__llvm_libc_21_0_0_git'; did you mean simply 'getc'?
   41 | LIBC_INLINE int getc(::FILE *f) { return LIBC_NAMESPACE::getc(f); }
      |                                          ^~~~~~~~~~~~~~~~~~~~
      |                                          getc
<command line>:1:24: note: expanded from macro 'LIBC_NAMESPACE'
    1 | #define LIBC_NAMESPACE __llvm_libc_21_0_0_git
      |                        ^
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:41:17: note: 'getc' declared here
   41 | LIBC_INLINE int getc(::FILE *f) { return LIBC_NAMESPACE::getc(f); }
      |                 ^
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:43:45: error: no member named 'ungetc' in namespace '__llvm_libc_21_0_0_git'; did you mean simply 'ungetc'?
   43 | LIBC_INLINE void ungetc(int c, ::FILE *f) { LIBC_NAMESPACE::ungetc(c, f); }
      |                                             ^~~~~~~~~~~~~~~~~~~~~~
      |                                             ungetc
<command line>:1:24: note: expanded from macro 'LIBC_NAMESPACE'
    1 | #define LIBC_NAMESPACE __llvm_libc_21_0_0_git
      |                        ^
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:43:18: note: 'ungetc' declared here
   43 | LIBC_INLINE void ungetc(int c, ::FILE *f) { LIBC_NAMESPACE::ungetc(c, f); }
      |                  ^
2 errors generated.
0.542 [164/129/400] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.vfscanf.dir/vfscanf.cpp.o
FAILED: libc/src/stdio/CMakeFiles/libc.src.stdio.vfscanf.dir/vfscanf.cpp.o 
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -D__LIBC_USE_FLOAT16_CONVERSION -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc -isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -fpie -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -nogpulib -fvisibility=hidden -fconvergent-functions -flto -Wno-multi-gpu -Xclang -mcode-object-version=none -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -DLIBC_COPT_SCANF_DISABLE_FLOAT -DLIBC_COPT_SCANF_DISABLE_INDEX_MODE -MD -MT libc/src/stdio/CMakeFiles/libc.src.stdio.vfscanf.dir/vfscanf.cpp.o -MF libc/src/stdio/CMakeFiles/libc.src.stdio.vfscanf.dir/vfscanf.cpp.o.d -o libc/src/stdio/CMakeFiles/libc.src.stdio.vfscanf.dir/vfscanf.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/vfscanf.cpp
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/vfscanf.cpp:14:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:41:42: error: no member named 'getc' in namespace '__llvm_libc_21_0_0_git'; did you mean simply 'getc'?
   41 | LIBC_INLINE int getc(::FILE *f) { return LIBC_NAMESPACE::getc(f); }
      |                                          ^~~~~~~~~~~~~~~~~~~~
      |                                          getc
<command line>:1:24: note: expanded from macro 'LIBC_NAMESPACE'
    1 | #define LIBC_NAMESPACE __llvm_libc_21_0_0_git
      |                        ^
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:41:17: note: 'getc' declared here
   41 | LIBC_INLINE int getc(::FILE *f) { return LIBC_NAMESPACE::getc(f); }
      |                 ^
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/stdio/scanf_core/vfscanf_internal.h:43:45: error: no member named 'ungetc' in namespace '__llvm_libc_21_0_0_git'; did you mean simply 'ungetc'?

```

</details>

https://github.com/llvm/llvm-project/pull/131037