[libc-commits] [libc] [libc] Remove use of C++ STL features from `rpc_server.cpp` (PR #131169)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Mar 13 12:24:26 PDT 2025


================
@@ -11,40 +11,82 @@
 #define __has_builtin(x) 0
 #endif
 
-// Make sure these are included first so they don't conflict with the system.
-#include <limits.h>
-
 #include "shared/rpc.h"
 #include "shared/rpc_opcodes.h"
 
+#include "src/__support/CPP/type_traits.h"
 #include "src/__support/arg_list.h"
 #include "src/stdio/printf_core/converter.h"
 #include "src/stdio/printf_core/parser.h"
 #include "src/stdio/printf_core/writer.h"
 
-#include <algorithm>
-#include <atomic>
-#include <cstdio>
-#include <cstring>
-#include <memory>
-#include <mutex>
-#include <unordered_map>
-#include <variant>
-#include <vector>
+#include <stdio.h>
+#include <stdlib.h>
----------------
michaelrj-google wrote:

if this is going to be a libc specific file, should these be moved to use our internal equivalents as well?

https://github.com/llvm/llvm-project/pull/131169


More information about the libc-commits mailing list