[libc-commits] [libc] [libc] Add `-Wsign-conversion` & un-reverts `-Wconversion` (PR #129811)

[Vinay Deshmukh via libc-commits]

================
@@ -36,8 +36,8 @@ function(_get_common_test_compile_options output_var c_test flags)
     if(NOT LIBC_WNO_ERROR)
       # list(APPEND compile_options "-Werror")
     endif()
-    # list(APPEND compile_options "-Wconversion")
-    # list(APPEND compile_options "-Wno-sign-conversion")
+    list(APPEND compile_options "-Wconversion")
+    list(APPEND compile_options "-Wsign-conversion")
----------------
vinay-deshmukh wrote:

Is there a way to reproduce these in the PR checks?

I don't have a x86 64 machine at the moment 

https://github.com/llvm/llvm-project/pull/129811