[libc-commits] [libc] Added type-generic macros for fixed-point functions (PR #129371)
Ishaan Verma via libc-commits
libc-commits at lists.llvm.org
Sat Mar 1 00:00:35 PST 2025
https://github.com/lazyprop created https://github.com/llvm/llvm-project/pull/129371
Adds macros `absfx`, `countlsfx` and `roundfx` .
ref: #129111
>From bc55d8cee6d751a2b7d0174dceec7c18e6bf7591 Mon Sep 17 00:00:00 2001
From: Ishaan Verma <ishaan56verma at gmail.com>
Date: Sat, 1 Mar 2025 13:20:29 +0530
Subject: [PATCH] added type-generic macros for abs, countls and round
---
libc/include/llvm-libc-macros/stdfix-macros.h | 40 +++++++++
libc/include/stdfix.yaml | 8 +-
libc/test/src/stdfix/CMakeLists.txt | 23 +++++
libc/test/src/stdfix/macros_test.cpp | 84 +++++++++++++++++++
4 files changed, 154 insertions(+), 1 deletion(-)
create mode 100644 libc/test/src/stdfix/macros_test.cpp
diff --git a/libc/include/llvm-libc-macros/stdfix-macros.h b/libc/include/llvm-libc-macros/stdfix-macros.h
index 554ebe544a42e..91c07bc34303d 100644
--- a/libc/include/llvm-libc-macros/stdfix-macros.h
+++ b/libc/include/llvm-libc-macros/stdfix-macros.h
@@ -323,6 +323,46 @@
#define ULACCUM_EPSILON 0x1.0p-32ULK
#endif // ULACCUM_EPSILON
+#define absfx(x) _Generic((x), \
+ fract: LIBC_NAMESPACE::absr, \
+ short fract: LIBC_NAMESPACE::abshr, \
+ long fract: LIBC_NAMESPACE::abslr, \
+ _Accum: LIBC_NAMESPACE::absk, \
+ short _Accum: LIBC_NAMESPACE::abshk, \
+ long _Accum: LIBC_NAMESPACE::abslk \
+)(x)
+
+#define countlsfx(x) _Generic((x), \
+ fract: LIBC_NAMESPACE::countlsr, \
+ short fract: LIBC_NAMESPACE::countlshr, \
+ long fract: LIBC_NAMESPACE::countlslr, \
+ _Accum: LIBC_NAMESPACE::countlsk, \
+ short _Accum: LIBC_NAMESPACE::countlshk, \
+ long _Accum: LIBC_NAMESPACE::countlslk, \
+ unsigned fract: LIBC_NAMESPACE::countlsur, \
+ unsigned short fract: LIBC_NAMESPACE::countlsuhr, \
+ unsigned long fract: LIBC_NAMESPACE::countlsulr, \
+ unsigned _Accum: LIBC_NAMESPACE::countlsuk, \
+ unsigned short _Accum: LIBC_NAMESPACE::countlsuhk, \
+ unsigned long _Accum: LIBC_NAMESPACE::countlsulk \
+)(x)
+
+#define roundfx(x, y) _Generic((x), \
+ fract: LIBC_NAMESPACE::roundr, \
+ short fract: LIBC_NAMESPACE::roundhr, \
+ long fract: LIBC_NAMESPACE::roundlr, \
+ _Accum: LIBC_NAMESPACE::roundk, \
+ short _Accum: LIBC_NAMESPACE::roundhk, \
+ long _Accum: LIBC_NAMESPACE::roundlk, \
+ unsigned fract: LIBC_NAMESPACE::roundur, \
+ unsigned short fract: LIBC_NAMESPACE::rounduhr, \
+ unsigned long fract: LIBC_NAMESPACE::roundulr, \
+ unsigned _Accum: LIBC_NAMESPACE::rounduk, \
+ unsigned short _Accum: LIBC_NAMESPACE::rounduhk, \
+ unsigned long _Accum: LIBC_NAMESPACE::roundulk \
+)(x, y)
+
+
#endif // LIBC_COMPILER_HAS_FIXED_POINT
#endif // LLVM_LIBC_MACROS_STDFIX_MACROS_H
diff --git a/libc/include/stdfix.yaml b/libc/include/stdfix.yaml
index 707e5a2b09819..29c4d8b5c8960 100644
--- a/libc/include/stdfix.yaml
+++ b/libc/include/stdfix.yaml
@@ -1,6 +1,12 @@
header: stdfix.h
header_template: stdfix.h.def
-macros: []
+macros:
+ - macro_name: absfx
+ macro_header: stdfix-macros.h
+ - macro_name: countlsfx
+ macro_header: stdfix-macros.h
+ - macro_name: roundfx
+ macro_header: stdfix-macros.h
types:
- type_name: stdfix-types
enums: []
diff --git a/libc/test/src/stdfix/CMakeLists.txt b/libc/test/src/stdfix/CMakeLists.txt
index 8dc0eb854e65c..a3dc25762f549 100644
--- a/libc/test/src/stdfix/CMakeLists.txt
+++ b/libc/test/src/stdfix/CMakeLists.txt
@@ -4,6 +4,7 @@ endif()
add_custom_target(libc-stdfix-tests)
+
foreach(suffix IN ITEMS hr r lr hk k lk)
add_libc_test(
abs${suffix}_test
@@ -176,3 +177,25 @@ add_libc_test(
libc.src.__support.fixed_point.fx_rep
libc.src.__support.FPUtil.basic_operations
)
+
+set(macros_depends)
+
+foreach(s IN ITEMS r hr lr k hk lk)
+ list(APPEND macros_depends
+ libc.src.stdfix.abs${s}
+ libc.src.stdfix.countls${s}
+ libc.src.stdfix.countlsu${s}
+ libc.src.stdfix.round${s}
+ libc.src.stdfix.roundu${s}
+ )
+endforeach()
+
+add_libc_test(
+ macros_test
+ SUITE libc-stdfix-tests
+ SRCS macros_test.cpp
+ DEPENDS
+ libc.include.stdfix
+ ${macros_depends}
+)
+
diff --git a/libc/test/src/stdfix/macros_test.cpp b/libc/test/src/stdfix/macros_test.cpp
new file mode 100644
index 0000000000000..6f6aec5c6defc
--- /dev/null
+++ b/libc/test/src/stdfix/macros_test.cpp
@@ -0,0 +1,84 @@
+//===-- Unittests for absfx -----------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "AbsTest.h"
+#include "src/stdfix/absr.h"
+#include "src/stdfix/abshr.h"
+#include "src/stdfix/abslr.h"
+#include "src/stdfix/absk.h"
+#include "src/stdfix/abshk.h"
+#include "src/stdfix/abslk.h"
+
+#include "src/stdfix/countlsr.h"
+#include "src/stdfix/countlshr.h"
+#include "src/stdfix/countlslr.h"
+#include "src/stdfix/countlsk.h"
+#include "src/stdfix/countlshk.h"
+#include "src/stdfix/countlslk.h"
+#include "src/stdfix/countlsur.h"
+#include "src/stdfix/countlsuhr.h"
+#include "src/stdfix/countlsulr.h"
+#include "src/stdfix/countlsuk.h"
+#include "src/stdfix/countlsuhk.h"
+#include "src/stdfix/countlsulk.h"
+
+#include "src/stdfix/roundr.h"
+#include "src/stdfix/roundhr.h"
+#include "src/stdfix/roundlr.h"
+#include "src/stdfix/roundk.h"
+#include "src/stdfix/roundhk.h"
+#include "src/stdfix/roundlk.h"
+#include "src/stdfix/roundur.h"
+#include "src/stdfix/rounduhr.h"
+#include "src/stdfix/roundulr.h"
+#include "src/stdfix/rounduk.h"
+#include "src/stdfix/rounduhk.h"
+#include "src/stdfix/roundulk.h"
+
+TEST(LlvmLibcAbsfxTest, Basic) {
+ ASSERT_EQ(absfx(-0.5r), LIBC_NAMESPACE::absr(-0.5r));
+ ASSERT_EQ(absfx(-0.5hr), LIBC_NAMESPACE::abshr(-0.5hr));
+ ASSERT_EQ(absfx(-0.5lr), LIBC_NAMESPACE::abslr(-0.5lr));
+ ASSERT_EQ(absfx(-0.5k), LIBC_NAMESPACE::absk(-0.5k));
+ ASSERT_EQ(absfx(-0.5hk), LIBC_NAMESPACE::abshk(-0.5hk));
+ ASSERT_EQ(absfx(-0.5lk), LIBC_NAMESPACE::abslk(-0.5lk));
+}
+
+TEST(LlvmLibcRoundfxTest, Basic) {
+ ASSERT_EQ(roundfx(0.75r, 0), LIBC_NAMESPACE::roundr(0.75r, 0));
+ ASSERT_EQ(roundfx(0.75hr, 0), LIBC_NAMESPACE::roundhr(0.75hr, 0));
+ ASSERT_EQ(roundfx(0.75lr, 0), LIBC_NAMESPACE::roundlr(0.75lr, 0));
+ ASSERT_EQ(roundfx(0.75k, 0), LIBC_NAMESPACE::roundk(0.75k, 0));
+ ASSERT_EQ(roundfx(0.75hk, 0), LIBC_NAMESPACE::roundhk(0.75hk, 0));
+ ASSERT_EQ(roundfx(0.75lk, 0), LIBC_NAMESPACE::roundlk(0.75lk, 0));
+
+ ASSERT_EQ(roundfx(0.75ur, 0), LIBC_NAMESPACE::roundur(0.75ur, 0));
+ ASSERT_EQ(roundfx(0.75uhr, 0), LIBC_NAMESPACE::rounduhr(0.75uhr, 0));
+ ASSERT_EQ(roundfx(0.75ulr, 0), LIBC_NAMESPACE::roundulr(0.75ulr, 0));
+ ASSERT_EQ(roundfx(0.75uk, 0), LIBC_NAMESPACE::rounduk(0.75uk, 0));
+ ASSERT_EQ(roundfx(0.75uhk, 0), LIBC_NAMESPACE::rounduhk(0.75uhk, 0));
+ ASSERT_EQ(roundfx(0.75ulk, 0), LIBC_NAMESPACE::roundulk(0.75ulk, 0));
+}
+
+
+TEST(LlvmLibcCountlsfxTest, Basic) {
+ ASSERT_EQ(countlsfx(0.5r), LIBC_NAMESPACE::countlsr(0.5r));
+ ASSERT_EQ(countlsfx(0.5hr), LIBC_NAMESPACE::countlshr(0.5hr));
+ ASSERT_EQ(countlsfx(0.5lr), LIBC_NAMESPACE::countlslr(0.5lr));
+ ASSERT_EQ(countlsfx(0.5k), LIBC_NAMESPACE::countlsk(0.5k));
+ ASSERT_EQ(countlsfx(0.5hk), LIBC_NAMESPACE::countlshk(0.5hk));
+ ASSERT_EQ(countlsfx(0.5lk), LIBC_NAMESPACE::countlslk(0.5lk));
+
+ ASSERT_EQ(countlsfx(0.5ur), LIBC_NAMESPACE::countlsr(0.5ur));
+ ASSERT_EQ(countlsfx(0.5uhr), LIBC_NAMESPACE::countlshr(0.5uhr));
+ ASSERT_EQ(countlsfx(0.5ulr), LIBC_NAMESPACE::countlslr(0.5ulr));
+ ASSERT_EQ(countlsfx(0.5uk), LIBC_NAMESPACE::countlsk(0.5uk));
+ ASSERT_EQ(countlsfx(0.5uhk), LIBC_NAMESPACE::countlshk(0.5uhk));
+ ASSERT_EQ(countlsfx(0.5ulk), LIBC_NAMESPACE::countlslk(0.5ulk));
+}
+
More information about the libc-commits
mailing list