[libc-commits] [libc] [libc] Fix feature check for riscv (PR #145169)
Hans Wennborg via libc-commits
libc-commits at lists.llvm.org
Mon Jun 23 05:59:56 PDT 2025
================
@@ -61,15 +61,15 @@
#if defined(__riscv_flen)
// https://github.com/riscv-non-isa/riscv-c-api-doc/blob/main/src/c-api.adoc
-#if (__riscv_flen & 0x10)
+#if (__riscv_arch_test && __riscv_zfhmin)
----------------
zmodem wrote:
We hit a compile error after this:
```
../../third_party/llvm-libc/src/src/__support/macros/properties/cpu_features.h:64:27: error: '__riscv_zfhmin' is not defined, evaluates to 0 [-Werror,-Wundef]
64 | #if (__riscv_arch_test && __riscv_zfhmin)
| ^
```
Should it be `#if ... defined(__riscv_zfhmin)` instead?
https://github.com/llvm/llvm-project/pull/145169
More information about the libc-commits
mailing list