[libc-commits] [libc] [libc] Implemented CharacterConverter push/pop for utf32->utf8 conversions (PR #143971)

Brooks Moses via libc-commits libc-commits at lists.llvm.org
Fri Jun 13 16:27:04 PDT 2025


================
@@ -29,8 +30,8 @@ class CharacterConverter {
   int push(char8_t utf8_byte);
   int push(char32_t utf32);
----------------
brooksmoses wrote:

I note that pushing a utf8 byte onto a state that hasn't been completely popped causes an error (in Sriya's implementation), but pushing a utf32 value onto a state that hasn't been completely popped doesn't error.  It would be good to be consistent with this, I think?

https://github.com/llvm/llvm-project/pull/143971


More information about the libc-commits mailing list