[libc-commits] [libc] [libc] utf8 to 32 CharacterConverter (PR #143973)

[Brooks Moses via libc-commits]

================
@@ -22,13 +25,65 @@ bool CharacterConverter::isComplete() {
   return state->bytes_processed == state->total_bytes;
 }
 
-int CharacterConverter::push(char8_t utf8_byte) {}
+int CharacterConverter::push(char8_t utf8_byte) {
+  // Checking the first byte if first push
+  if (state->bytes_processed == 0 && state->total_bytes == 0) {
+    state->partial = static_cast<char32_t>(0);
----------------
brooksmoses wrote:

Is this useful here?  You're completely setting state->partial in all of the paths except the error path, so why not move this to the error path?

https://github.com/llvm/llvm-project/pull/143973