[libc-commits] [libc] Turn LIBC_COPT_STRING_UNSAFE_WIDE_READ on by default (PR #144163)

[LLVM Continuous Integration via libc-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `libc` at step 10 "Add check check-libc-amdgcn-amd-amdhsa".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/7331

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 10 (Add check check-libc-amdgcn-amd-amdhsa) failure: test (failure)
...
Ran 1 tests.  PASS: 1  FAIL: 0
[2439/2807] Running hermetic test libc.test.src.math.smoke.logf_test.__hermetic__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcLogfTest.SpecialNumbers
[       OK ] LlvmLibcLogfTest.SpecialNumbers (23 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[2440/2807] Linking CXX executable libc/test/src/stdio/libc.test.src.stdio.fprintf_test.__hermetic__.__build__
[2441/2807] Linking CXX executable libc/test/src/string/libc.test.src.string.memchr_test.__hermetic__.__build__
[2442/2807] Linking CXX executable libc/test/src/math/smoke/libc.test.src.math.smoke.scalbn_test.__hermetic__.__build__
[2443/2807] Linking CXX executable libc/test/src/string/libc.test.src.string.stpcpy_test.__hermetic__.__build__
FAILED: libc/test/src/string/libc.test.src.string.stpcpy_test.__hermetic__.__build__ 
: && /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -Wno-multi-gpu -mcpu=native -flto -Wl,-mllvm,-amdgpu-lower-global-ctor-dtor=0 -nostdlib -static -Wl,-mllvm,-amdhsa-code-object-version=6 libc/startup/gpu/amdgpu/CMakeFiles/libc.startup.gpu.amdgpu.crt1.dir/start.cpp.o libc/test/src/string/CMakeFiles/libc.test.src.string.stpcpy_test.__hermetic__.__build__.dir/stpcpy_test.cpp.o -o libc/test/src/string/libc.test.src.string.stpcpy_test.__hermetic__.__build__  libc/test/UnitTest/libLibcTest.hermetic.a  libc/test/UnitTest/libLibcHermeticTestSupport.hermetic.a  libc/test/src/string/liblibc.test.src.string.stpcpy_test.__hermetic__.libc.a && :
ld.lld: error: Illegal instruction detected: Operand has incorrect register class.
renamable $sgpr8 = S_CSELECT_B32 0, killed $vgpr2, implicit $scc
clang++: error: ld.lld command failed with exit code 1 (use -v to see invocation)
[2444/2807] Running hermetic test libc.test.src.string.memccpy_test.__hermetic__
[==========] Running 6 tests from 1 test suite.
[ RUN      ] LlvmLibcMemccpyTest.UntouchedUnrelatedEnd
[       OK ] LlvmLibcMemccpyTest.UntouchedUnrelatedEnd (9 us)
[ RUN      ] LlvmLibcMemccpyTest.UntouchedStartsWithEnd
[       OK ] LlvmLibcMemccpyTest.UntouchedStartsWithEnd (3 us)
[ RUN      ] LlvmLibcMemccpyTest.CopyOneUnrelatedEnd
[       OK ] LlvmLibcMemccpyTest.CopyOneUnrelatedEnd (6 us)
[ RUN      ] LlvmLibcMemccpyTest.CopyOneStartsWithEnd
[       OK ] LlvmLibcMemccpyTest.CopyOneStartsWithEnd (5 us)
[ RUN      ] LlvmLibcMemccpyTest.CopyTwoUnrelatedEnd
[       OK ] LlvmLibcMemccpyTest.CopyTwoUnrelatedEnd (4 us)
[ RUN      ] LlvmLibcMemccpyTest.CopyTwoStartsWithEnd
[       OK ] LlvmLibcMemccpyTest.CopyTwoStartsWithEnd (5 us)
Ran 6 tests.  PASS: 6  FAIL: 0
[2445/2807] Running hermetic test libc.test.src.math.smoke.logf16_test.__hermetic__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcLogf16Test.SpecialNumbers
[       OK ] LlvmLibcLogf16Test.SpecialNumbers (29 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[2446/2807] Linking CXX executable libc/test/src/string/libc.test.src.string.strdup_test.__hermetic__.__build__
[2447/2807] Linking CXX executable libc/test/src/stdlib/libc.test.src.stdlib.heap_sort_test.__hermetic__.__build__
[2448/2807] Running hermetic test libc.test.src.math.smoke.log2_test.__hermetic__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcLog2Test.SpecialNumbers
[       OK ] LlvmLibcLog2Test.SpecialNumbers (26 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[2449/2807] Linking CXX executable libc/test/src/string/libc.test.src.string.stpncpy_test.__hermetic__.__build__
[2450/2807] Linking CXX executable libc/test/src/time/libc.test.src.time.clock_test.__hermetic__.__build__
[2451/2807] Linking CXX executable libc/test/include/libc.test.include.fpclassifyf_test.__hermetic__.__build__
[2452/2807] Linking CXX executable libc/test/include/libc.test.include.issubnormal_test.__hermetic__.__build__
[2453/2807] Linking CXX executable libc/test/include/libc.test.include.isnormall_test.__hermetic__.__build__
[2454/2807] Linking CXX executable libc/test/src/stdio/libc.test.src.stdio.vsscanf_test.__hermetic__.__build__
[2455/2807] Linking CXX executable libc/test/src/math/smoke/libc.test.src.math.smoke.fdivl_test.__hermetic__.__build__

```

</details>

https://github.com/llvm/llvm-project/pull/144163