[libc-commits] [libc] [libc] Implemented CharacterConverter push/pop for utf32->utf8 conversions (PR #143971)

Uzair Nawaz via libc-commits libc-commits at lists.llvm.org
Thu Jun 12 16:40:04 PDT 2025


================
@@ -22,13 +23,134 @@ bool CharacterConverter::isComplete() {
   return state->bytes_processed == state->total_bytes;
 }
 
-int CharacterConverter::push(char8_t utf8_byte) {}
+int CharacterConverter::push(char32_t utf32) {
+  state->partial = utf32;
+  state->bytes_processed = 0;
----------------
uzairnawaz wrote:

That would be a more descriptive name, but this struct is also used by the utf8->utf32 conversion. In that case bytes_processed is being incremented when pushing utf8 bytes.

https://github.com/llvm/llvm-project/pull/143971


More information about the libc-commits mailing list