[libc-commits] [libc] [libc] Migrate stdio tests to ErrnoCheckingTest. (PR #143802)

[LLVM Continuous Integration via libc-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-riscv32-qemu-yocto-fullbuild-dbg` running on `rv32gc-qemu-system` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/196/builds/8940

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
-- Build files have been written to: /home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/build
@@@BUILD_STEP build libc@@@
Running: ninja libc
ninja: no work to do.
@@@BUILD_STEP build libc-startup@@@
Running: ninja libc-startup
ninja: no work to do.
@@@BUILD_STEP libc-unit-tests@@@
Running: ninja libc-unit-tests
[1/1052] Building CXX object libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o
FAILED: libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o 
/usr/local/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -D_DEBUG -I/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc -isystem /home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/build/libc/include -mabi=ilp32d -march=rv32imafdc --target=riscv32-unknown-linux-gnu --sysroot=/opt/riscv/sysroot --gcc-toolchain=/opt/riscv -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -std=gnu++17 --target=riscv32-unknown-linux-gnu -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ffixed-point -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -MD -MT libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o -MF libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o.d -o libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o -c /home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:18:54: error: no type named 'ErrnoCheckingTest' in namespace '__llvm_libc_21_0_0_git::testing'
   18 | using LlvmLibcSetvbufTest = LIBC_NAMESPACE::testing::ErrnoCheckingTest;
      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~^
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:8: error: expected class name
   20 | TEST_F(LlvmLibcSetvbufTest, SetNBFBuffer) {
      |        ^
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: only virtual member functions can be marked 'override'
   20 | TEST_F(LlvmLibcSetvbufTest, SetNBFBuffer) {
      | ^
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:397:16: note: expanded from macro 'TEST_F'
  397 |     void Run() override;                                                       \
      |                ^
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: only virtual member functions can be marked 'override'
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:398:33: note: expanded from macro 'TEST_F'
  398 |     const char *getName() const override { return #SuiteClass "." #TestName; } \
      |                                 ^
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: use of undeclared identifier 'addTest'
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:396:33: note: expanded from macro 'TEST_F'
  396 |     SuiteClass##_##TestName() { addTest(this); }                               \
      |                                 ^
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:28:3: error: no matching function for call to 'test'
   28 |   ASSERT_FALSE(fw == nullptr);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:462:27: note: expanded from macro 'ASSERT_FALSE'
  462 | #define ASSERT_FALSE(VAL) ASSERT_EQ(VAL, false)
      |                           ^~~~~~~~~~~~~~~~~~~~~
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:438:29: note: expanded from macro 'ASSERT_EQ'
  438 | #define ASSERT_EQ(LHS, RHS) LIBC_TEST_BINOP_(EQ, LHS, RHS, return)
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:430:26: note: expanded from macro 'LIBC_TEST_BINOP_'
  430 |   LIBC_TEST_SCAFFOLDING_(test(LIBC_NAMESPACE::testing::TestCond::COND, LHS,    \
      |                          ^~~~
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:423:7: note: expanded from macro 'LIBC_TEST_SCAFFOLDING_'
  423 |   if (TEST)                                                                    \
      |       ^~~~
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:99:6: note: candidate function template not viable: requires 7 arguments, but 6 were provided
   99 | bool test(RunContext *Ctx, TestCond Cond, ValType LHS, ValType RHS,

```

</details>

https://github.com/llvm/llvm-project/pull/143802